-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Tabs overflow handling #50
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, @ieedan
Always appreciate your help. 🙂 Thank you very much for thoughtful polishes. Left 2 suggestions, please let me know what you think.
Also, liked your shadcn-svelte phone-input. If you'd like, please consider adding it to the list here: https://github.com/shyakadavis/awesome-shadcn-svelte 🙂
Thanks I should have some updates in an hour or two once I get back from lunch |
I tried a few of the solutions you sent I couldn't find anything much better than what I already have. I darkened up the shadow though so now it is more visible.
To make it work I have to wrap it in a Let me know what you think! |
Hey, @ieedan You're right. No easy solution would have worked without adding an unnecessary https://github.com/pyncz/tailwind-mask-image Before with blur: After with mask: |
Yeah that looks much better |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As always, grateful for the help, @ieedan
Thank you.
Ah, I see. Sorry for missing this. Mind opening a follow-up P.R please? I was working on the |
Might be indeed. 😅 Even if we were to reduce the |
I am gonna play with it a bit more hopefully I can get it to match up with what we have already |
My best idea at this point is to use a Pseudo-element to do this. In a perfect world I could just overlay a I am having a lot of trouble doing this right now and even if I can get the classes to apply we would still need to apply it to a parent container of the tabs because it moves during scroll. I think I'll have to circle back at another time. |
Currently the tabs component uses flex-wrap so the tabs stack on overflow.
no-scrollbar
class to hide the scrollbarpreBlur
andpostBlur
to show the user that there is more content to be scrolled.