-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scroll-to-Top button #1132
base: master
Are you sure you want to change the base?
Scroll-to-Top button #1132
Conversation
changes window view to top with new component PageUp
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @elijahlowe77! 🎉 Thank you for opening a pull request. Your contribution is valuable and we appreciate your efforts to improve our project.
Soon the maintainers/owner will review it and provide you with feedback/suggestions.
The button is not working. You might need to use a ref and scroll to top like how its done in the app.js file useEffect(() => {
profilesRef.current.scrollTo({
top: 0,
behavior: 'smooth',
});
}, [currentPage]); seeing that its already in the same file, you could take profilesRef as a prop and write that method when your button is clicked(redundant code) or you could turn this into a function and then take that function as a prop and simply run that function when your button is clicked. Also... please make an issue first before making your PR, we could have had a discussion and whether this was needed and the best location for it to be placed. P.S. not too sure about the design, looks plain and we already have 2 buttons there. Also the button text is kinda vague. |
Description
'added new component and folder PageUp that creates a button when clicked scrolls to top of page, placed over next page button. Also added profile
Related Issues
i used code sandbox, so the css elements did not load correctly in preview window for screenshots
Changes Proposed
Checklist
Screenshots
Note to reviewers