Skip to content

Commit

Permalink
Fix GitHub actions workflows
Browse files Browse the repository at this point in the history
- remove unnecessary trigger from PR workflow
- update actions/upload-artifact@v3 to v4
- fix token permissions
  • Loading branch information
mhartkorn committed Feb 3, 2025
1 parent 4bb0f65 commit 073e7d9
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/dotnet-main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ jobs:
branch-threshold: 0 # Default: 0, which means thresholds are not applied

- name: Upload coverage report artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: Coverage Report
path: coverage-results/**
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/dotnet-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@
# For more information see: https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-net
name: dotnet-pr
on:
workflow_dispatch:
pull_request:
branches: [ "main" ]
permissions:
contents: read
issues: read
issues: write
checks: write
pull-requests: write
actions: write
jobs:
build:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -68,7 +68,7 @@ jobs:
branch-threshold: 0 # Default: 0, which means thresholds are not applied

- name: Upload coverage report artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: Coverage Report
path: coverage-results/**
Expand Down

0 comments on commit 073e7d9

Please sign in to comment.