Conversation
Codecov Report
@@ Coverage Diff @@
## master #1 +/- ##
==========================================
+ Coverage 62.09% 62.73% +0.65%
==========================================
Files 8 8
Lines 910 931 +21
==========================================
+ Hits 565 584 +19
- Misses 345 347 +2
|
abraunst
reviewed
Sep 16, 2022
| .def("__repr__", &lexical_cast<string, Params>); | ||
| .def("__repr__", &lexical_cast<string, Params>) | ||
| .def("__copy__", [](const Params &s){ | ||
| return Params(s); |
Member
There was a problem hiding this comment.
Params contains smart pointers... are we sure that this is the correct way to do this? In the sense that this will be not be an "honest" deep copy, as e.g. prob_i and prob_r will still point to the old python object I think...
| return Params(s); | ||
| }) | ||
| .def("__deepcopy__", [](const Params &s, py::dict){ | ||
| return Params(s); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables pickling of
sib.Test, and copying ofsib.Paramsandsib.FactorGraph. This is needed in some cases when the rankers need to be copied in-memory.Also, align the code in some places, and add some comments.