core: add test for method option, bump package version

siddharthvp · Jun 16, 2024 · 4291fb1 · 4291fb1
1 parent 40fad44
commit 4291fb1
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 10 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
 	"name": "mwn",
-	"version": "2.0.2",
+	"version": "2.0.3",
 	"description": "JavaScript & TypeScript MediaWiki bot framework for Node.js",
 	"main": "./build/bot.js",
 	"types": "./build/bot.d.ts",

diff --git a/src/core.ts b/src/core.ts
@@ -38,7 +38,7 @@ export class Request {
 	}
 
 	getMethod() {
-		if (this.requestParams.method !== undefined) {
+		if (this.requestParams.method) {
 			return this.requestParams.method;
 		}
 		if (this.apiParams.action === 'query') {

diff --git a/tests/core.test.js b/tests/core.test.js
@@ -46,6 +46,18 @@ describe('core', function () {
 			expect(Response.prototype.handleRequestFailure).to.have.been.calledOnce;
 			sinon.restore();
 		});
+
+		it('honours method passed in custom options', async function () {
+			sinon.spy(Request.prototype, 'handlePost');
+			sinon.spy(Request.prototype, 'handleGet');
+			let scope = nock('http://localhost:8080/api.php').post(/.*?/).times(1).reply(200, '{}');
+			await bot.request({ action: 'query' }, { method: 'post' });
+			expect(Request.prototype.handlePost).to.have.been.calledOnce;
+			expect(Request.prototype.handleGet).to.not.have.been.called;
+			expect(scope.isDone()).to.be.true;
+			sinon.restore();
+			nock.cleanAll();
+		});
 	});
 
 	describe('Response', function () {