plural - singular unit decision now detects 0 and 1 instead of just 1 #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddii
added a commit
that referenced
this pull request
Oct 24, 2014
plural - singular unit decision now detects 0 and 1 instead of just 1
|
Thanks for the PR 👍 |
|
Why was this changed? The correct use is 0 hours, 0 minutes, 0 seconds. Not 0, day, 0 hour, 0 minute, 0 second. Zero is always plural in English. 0 books, 0 cars, 0 things. |
|
Should we do a pull request to the English language to fix this ? Sorry about that. Could we use a i18n config to allow "no s" on language using "no s" for 0 (french, Spanish, Italian and so on)? I might do a PR for that |
|
Yeah the zero-unit pluralization can be different in different languages, maybe there is a solution to let the user decide the method. Made a PR for new unit functions so custom strings can now be added (not just appending a 's'). If this gets merged then maybe add some more functionality to that for choosing zero-pluralization? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.