Sidepit Api Beta version 2 - Multi Product support #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR introduces API Beta version 2 to support multi-product trading capabilities. The changes extend the protocol buffer definitions to handle multiple products simultaneously, introduce new margin calculation structures, and deprecate several single-product-focused fields.
Changes:
- Added new messages for multi-product support (ContractScheduleProducts, AccountTickerPosition, ContractMargin, AccountMarginState)
- Added transaction rejection handling (RejectedTransaction message and RejectCode enum)
- Introduced ticker fields to MarketData and OrderData messages for product identification
- Deprecated single-product fields in AccountState and introduced detailed margin tracking per contract
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Version of API - Data to handle multiple products trading at once,