fix: do not build unneeded utilities and man for SELinux libraries #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frezbo
approved these changes
Nov 5, 2024
smira
approved these changes
Nov 5, 2024
| --- a/Makefile | ||
| +++ b/Makefile | ||
| @@ -4,26 +4,21 @@ export DISABLE_CIL | ||
|
|
There was a problem hiding this comment.
if we don't want to maintain patches, we can also let it build, but then do rm -rf /rootfs/usr/....
There was a problem hiding this comment.
They aren't likely to change that often. Maybe I should send a patch upstream so there's an option like SUBDIRS in libselinux
There was a problem hiding this comment.
Upstreamed a couple of change for SUBDIRS in every lib.
|
@dsseng should we rebase/merge this? |
Should we keep the patch or delete built stuff? See my response. After closing that thread it's good to go |
up to you, it's your call |
Utilities end up on rootfs increasing size and binary count Fixes siderolabs#1067 Signed-off-by: Dmitry Sharshakov <dmitry.sharshakov@siderolabs.com>
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Utilities end up on rootfs increasing size and binary count
Fixes #1067
Signed-off-by: Dmitry Sharshakov dmitry.sharshakov@siderolabs.com