Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable FUSION_SPI driver #871

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

smira
Copy link
Member

@smira smira commented Jan 22, 2024

It seems to be used by VMWare when virtualizing storage device as a SCSI disk.

Investigation by James Ringer from the community Slack.

udevadm info -a -n /dev/sda | grep -oP 'DRIVERS?=="\K[^"]+'
sd
mptspi

It seems to be used by VMWare when virtualizing storage device as a SCSI
disk.

Investigation by James Ringer from the community Slack.

```
udevadm info -a -n /dev/sda | grep -oP 'DRIVERS?=="\K[^"]+'
sd
mptspi
```

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
@smira
Copy link
Member Author

smira commented Jan 22, 2024

Note: when backporting to 1.6.x, make it =y.

@smira
Copy link
Member Author

smira commented Jan 22, 2024

New module:

├── message
│   └── fusion
│       └── [ 66K]  mptspi.ko

@frezbo
Copy link
Member

frezbo commented Jan 22, 2024

Note: when backporting to 1.6.x, make it =y.

is this just to avoid updateing modules.txt in talos ?

@smira
Copy link
Member Author

smira commented Jan 22, 2024

Note: when backporting to 1.6.x, make it =y.

is this just to avoid updateing modules.txt in talos ?

no, Talos 1.6 doesn't have it as modules (storage stuff).

@smira
Copy link
Member Author

smira commented Jan 22, 2024

/m

@talos-bot talos-bot merged commit 2358efe into siderolabs:main Jan 22, 2024
14 checks passed
smira added a commit to smira/talos that referenced this pull request Jan 22, 2024
See siderolabs/pkgs#871

This should fix issues with VMWare SCSI disk virtualization.

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
@jameshearttech
Copy link

jameshearttech commented Jan 22, 2024

I confirmed that the disks are available after changing the storage controller from SCSI to SATA as was suggested in Slack. I suspect the SATA controller is less performant so that's probably not ideal, but atleast we have a workaround until we can test this fix.

For reference we have a few options under SCSI controller for SCSI bus sharing and the kubeadm node I checked was configured to use LSI Logic Parallel, but I don't know if mptspi is a requirement of the SCSI controller or if it's specific to LSI Logic Parallel.

  • BusLogic Parallel
  • LSI Logic Parallel
  • LSI Logic SAS
  • VMware Paravirtual

@jameshearttech
Copy link

jameshearttech commented Jan 24, 2024

I tested v1.6.3 ISO on my end with SCSI controller and LSI Logic Parallel bus sharing option and confirmed the fix works as expected!

@frezbo
Copy link
Member

frezbo commented Jan 25, 2024

I tested v1.6.3 ISO on my end with SCSI controller and LSI Logic Parallel bus sharing option and confirmed the fix works as expected!

if you have Talos already installed iso would just boot that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backported
Development

Successfully merging this pull request may close these issues.

4 participants