Skip to content

Refactor and Optimize Effect Handling #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RachitSrivastava12 wants to merge 1 commit into
base: attempt-2
Choose a base branch
from
Open

Refactor and Optimize Effect Handling #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions src/effects.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,28 +10,32 @@ export interface EffectMeta {
seq?: number;
}

export interface Effect<P = any> {
export interface Effect<P = unknown> {
readonly type: EffectType;
readonly payload: P;
readonly meta: EffectMeta;
}

export interface EffectWithPayload<P> extends Effect<P> {
payload: P;
}
export type EffectWithPayload<P> = Effect<P>;

export function createEffect<P>(type: EffectType, payload: P, meta: EffectMeta = {}): Effect<P> {
export function createEffect<P>(
type: EffectType,
payload: P,
meta: EffectMeta = {}
): EffectWithPayload<P> {
return { type, payload, meta };
}

export interface TradeEffectPayload {
readonly price: string;
readonly size: string; // TODO: Name?
readonly size: string;
readonly side: TradeSide;
}

export interface TradeEffect extends EffectWithPayload<TradeEffectPayload> {}
export type TradeEffect = EffectWithPayload<TradeEffectPayload>;

export const tradeEffect = (payload: TradeEffectPayload) => createEffect(EffectType.Trade, payload);
export const tradeEffect = (payload: TradeEffectPayload): TradeEffect =>
createEffect(EffectType.Trade, payload);

export const isTradeEffect = (effect: Effect): effect is TradeEffect => effect.type === EffectType.Trade;
export const isTradeEffect = (effect?: Effect): effect is TradeEffect =>
effect?.type === EffectType.Trade;