Merged
Conversation
Collaborator
Author
Another suggestion could be using only the Node.js LTS: node-version: [20.x]
mysql-version: ['mysql:8.0.33']
use-compression: [0, 1]
use-tls: [0, 1] |
wellwelwel
changed the title
mysql:8.0.22 matrix from OSX
Owner
|
👍 |
sidorares
approved these changes
Jan 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's been some time that GitHub has been failing
macOS-basedtests.These false positives motivated two other PRs (#2308 and #2348), but the problem isn't really with the CI.
Since the tests "against" the MySQL Server already take place in
CI - Linux, I would like to propose that the test focus on Node.js versions formacOS-basedtests (how it's already done inCI - Windows), reducing the chance of false positives.Currently, I frequently try and retry the
CI - OSXuntil it passes without false positives.