Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: refactor CI - OSX #2349

Merged
merged 2 commits into from
Jan 11, 2024
Merged

ci: refactor CI - OSX #2349

merged 2 commits into from
Jan 11, 2024

Conversation

wellwelwel
Copy link
Collaborator

@wellwelwel wellwelwel commented Jan 9, 2024

See this PR also as a discussion based on "osx is a low priority and intended to be a smoke test" comment.

It's been some time that GitHub has been failing macOS-based tests.

These false positives motivated two other PRs (#2308 and #2348), but the problem isn't really with the CI.


Since the tests "against" the MySQL Server already take place in CI - Linux, I would like to propose that the test focus on Node.js versions for macOS-based tests (how it's already done in CI - Windows), reducing the chance of false positives.


Currently, I frequently try and retry the CI - OSX until it passes without false positives.

@wellwelwel wellwelwel requested a review from sidorares January 9, 2024 02:41
@wellwelwel
Copy link
Collaborator Author

wellwelwel commented Jan 9, 2024

In this PR with less OSX jobs, it reported 2 errors until I tried again 🤔

Another suggestion could be using only the Node.js LTS:

node-version: [20.x]
mysql-version: ['mysql:8.0.33']
use-compression: [0, 1]
use-tls: [0, 1]

@wellwelwel wellwelwel changed the title ci: remove mysql:8.0.22 matrix from OSX ci: refactor CI - OSX Jan 9, 2024
@sidorares
Copy link
Owner

👍

@wellwelwel wellwelwel merged commit ffc8254 into sidorares:master Jan 11, 2024
52 checks passed
@wellwelwel wellwelwel deleted the osx branch January 18, 2024 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants