Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prepared-statements.mdx #2405

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

bhanuprakashbahoju
Copy link
Contributor

the link in the page was not changed when deployed, it was still routing to localhost. changed to github.io link, now working properly.

the link in the page was not changed when deployed, it was still routing to localhost.
changed to github.io link, now working properly.
@wellwelwel
Copy link
Collaborator

Thanks, @bhanuprakashbahoju 🙋🏻‍♂️

Just a small suggestion:

- (https://sidorares.github.io/node-mysql2/docs/examples/queries/prepared-statements)
+ (/docs/examples/queries/prepared-statements)

It will improve the user-friendliness of the React routes (Docusaurus).

updated as per feedback
@bhanuprakashbahoju
Copy link
Contributor Author

thanks for the suggestion

@wellwelwel wellwelwel merged commit 2fe4061 into sidorares:master Jan 29, 2024
53 checks passed
@bhanuprakashbahoju bhanuprakashbahoju deleted the new_branch branch January 29, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants