-
-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve coverage and good practices for tests #2472
Conversation
@sidorares, if do you like, we can upload the coverage results to Codecov ☔️
To do this, you'll need to create a secret called If you do, send me a ping and I'll adapt the coverage workflow 🙋🏻♂️ An example: |
sure, I'm ok to use codecov, I'll add the secret do you know if codecov can merge multiple coverage results or do we need to do that ourselves? Different matrix runs skip some parts ( platform of feature flags specific ) so Ideally we want to consider the "union" of all matrix run coverages |
That's why I migrated the coverage CI to its own workflow, which is happening now 🙋🏻♂️ I don't know if it's clear, but using Poku, it runs all the tests (CJS and ESM) in a unique flow, so there's no need to merge multiple coverage results, since there is no longer distinction between the previous
|
Looking at the Codecov documentation, it says that Codecov will search for all "coverage" files available. Alternatively, we can specify the files manually.
|
@wellwelwel |
@sidorares, all done ☔️
By using Poku to fully test MySQL2, in addition to the prestige of it, it's an even greater incentive to continue investing on it. So, thank you again 💙 |
Refactoring Every Test 🔬
CI
latest
and migrateci-bun.yml
toci-linux.yml
latest
) in a specific CI (ci-mysql.yml
)0|1
and Compression0|1
c8 ... npm run test
to generate the coverage dataTests
.test.
builtin-runner
has been moved toesm
select
tests.esm
in test/esm, all tests in test/unit and test/integration are now.cjs
.test.
should to remove the false positives warnings from CodeQL in tests (I guess) 🧑🏻🔧Dependencies
Some problems were found 🐞
namedPlaceholders