Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(security): improve results object creation #2574

Merged
merged 3 commits into from
Apr 9, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ci: improve tests
  • Loading branch information
wellwelwel committed Apr 9, 2024
commit 2d0f8899122788c3ba21422799ca8e301327c8ec
7 changes: 7 additions & 0 deletions test/esm/unit/parsers/prototype-binary-results.test.mjs
Original file line number Diff line number Diff line change
@@ -50,6 +50,13 @@ Promise.all([
'2.00',
'Ensure that the end-user is able to use prototypes (manually): toFixed',
);

results[0].customProp = true;
assert.strictEqual(
results[0].customProp,
true,
'Ensure that the end-user is able to use custom props',
);
}),
test(async () => {
const [result] = await connection.execute('SET @1 = 1;');
7 changes: 7 additions & 0 deletions test/esm/unit/parsers/prototype-text-results.test.mjs
Original file line number Diff line number Diff line change
@@ -50,6 +50,13 @@ Promise.all([
'2.00',
'Ensure that the end-user is able to use prototypes (manually): toFixed',
);

results[0].customProp = true;
assert.strictEqual(
results[0].customProp,
true,
'Ensure that the end-user is able to use custom props',
);
}),
test(async () => {
const [result] = await connection.query('SET @1 = 1;');