Skip to content

ci: adapt tests for MySQL v9 #2834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Conversation

wellwelwel
Copy link
Collaborator

@wellwelwel wellwelwel commented Jul 8, 2024

Some tests statically check for MySQL Server v8, where otherwise they understood it as v5.

These adjustments ensure that the tests dynamically check for MySQL Server versions.

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.34%. Comparing base (f23c0f1) to head (c2be887).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2834   +/-   ##
=======================================
  Coverage   90.34%   90.34%           
=======================================
  Files          71       71           
  Lines       15749    15749           
  Branches     1350     1351    +1     
=======================================
  Hits        14228    14228           
  Misses       1521     1521           
Flag Coverage Δ
compression-0 90.34% <ø> (ø)
compression-1 90.34% <ø> (ø)
tls-0 89.86% <ø> (ø)
tls-1 90.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wellwelwel wellwelwel marked this pull request as ready for review July 8, 2024 03:28
@wellwelwel wellwelwel merged commit e905064 into sidorares:master Jul 8, 2024
68 checks passed
@wellwelwel wellwelwel deleted the ci-mysql9 branch July 8, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant