Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: datetime fields returned without time part when time is 00:00:00 #3204

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

w666
Copy link
Contributor

@w666 w666 commented Nov 12, 2024

Fixes #1040.

@w666
Copy link
Contributor Author

w666 commented Nov 12, 2024

@sidorares this is pretty much the same as #1147.
I am not familiar with poku, but it was very easy to update existing test, hopefully this is enough.

@wellwelwel wellwelwel changed the title fix #1040 datetime fields returned without time part when time is 00:00:00 fix: datetime fields returned without time part when time is 00:00:00 Nov 12, 2024
@w666 w666 force-pushed the fix-datetime-midnight branch from 772c48c to 13f7288 Compare November 12, 2024 19:16
@w666
Copy link
Contributor Author

w666 commented Nov 12, 2024

Sorry for the failed build, transferred that patch from work machine to submit from my personal one and it did not work as expected, fixing now.

@w666 w666 force-pushed the fix-datetime-midnight branch from 13f7288 to df91ce0 Compare November 12, 2024 19:33
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.13%. Comparing base (30a278b) to head (df91ce0).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
lib/parsers/binary_parser.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3204      +/-   ##
==========================================
+ Coverage   87.33%   88.13%   +0.79%     
==========================================
  Files          71       71              
  Lines       12890    12892       +2     
  Branches     1324     1357      +33     
==========================================
+ Hits        11258    11362     +104     
+ Misses       1632     1530     -102     
Flag Coverage Δ
compression-0 88.13% <88.88%> (+0.79%) ⬆️
compression-1 88.13% <88.88%> (?)
tls-0 87.55% <88.88%> (?)
tls-1 87.89% <88.88%> (+0.55%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sidorares sidorares merged commit bded498 into sidorares:master Nov 14, 2024
78 checks passed
@wellwelwel wellwelwel mentioned this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

datetime fields returned as date when time is 00:00:00
2 participants