fix(core/menu): use label property to render internal menu items (#1293)

siemens · May 23, 2024 · fb48f05 · fb48f05
1 parent 53f7744
commit fb48f05
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 12 deletions.
diff --git a/.changeset/tame-shrimps-press.md b/.changeset/tame-shrimps-press.md
@@ -0,0 +1,5 @@
+---
+"@siemens/ix": patch
+---
+
+fix(core/menu): use label property to render internal menu items
diff --git a/packages/core/src/components/menu/menu.tsx b/packages/core/src/components/menu/menu.tsx
@@ -681,9 +681,8 @@ export class Menu {
               }}
               icon={'cogwheel'}
               onClick={async () => this.toggleSettings(!this.showSettings)}
-            >
-              {this.i18nSettings}
-            </ix-menu-item>
+              label={this.i18nSettings}
+            ></ix-menu-item>
           ) : null}
           <div onClick={(e) => this.onMenuItemsClick(e)}>
             <slot name="bottom"></slot>
@@ -701,9 +700,8 @@ export class Menu {
               }}
               icon={'info'}
               onClick={async () => this.toggleAbout(!this.showAbout)}
-            >
-              {this.i18nLegal}
-            </ix-menu-item>
+              label={this.i18nLegal}
+            ></ix-menu-item>
           ) : null}
           {this.enableToggleTheme ? (
             <ix-menu-item
@@ -712,9 +710,8 @@ export class Menu {
               onClick={() => themeSwitcher.toggleMode()}
               class="internal-tab bottom-tab"
               icon={'light-dark'}
-            >
-              {this.i18nToggleTheme}
-            </ix-menu-item>
+              label={this.i18nToggleTheme}
+            ></ix-menu-item>
           ) : null}
           {this.enableMapExpand || this.applicationLayoutContext?.sidebar ? (
             <ix-menu-item
@@ -723,9 +720,8 @@ export class Menu {
               onClick={() => this.sidebarToggle()}
               class="internal-tab bottom-tab"
               icon={`${this.getCollapseIcon()}`}
-            >
-              {this.getCollapseText()}
-            </ix-menu-item>
+              label={this.getCollapseText()}
+            ></ix-menu-item>
           ) : null}
         </aside>
         <div