Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/chip): applied inactive state to host #1683

Merged
merged 4 commits into from
Feb 13, 2025

Conversation

ridvandmrc
Copy link
Contributor

💡 What is the current behavior?

Settings propery active to false in ix chip does not do what it says. It stays interactable.

GitHub Issue Number: #1656

🆕 What is the new behavior?

  • previous implementation was wrong I just moved the inactive class from container to host

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented Feb 7, 2025

🦋 Changeset detected

Latest commit: 452a1fd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@siemens/ix Patch
@siemens/ix-angular Patch
@siemens/ix-react Patch
@siemens/ix-vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ridvandmrc
Copy link
Contributor Author

I might be change scss file but this usage seems better for me. If you want to update scss file I mean move the style from host to container class please let me know

@danielleroux
Copy link
Collaborator

I might be change scss file but this usage seems better for me. If you want to update scss file I mean move the style from host to container class please let me know

Its fine how you did it. We consider a general rework of host component selectors to reduce conflicts with other css frameworks, but its not yet finalized.

@AndreasBerliner
Copy link
Collaborator

Hi @ridvandmrc and thank you for your contribution.
With your approach not all css styles are applied, since the 'inactive' CSS class is expected on the container element. One solution would be to add this class to both the host and the container element.

@ridvandmrc
Copy link
Contributor Author

Hi @ridvandmrc and thank you for your contribution. With your approach not all css styles are applied, since the 'inactive' CSS class is expected on the container element. One solution would be to add this class to both the host and the container element.

I see your point, I added 'inactive class' to container.

@ridvandmrc ridvandmrc reopened this Feb 11, 2025
@nuke-ellington nuke-ellington merged commit aa63b4f into siemens:main Feb 13, 2025
15 checks passed
@github-actions github-actions bot mentioned this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants