-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core/chip): applied inactive state to host #1683
Conversation
🦋 Changeset detectedLatest commit: 452a1fd The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I might be change scss file but this usage seems better for me. If you want to update scss file I mean move the style from host to container class please let me know |
Its fine how you did it. We consider a general rework of host component selectors to reduce conflicts with other css frameworks, but its not yet finalized. |
Hi @ridvandmrc and thank you for your contribution. |
9981289
to
79d2184
Compare
I see your point, I added 'inactive class' to container. |
|
💡 What is the current behavior?
Settings propery active to false in ix chip does not do what it says. It stays interactable.
GitHub Issue Number: #1656
🆕 What is the new behavior?
🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
pnpm run docs
)pnpm test
)pnpm lint
)pnpm build
, changes pushed)👨💻 Help & support