Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vue): add v-model support to ix-select and ix-toggle #1280

Closed
wants to merge 2 commits into from

Conversation

tiagogviegas
Copy link

💡 What is the current behavior?

IxSelect and IxToggle don't support v-model directive out of the box. Being components that often are used in form control v-model support should exist.

🆕 What is the new behavior?

  • Updated vueOutputTarget options to enable support for v-model binding in ix-select and ix-toggle.

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented May 16, 2024

🦋 Changeset detected

Latest commit: 239c7f5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@siemens/ix Minor
@siemens/ix-vue Minor
@siemens/ix-aggrid Patch
@siemens/ix-angular Minor
@siemens/ix-react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good but it might look even nicer if we could set up v-model support for all iX components ;-) Not sure how much effort this would be though..

@tiagogviegas
Copy link
Author

PR looks good but it might look even nicer if we could set up v-model support for all iX components ;-) Not sure how much effort this would be though..

Do we have a list of which components make sense to add v-model support? In my opinion it would only make sense to add it to components which have a 2-way data binding logic.

@nuke-ellington
Copy link
Collaborator

PR looks good but it might look even nicer if we could set up v-model support for all iX components ;-) Not sure how much effort this would be though..

Do we have a list of which components make sense to add v-model support? In my opinion it would only make sense to add it to components which have a 2-way data binding logic.

Unfortunately no. One would have to check all components manually.

@danielleroux
Copy link
Collaborator

danielleroux commented Jun 24, 2024

We be implemented in #1318

Also found an bug inside stencil vue output target which is patched in PR

const eventsNames = Array.isArray(modelUpdateEvent) ? modelUpdateEvent : [modelUpdateEvent];
eventsNames.forEach((eventName: string) => {
- el.addEventListener(eventName.toLowerCase(), (e: Event) => {
+ // Remove eventName.toLowerCase() from original 0.8.8 to not mutate event naming
+ el.addEventListener(eventName, (e: Event) => {

Close this one here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants