Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(checkbox-group): fixed checkbox scroll issue #1362

Closed
wants to merge 2 commits into from
Closed

fix(checkbox-group): fixed checkbox scroll issue #1362

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d122fe3
fix(checkbox-group): fixed checkbox scroll issue
Jun 28, 2024
d5e991e
Merge branch 'main' into fix/checkbox-group-scroll
nuke-ellington Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/core/scss/components/_checkboxes.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
min-width: 0px;
overflow: hidden;
position: absolute;
display: none;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might be the better solution since this will allow a screen reader to still access the input element

Suggested change
display: none;
visibility: hidden;

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ridvandmrc could you please take anther look at my comment so we can finalise the PR?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After additional research we realized that both versions will remove the element from the a11y tree. This could be a problem for users relying on screen reader technology.

white-space: nowrap;
appearance: none;
}
Expand Down
Loading