Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: overlapping of stepper-button and value #1672

Merged
merged 28 commits into from
Feb 10, 2025
Merged

Conversation

matthiashader
Copy link
Collaborator

@matthiashader matthiashader commented Jan 29, 2025

💡 What is the current behavior?

  • when initially hidden, the input has no dimension so getBoundingCientRect returns 0 in any dimension
  • as a consequence no padding is applied

GitHub Issue Number: #N/A, [IX-2196]

🆕 What is the new behavior?

  • an intersection observer is applied, checking if the element is visible
  • if not the observer is listening
  • when visible the updatePaddings is applied again

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented Jan 29, 2025

🦋 Changeset detected

Latest commit: eebf9b7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@siemens/ix Patch
@siemens/ix-angular Patch
@siemens/ix-react Patch
@siemens/ix-vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Co-authored-by: Julian Lamplmair <151610373+jul-lam@users.noreply.github.com>
jul-lam and others added 6 commits February 3, 2025 14:35
Co-authored-by: AndreasBerliner <41509230+AndreasBerliner@users.noreply.github.com>
Co-authored-by: AndreasBerliner <41509230+AndreasBerliner@users.noreply.github.com>
Co-authored-by: AndreasBerliner <41509230+AndreasBerliner@users.noreply.github.com>
Co-authored-by: AndreasBerliner <41509230+AndreasBerliner@users.noreply.github.com>
Co-authored-by: AndreasBerliner <41509230+AndreasBerliner@users.noreply.github.com>
Co-authored-by: AndreasBerliner <41509230+AndreasBerliner@users.noreply.github.com>
@nuke-ellington nuke-ellington merged commit 4558698 into main Feb 10, 2025
15 checks passed
@nuke-ellington nuke-ellington deleted the fix/2196-number-input branch February 10, 2025 13:32
@github-actions github-actions bot mentioned this pull request Jan 30, 2025
@jul-lam jul-lam mentioned this pull request Feb 11, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants