-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core/date-/datetime-input): Add new components ix-date-input and ix-datetime-input #861
Conversation
…into date-picker-refactor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes plus:
- VRT for disabled state is missing
- VRT for label positions are missing
...input/date-input.e2e.ts-snapshots/date-input-range-1-chromium---theme-classic-dark-linux.png
Outdated
Show resolved
Hide resolved
...tetime-input.e2e.ts-snapshots/datetime-input-range-1-chromium---theme-classic-dark-linux.png
Outdated
Show resolved
Hide resolved
[IX-641] has some UX TBDs that need to be clarified before this can be finalized |
|
I don't know how to implement 1:1 representation of the figma spec. I am now setting the width of the inputs based on the placeholder attribute, which is usually wider than an entered value, which makes it appear to have more margin. |
|
|
|
Will be implemented with #1318 |
Pull request checklist
Please check if your PR fulfills the following requirements:
yarn build
) was run locally and any changes were pushedyarn test
) were run locally and passedyarn visual-regression
) were run locally and passednpm lint
) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the new behavior?
Does this introduce a breaking change?
Testing
Added component tests and snapshot tests for both components