Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[네트워크 모듈 개선 v2] 네트워크 쓰레드 제어 #42

Merged
merged 31 commits into from
Dec 3, 2023

Conversation

sieunju
Copy link
Owner

@sieunju sieunju commented Dec 2, 2023

내용

  • 네트워크 쓰레드 제어하는 PauseAbleThreadPoolExecutor 클래스 추가

- network_v2, network_v2_bridge 모듈 추가
- 기존 있었던 이슈 대응
- Network 모듈에 연결
- GoodsParameter 방식 변경
- 네트워크 v2 API 추가
- 화면 구성 및 버튼 이벤트 구성
- 에러 바디 테스트
- ApiResponse 모델 개선
- JSendException 안에 케이스 별로 처리
- 코루틴 Adapter 함수 개선
- 네트워크 처리 예제 추가
- 토큰 받는 API 추가 및 간단한 예제 코드 추가
- 각 피처모듈마다 ApiService 생성하는 함수 좀더 간단한 방식으로 개선
- Rx 와 Coroutine 을 사용하는 환경에서 토큰 만료시 쓰레드 컨트롤 할수 있는 클래스 추가
- PauseAbleThreadPoolExecutor 추가
- PauseAbleThreadPoolExecutor 매개변수 Retrofit 사용하지 않고 더 밑단인 OkHttpClient 로 처리하도록 변경
- 분단위로 API 테스트하는 환경 구성
- java.io.InterruptedIOException: executor rejected 이슈 대응 쓰레드 거부 정책 변경
- java.io.InterruptedIOException: executor rejected 이슈 대응 쓰레드 거부 정책 변경
- PauseAbleThreadPoolExecutor 스펙 변경
- CorePoolSize 4 변경
- Refresh Token API 재시도 처리하는 로직 반영
- Authenticator 에서도 Refresh Token API 추가
- PreferenceManager 토큰 처리하는 함수 추가
@sieunju sieunju added feature 기능 추가 & 공부한내용 refactor 리펙토링 labels Dec 2, 2023
@sieunju sieunju self-assigned this Dec 2, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

ktlint

core/src/main/java/com/hmju/core/network/adapter/PauseAbleThreadPoolExecutor.kt|82 col 9| a block comment may not be preceded by an EOL comment unless separated by a blank line
core/src/main/java/com/hmju/core/network/adapter/PauseAbleThreadPoolExecutor.kt|161 col 19| A multiline expression should start on a new line
core/src/main/java/com/hmju/core/network/adapter/PauseAbleThreadPoolExecutor.kt|205 col 9| No whitespace expected between opening parenthesis and first parameter name
core/src/main/java/com/hmju/core/network/adapter/PauseAbleThreadPoolExecutor.kt|205 col 28| No whitespace expected between last parameter and closing parenthesis
core/src/main/java/com/hmju/core/network/adapter/PauseAbleThreadPoolExecutor.kt|205 col 28| Missing trailing comma before ")"
core/src/main/java/com/hmju/core/network/adapter/PauseAbleThreadPoolExecutor.kt|209 col 50| Missing trailing comma before ")"
core/src/main/java/com/hmju/core/network/di/RemoteModule.kt|120 col 21| A multiline expression should start on a new line
core/src/main/java/com/hmju/core/network/di/RemoteModule.kt|120 col 21| Newline expected before expression body
core/src/main/java/com/hmju/core/network/di/RemoteModule.kt|121 col 58| Missing trailing comma before ")"
core/src/main/java/com/hmju/core/network/di/RemoteModule.kt|132 col 31| Missing trailing comma before ")"
core/src/main/java/com/hmju/core/network/interceptor/HeaderInterceptor.kt|16 col 1| Class body should not start with blank line
core/src/main/java/com/hmju/core/network/interceptor/HeaderInterceptor.kt|18 col 19| A multiline expression should start on a new line
core/src/main/java/com/hmju/core/network/interceptor/TokenAuthenticator.kt|33 col 41| Missing trailing comma before ")"
core/src/main/java/com/hmju/core/network/interceptor/TokenAuthenticator.kt|44 col 17| Property name should start with a lowercase letter and use camel case
core/src/main/java/com/hmju/core/network/interceptor/TokenAuthenticator.kt|77 col 19| A multiline expression should start on a new line
core/src/main/java/com/hmju/core/network/interceptor/TokenAuthenticator.kt|121 col 9| No whitespace expected between opening parenthesis and first parameter name
core/src/main/java/com/hmju/core/network/interceptor/TokenAuthenticator.kt|121 col 28| No whitespace expected between last parameter and closing parenthesis
core/src/main/java/com/hmju/core/network/interceptor/TokenAuthenticator.kt|121 col 28| Missing trailing comma before ")"
core/src/main/java/com/hmju/core/network/interceptor/TokenAuthenticator.kt|125 col 50| Missing trailing comma before ")"
core/src/main/java/com/hmju/core/pref/PreferenceManager.kt|1 col 1| File must end with a newline (\n)
core/src/main/java/com/hmju/core/pref/PreferenceManager.kt|11 col 1| Class body should not start with blank line
core/src/main/java/com/hmju/core/pref/PreferenceManager.kt|13 col 5| Expected a blank line for this declaration
core/src/main/java/com/hmju/core/pref/PreferenceManager.kt|14 col 5| Expected a blank line for this declaration
core/src/main/java/com/hmju/core/pref/PreferenceManager.kt|15 col 5| Expected a blank line for this declaration
core/src/main/java/com/hmju/core/pref/PreferenceManager.kt|15 col 22| Newline expected after opening parenthesis
core/src/main/java/com/hmju/core/pref/PreferenceManager.kt|15 col 35| Parameter should start on a newline
core/src/main/java/com/hmju/core/pref/PreferenceManager.kt|15 col 43| Newline expected before closing parenthesis
core/src/main/java/com/hmju/core/pref/PreferenceManagerImpl.kt|1 col 1| File must end with a newline (\n)
core/src/main/java/com/hmju/core/pref/PreferenceManagerImpl.kt|14 col 28| Expected newline before annotation
core/src/main/java/com/hmju/core/pref/PreferenceManagerImpl.kt|14 col 36| Expected newline after last annotation
core/src/main/java/com/hmju/core/pref/PreferenceManagerImpl.kt|17 col 1| Class body should not start with blank line
core/src/main/java/com/hmju/core/pref/PreferenceManagerImpl.kt|34 col 31| Newline expected after opening parenthesis
core/src/main/java/com/hmju/core/pref/PreferenceManagerImpl.kt|34 col 44| Parameter should start on a newline
core/src/main/java/com/hmju/core/pref/PreferenceManagerImpl.kt|34 col 52| Newline expected before closing parenthesis
features/async_migrate/src/main/java/com/feature/async_migrate/ApiService.kt|20 col 62| Missing trailing comma before ")"
features/async_migrate/src/main/java/com/feature/async_migrate/ApiService.kt|25 col 62| Missing trailing comma before ")"
features/async_migrate/src/main/java/com/feature/async_migrate/di/NetworkModule.kt|18 col 9| No whitespace expected between opening parenthesis and first parameter name
features/async_migrate/src/main/java/com/feature/async_migrate/di/NetworkModule.kt|18 col 35| No whitespace expected between last parameter and closing parenthesis
features/async_migrate/src/main/java/com/feature/async_migrate/usecase/GetGoodsUseCaseRx.kt|20 col 9| No whitespace expected between opening parenthesis and first parameter name
features/async_migrate/src/main/java/com/feature/async_migrate/usecase/GetGoodsUseCaseRx.kt|20 col 31| No whitespace expected between last parameter and closing parenthesis
features/async_migrate/src/main/java/com/feature/async_migrate/usecase/GetGoodsUseCaseRx.kt|20 col 31| Missing trailing comma before ")"
features/base-mvvm/src/main/java/com/features/base_mvvm/ApiService.kt|18 col 54| Missing spacing after ","
features/base-mvvm/src/main/java/com/features/base_mvvm/ApiService.kt|18 col 61| Missing trailing comma before ")"
features/base-mvvm/src/main/java/com/features/base_mvvm/di/NetworkModule.kt|23 col 9| No whitespace expected between opening parenthesis and first parameter name
features/base-mvvm/src/main/java/com/features/base_mvvm/di/NetworkModule.kt|23 col 35| No whitespace expected between last parameter and closing parenthesis
features/network/src/main/java/com/features/network/NetworkFragment.kt|48 col 46| Newline expected after opening parenthesis
features/network/src/main/java/com/features/network/NetworkFragment.kt|48 col 61| Parameter should start on a newline
features/network/src/main/java/com/features/network/NetworkFragment.kt|48 col 81| Newline expected before closing parenthesis
features/network/src/main/java/com/features/network/di/NetworkModule.kt|23 col 9| No whitespace expected between opening parenthesis and first parameter name
features/network/src/main/java/com/features/network/di/NetworkModule.kt|23 col 35| No whitespace expected between last parameter and closing parenthesis
features/network_v2-bridge/build.gradle.kts|1 col 1| File must end with a newline (\n)
features/network_v2-bridge/src/main/java/com/features/network_v2_bridge/NetworkV2Bridge.kt|1 col 9| Package name must not contain underscore
features/network_v2-bridge/src/main/java/com/features/network_v2_bridge/NetworkV2Bridge.kt|7 col 29| Parameter should start on a newline
features/network_v2-bridge/src/main/java/com/features/network_v2_bridge/NetworkV2Bridge.kt|7 col 29| Newline expected after opening parenthesis
features/network_v2-bridge/src/main/java/com/features/network_v2_bridge/NetworkV2Bridge.kt|7 col 50| Parameter should start on a newline
features/network_v2-bridge/src/main/java/com/features/network_v2_bridge/NetworkV2Bridge.kt|7 col 50| Parameter should start on a newline
features/network_v2-bridge/src/main/java/com/features/network_v2_bridge/NetworkV2Bridge.kt|7 col 77| Missing newline before ")"
features/network_v2-bridge/src/main/java/com/features/network_v2_bridge/NetworkV2Bridge.kt|7 col 77| Newline expected before closing parenthesis
features/network_v2/build.gradle.kts|1 col 1| File must end with a newline (\n)
features/network_v2/src/androidTest/java/com/features/network_v2/ExampleInstrumentedTest.kt|1 col 1| File must end with a newline (\n)
features/network_v2/src/androidTest/java/com/features/network_v2/ExampleInstrumentedTest.kt|1 col 9| Package name must not contain underscore
features/network_v2/src/androidTest/java/com/features/network_v2/ExampleInstrumentedTest.kt|3 col 1| Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end
features/network_v2/src/androidTest/java/com/features/network_v2/ExampleInstrumentedTest.kt|9 col 1| Wildcard import
features/network_v2/src/main/java/com/features/network_v2/ApiService.kt|1 col 1| File must end with a newline (\n)
features/network_v2/src/main/java/com/features/network_v2/ApiService.kt|1 col 9| Package name must not contain underscore
features/network_v2/src/main/java/com/features/network_v2/ApiService.kt|59 col 43| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/ApiService.kt|64 col 43| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/ApiService.kt|69 col 43| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/ApiService.kt|71 col 1| Unexpected blank line(s) before "}"
features/network_v2/src/main/java/com/features/network_v2/NetworkV2Fragment.kt|1 col 9| Package name must not contain underscore
features/network_v2/src/main/java/com/features/network_v2/NetworkV2Fragment.kt|17 col 1| Unexpected indentation (8) (should be 4)
features/network_v2/src/main/java/com/features/network_v2/NetworkV2Fragment.kt|18 col 1| Unexpected indentation (8) (should be 4)
features/network_v2/src/main/java/com/features/network_v2/NetworkV2Fragment.kt|18 col 35| A newline was expected before '>'
features/network_v2/src/main/java/com/features/network_v2/NetworkV2Fragment.kt|18 col 35| Missing trailing comma before ">"
features/network_v2/src/main/java/com/features/network_v2/NetworkV2Fragment.kt|19 col 26| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/NetworkV2Fragment.kt|21 col 1| Class body should not start with blank line
features/network_v2/src/main/java/com/features/network_v2/NetworkV2Fragment.kt|25 col 32| Newline expected after opening parenthesis
features/network_v2/src/main/java/com/features/network_v2/NetworkV2Fragment.kt|25 col 44| Parameter should start on a newline
features/network_v2/src/main/java/com/features/network_v2/NetworkV2Fragment.kt|25 col 71| Newline expected before closing parenthesis
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|1 col 9| Package name must not contain underscore
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|30 col 33| Expected newline before annotation
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|30 col 41| Expected newline after last annotation
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|32 col 47| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|34 col 1| Class body should not start with blank line
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|82 col 27| A multiline expression should start on a new line
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|82 col 27| Missing newline after "("
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|82 col 27| Argument should be on a separate line (unless all arguments can fit a single line)
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|84 col 53| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|93 col 43| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|94 col 46| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|95 col 22| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|136 col 26| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|149 col 23| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|174 col 46| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|187 col 38| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/di/FeatureModule.kt|1 col 9| Package name must not contain underscore
features/network_v2/src/main/java/com/features/network_v2/di/NetworkModule.kt|1 col 9| Package name must not contain underscore
features/network_v2/src/main/java/com/features/network_v2/di/NetworkModule.kt|22 col 9| No whitespace expected between opening parenthesis and first parameter name
features/network_v2/src/main/java/com/features/network_v2/di/NetworkModule.kt|22 col 35| No whitespace expected between last parameter and closing parenthesis
features/network_v2/src/main/java/com/features/network_v2/impl/NetworkBridgeImpl.kt|1 col 1| File 'NetworkBridgeImpl.kt' contains a single class and possibly also extension functions for that class and should be named same after that class 'NetworkV2BridgeImpl.kt'
features/network_v2/src/main/java/com/features/network_v2/impl/NetworkBridgeImpl.kt|1 col 9| Package name must not contain underscore
features/network_v2/src/main/java/com/features/network_v2/impl/NetworkBridgeImpl.kt|5 col 1| Unused import
features/network_v2/src/main/java/com/features/network_v2/impl/NetworkBridgeImpl.kt|14 col 35| Expected newline before annotation
features/network_v2/src/main/java/com/features/network_v2/impl/NetworkBridgeImpl.kt|14 col 43| Expected newline after last annotation
features/network_v2/src/main/java/com/features/network_v2/impl/NetworkBridgeImpl.kt|15 col 38| Newline expected after opening parenthesis
features/network_v2/src/main/java/com/features/network_v2/impl/NetworkBridgeImpl.kt|15 col 59| Parameter should start on a newline
features/network_v2/src/main/java/com/features/network_v2/impl/NetworkBridgeImpl.kt|15 col 79| Newline expected before closing parenthesis
features/network_v2/src/main/java/com/features/network_v2/model/JSendEntity.kt|1 col 9| Package name must not contain underscore
features/network_v2/src/main/java/com/features/network_v2/model/JSendEntity.kt|9 col 21| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/model/JwtTokenTestEntity.kt|1 col 9| Package name must not contain underscore
features/network_v2/src/main/java/com/features/network_v2/model/JwtTokenTestEntity.kt|9 col 29| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/model/TokenBody.kt|1 col 1| File must end with a newline (\n)
features/network_v2/src/main/java/com/features/network_v2/model/TokenBody.kt|1 col 9| Package name must not contain underscore
features/network_v2/src/main/java/com/features/network_v2/model/TokenBody.kt|12 col 22| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/model/TokenEntity.kt|1 col 9| Package name must not contain underscore
features/network_v2/src/main/java/com/features/network_v2/model/TokenEntity.kt|19 col 48| Missing spacing after ","
features/network_v2/src/main/java/com/features/network_v2/model/TokenEntity.kt|20 col 36| Missing spacing after ","
features/network_v2/src/main/java/com/features/network_v2/model/TokenEntity.kt|27 col 60| Missing spacing after ","
features/network_v2/src/main/java/com/features/network_v2/model/TokenEntity.kt|27 col 68| Missing spacing after ","
features/network_v2/src/main/java/com/features/network_v2/model/TokenEntity.kt|28 col 51| Missing spacing after ","
features/network_v2/src/main/java/com/features/network_v2/model/TokenEntity.kt|35 col 26| Missing trailing comma before ")"
features/network_v2/src/test/java/com/features/network_v2/ExampleUnitTest.kt|1 col 1| File must end with a newline (\n)
features/network_v2/src/test/java/com/features/network_v2/ExampleUnitTest.kt|1 col 9| Package name must not contain underscore
features/network_v2/src/test/java/com/features/network_v2/ExampleUnitTest.kt|3 col 1| Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end
features/network_v2/src/test/java/com/features/network_v2/ExampleUnitTest.kt|5 col 1| Wildcard import
features/recyclerview/src/main/java/com/features/recyclerview/ApiService.kt|11 col 1| Unused import
features/recyclerview/src/main/java/com/features/recyclerview/ApiService.kt|25 col 62| Missing trailing comma before ")"
features/recyclerview/src/main/java/com/features/recyclerview/ApiService.kt|43 col 62| Missing trailing comma before ")"
features/recyclerview/src/main/java/com/features/recyclerview/ApiService.kt|48 col 62| Missing trailing comma before ")"
features/recyclerview/src/main/java/com/features/recyclerview/di/NetworkModule.kt|23 col 9| No whitespace expected between opening parenthesis and first parameter name
features/recyclerview/src/main/java/com/features/recyclerview/di/NetworkModule.kt|23 col 35| No whitespace expected between last parameter and closing parenthesis
test/src/androidTest/java/com/hmju/test/NetworkUnitTest.kt|33 col 22| A multiline expression should start on a new line

buildSrc/src/main/java/Dependencies.kt Show resolved Hide resolved
buildSrc/src/main/java/Dependencies.kt Show resolved Hide resolved
@@ -10,6 +10,7 @@ import io.reactivex.rxjava3.core.Single
interface LoginManager {
fun setToken(token: String)
fun getToken(): String
fun isLogin() : Boolean
fun rxIsLogin() : Single<Boolean>
fun isLogin(): Boolean
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:blank-line-before-declaration reported by reviewdog 🐶
Expected a blank line for this declaration

fun isLogin() : Boolean
fun rxIsLogin() : Single<Boolean>
fun isLogin(): Boolean
fun rxIsLogin(): Single<Boolean>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:blank-line-before-declaration reported by reviewdog 🐶
Expected a blank line for this declaration

fun rxIsLogin() : Single<Boolean>
fun isLogin(): Boolean
fun rxIsLogin(): Single<Boolean>
fun getTokenExpiredMs(): Long
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:blank-line-before-declaration reported by reviewdog 🐶
Expected a blank line for this declaration

LinkedBlockingQueue(),
CallerRunsPolicy()
) {

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:no-empty-first-line-in-class-body reported by reviewdog 🐶
Class body should not start with blank line

}
}

private val TIME_DELAY = 1000
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:property-naming reported by reviewdog 🐶
Property name should start with a lowercase letter and use camel case

private val pauseLock = ReentrantLock()
private val unPaused: Condition = pauseLock.newCondition()

override fun beforeExecute(t: Thread, r: Runnable) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected after opening parenthesis

private val pauseLock = ReentrantLock()
private val unPaused: Condition = pauseLock.newCondition()

override fun beforeExecute(t: Thread, r: Runnable) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Parameter should start on a newline

- 테스트 했던 Delay 들 줄임
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

ktlint

core/src/main/java/com/hmju/core/pref/PreferenceManagerImpl.kt|14 col 36| Expected newline after last annotation
core/src/main/java/com/hmju/core/pref/PreferenceManagerImpl.kt|17 col 1| Class body should not start with blank line
core/src/main/java/com/hmju/core/pref/PreferenceManagerImpl.kt|34 col 31| Newline expected after opening parenthesis
core/src/main/java/com/hmju/core/pref/PreferenceManagerImpl.kt|34 col 44| Parameter should start on a newline
core/src/main/java/com/hmju/core/pref/PreferenceManagerImpl.kt|34 col 52| Newline expected before closing parenthesis
features/async_migrate/src/main/java/com/feature/async_migrate/ApiService.kt|20 col 62| Missing trailing comma before ")"
features/async_migrate/src/main/java/com/feature/async_migrate/ApiService.kt|25 col 62| Missing trailing comma before ")"
features/async_migrate/src/main/java/com/feature/async_migrate/di/NetworkModule.kt|18 col 9| No whitespace expected between opening parenthesis and first parameter name
features/async_migrate/src/main/java/com/feature/async_migrate/di/NetworkModule.kt|18 col 35| No whitespace expected between last parameter and closing parenthesis
features/async_migrate/src/main/java/com/feature/async_migrate/usecase/GetGoodsUseCaseRx.kt|20 col 9| No whitespace expected between opening parenthesis and first parameter name
features/async_migrate/src/main/java/com/feature/async_migrate/usecase/GetGoodsUseCaseRx.kt|20 col 31| No whitespace expected between last parameter and closing parenthesis
features/async_migrate/src/main/java/com/feature/async_migrate/usecase/GetGoodsUseCaseRx.kt|20 col 31| Missing trailing comma before ")"
features/base-mvvm/src/main/java/com/features/base_mvvm/ApiService.kt|18 col 54| Missing spacing after ","
features/base-mvvm/src/main/java/com/features/base_mvvm/ApiService.kt|18 col 61| Missing trailing comma before ")"
features/base-mvvm/src/main/java/com/features/base_mvvm/di/NetworkModule.kt|23 col 9| No whitespace expected between opening parenthesis and first parameter name
features/base-mvvm/src/main/java/com/features/base_mvvm/di/NetworkModule.kt|23 col 35| No whitespace expected between last parameter and closing parenthesis
features/network/src/main/java/com/features/network/NetworkFragment.kt|48 col 46| Newline expected after opening parenthesis
features/network/src/main/java/com/features/network/NetworkFragment.kt|48 col 61| Parameter should start on a newline
features/network/src/main/java/com/features/network/NetworkFragment.kt|48 col 81| Newline expected before closing parenthesis
features/network/src/main/java/com/features/network/di/NetworkModule.kt|23 col 9| No whitespace expected between opening parenthesis and first parameter name
features/network/src/main/java/com/features/network/di/NetworkModule.kt|23 col 35| No whitespace expected between last parameter and closing parenthesis
features/network_v2-bridge/build.gradle.kts|1 col 1| File must end with a newline (\n)
features/network_v2-bridge/src/main/java/com/features/network_v2_bridge/NetworkV2Bridge.kt|1 col 9| Package name must not contain underscore
features/network_v2-bridge/src/main/java/com/features/network_v2_bridge/NetworkV2Bridge.kt|7 col 29| Parameter should start on a newline
features/network_v2-bridge/src/main/java/com/features/network_v2_bridge/NetworkV2Bridge.kt|7 col 29| Newline expected after opening parenthesis
features/network_v2-bridge/src/main/java/com/features/network_v2_bridge/NetworkV2Bridge.kt|7 col 50| Parameter should start on a newline
features/network_v2-bridge/src/main/java/com/features/network_v2_bridge/NetworkV2Bridge.kt|7 col 50| Parameter should start on a newline
features/network_v2-bridge/src/main/java/com/features/network_v2_bridge/NetworkV2Bridge.kt|7 col 77| Missing newline before ")"
features/network_v2-bridge/src/main/java/com/features/network_v2_bridge/NetworkV2Bridge.kt|7 col 77| Newline expected before closing parenthesis
features/network_v2/build.gradle.kts|1 col 1| File must end with a newline (\n)
features/network_v2/src/androidTest/java/com/features/network_v2/ExampleInstrumentedTest.kt|1 col 1| File must end with a newline (\n)
features/network_v2/src/androidTest/java/com/features/network_v2/ExampleInstrumentedTest.kt|1 col 9| Package name must not contain underscore
features/network_v2/src/androidTest/java/com/features/network_v2/ExampleInstrumentedTest.kt|3 col 1| Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end
features/network_v2/src/androidTest/java/com/features/network_v2/ExampleInstrumentedTest.kt|9 col 1| Wildcard import
features/network_v2/src/main/java/com/features/network_v2/ApiService.kt|1 col 1| File must end with a newline (\n)
features/network_v2/src/main/java/com/features/network_v2/ApiService.kt|1 col 9| Package name must not contain underscore
features/network_v2/src/main/java/com/features/network_v2/ApiService.kt|59 col 43| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/ApiService.kt|64 col 43| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/ApiService.kt|69 col 43| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/ApiService.kt|71 col 1| Unexpected blank line(s) before "}"
features/network_v2/src/main/java/com/features/network_v2/NetworkV2Fragment.kt|1 col 9| Package name must not contain underscore
features/network_v2/src/main/java/com/features/network_v2/NetworkV2Fragment.kt|17 col 1| Unexpected indentation (8) (should be 4)
features/network_v2/src/main/java/com/features/network_v2/NetworkV2Fragment.kt|18 col 1| Unexpected indentation (8) (should be 4)
features/network_v2/src/main/java/com/features/network_v2/NetworkV2Fragment.kt|18 col 35| A newline was expected before '>'
features/network_v2/src/main/java/com/features/network_v2/NetworkV2Fragment.kt|18 col 35| Missing trailing comma before ">"
features/network_v2/src/main/java/com/features/network_v2/NetworkV2Fragment.kt|19 col 26| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/NetworkV2Fragment.kt|21 col 1| Class body should not start with blank line
features/network_v2/src/main/java/com/features/network_v2/NetworkV2Fragment.kt|25 col 32| Newline expected after opening parenthesis
features/network_v2/src/main/java/com/features/network_v2/NetworkV2Fragment.kt|25 col 44| Parameter should start on a newline
features/network_v2/src/main/java/com/features/network_v2/NetworkV2Fragment.kt|25 col 71| Newline expected before closing parenthesis
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|1 col 9| Package name must not contain underscore
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|30 col 33| Expected newline before annotation
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|30 col 41| Expected newline after last annotation
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|32 col 47| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|34 col 1| Class body should not start with blank line
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|82 col 27| A multiline expression should start on a new line
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|82 col 27| Missing newline after "("
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|82 col 27| Argument should be on a separate line (unless all arguments can fit a single line)
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|84 col 53| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|93 col 43| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|94 col 46| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|95 col 22| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|136 col 26| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|149 col 23| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|174 col 46| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|187 col 38| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/di/FeatureModule.kt|1 col 9| Package name must not contain underscore
features/network_v2/src/main/java/com/features/network_v2/di/NetworkModule.kt|1 col 9| Package name must not contain underscore
features/network_v2/src/main/java/com/features/network_v2/di/NetworkModule.kt|22 col 9| No whitespace expected between opening parenthesis and first parameter name
features/network_v2/src/main/java/com/features/network_v2/di/NetworkModule.kt|22 col 35| No whitespace expected between last parameter and closing parenthesis
features/network_v2/src/main/java/com/features/network_v2/impl/NetworkBridgeImpl.kt|1 col 1| File 'NetworkBridgeImpl.kt' contains a single class and possibly also extension functions for that class and should be named same after that class 'NetworkV2BridgeImpl.kt'
features/network_v2/src/main/java/com/features/network_v2/impl/NetworkBridgeImpl.kt|1 col 9| Package name must not contain underscore
features/network_v2/src/main/java/com/features/network_v2/impl/NetworkBridgeImpl.kt|5 col 1| Unused import
features/network_v2/src/main/java/com/features/network_v2/impl/NetworkBridgeImpl.kt|14 col 35| Expected newline before annotation
features/network_v2/src/main/java/com/features/network_v2/impl/NetworkBridgeImpl.kt|14 col 43| Expected newline after last annotation
features/network_v2/src/main/java/com/features/network_v2/impl/NetworkBridgeImpl.kt|15 col 38| Newline expected after opening parenthesis
features/network_v2/src/main/java/com/features/network_v2/impl/NetworkBridgeImpl.kt|15 col 59| Parameter should start on a newline
features/network_v2/src/main/java/com/features/network_v2/impl/NetworkBridgeImpl.kt|15 col 79| Newline expected before closing parenthesis
features/network_v2/src/main/java/com/features/network_v2/model/JSendEntity.kt|1 col 9| Package name must not contain underscore
features/network_v2/src/main/java/com/features/network_v2/model/JSendEntity.kt|9 col 21| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/model/JwtTokenTestEntity.kt|1 col 9| Package name must not contain underscore
features/network_v2/src/main/java/com/features/network_v2/model/JwtTokenTestEntity.kt|9 col 29| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/model/TokenBody.kt|1 col 1| File must end with a newline (\n)
features/network_v2/src/main/java/com/features/network_v2/model/TokenBody.kt|1 col 9| Package name must not contain underscore
features/network_v2/src/main/java/com/features/network_v2/model/TokenBody.kt|12 col 22| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/model/TokenEntity.kt|1 col 9| Package name must not contain underscore
features/network_v2/src/main/java/com/features/network_v2/model/TokenEntity.kt|19 col 48| Missing spacing after ","
features/network_v2/src/main/java/com/features/network_v2/model/TokenEntity.kt|20 col 36| Missing spacing after ","
features/network_v2/src/main/java/com/features/network_v2/model/TokenEntity.kt|27 col 60| Missing spacing after ","
features/network_v2/src/main/java/com/features/network_v2/model/TokenEntity.kt|27 col 68| Missing spacing after ","
features/network_v2/src/main/java/com/features/network_v2/model/TokenEntity.kt|28 col 51| Missing spacing after ","
features/network_v2/src/main/java/com/features/network_v2/model/TokenEntity.kt|35 col 26| Missing trailing comma before ")"
features/network_v2/src/test/java/com/features/network_v2/ExampleUnitTest.kt|1 col 1| File must end with a newline (\n)
features/network_v2/src/test/java/com/features/network_v2/ExampleUnitTest.kt|1 col 9| Package name must not contain underscore
features/network_v2/src/test/java/com/features/network_v2/ExampleUnitTest.kt|3 col 1| Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end
features/network_v2/src/test/java/com/features/network_v2/ExampleUnitTest.kt|5 col 1| Wildcard import
features/recyclerview/src/main/java/com/features/recyclerview/ApiService.kt|11 col 1| Unused import
features/recyclerview/src/main/java/com/features/recyclerview/ApiService.kt|25 col 62| Missing trailing comma before ")"
features/recyclerview/src/main/java/com/features/recyclerview/ApiService.kt|43 col 62| Missing trailing comma before ")"
features/recyclerview/src/main/java/com/features/recyclerview/ApiService.kt|48 col 62| Missing trailing comma before ")"
features/recyclerview/src/main/java/com/features/recyclerview/di/NetworkModule.kt|23 col 9| No whitespace expected between opening parenthesis and first parameter name
features/recyclerview/src/main/java/com/features/recyclerview/di/NetworkModule.kt|23 col 35| No whitespace expected between last parameter and closing parenthesis
test/src/androidTest/java/com/hmju/test/NetworkUnitTest.kt|33 col 22| A multiline expression should start on a new line

}
}

private val TIME_DELAY = 0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:property-naming reported by reviewdog 🐶
Property name should start with a lowercase letter and use camel case

pauseLock.unlock()
}
// 기존 로직 참고용
/* pauseLock.lock()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:no-consecutive-comments reported by reviewdog 🐶
a block comment may not be preceded by an EOL comment unless separated by a blank line

reqBody.put("email", "j.sieun@gmail.com")
reqBody.put("delay", TIME_DELAY)
reqBody.put("expiredTime", "1m")
val req = Request.Builder()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line

* 재시도 N 번 처리하는 함수
*/
private fun <T : Any> applyRetryPolicy(
maxRetries: Int = 3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
No whitespace expected between opening parenthesis and first parameter name

* 재시도 N 번 처리하는 함수
*/
private fun <T : Any> applyRetryPolicy(
maxRetries: Int = 3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
No whitespace expected between last parameter and closing parenthesis

fun getPref(): SharedPreferences
fun getString(key: String): String
fun getLong(key: String): Long
fun <T> setValue(key: String, value: T)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected after opening parenthesis

fun getPref(): SharedPreferences
fun getString(key: String): String
fun getLong(key: String): Long
fun <T> setValue(key: String, value: T)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Parameter should start on a newline

fun getPref(): SharedPreferences
fun getString(key: String): String
fun getLong(key: String): Long
fun <T> setValue(key: String, value: T)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected before closing parenthesis

@@ -0,0 +1,46 @@
package com.hmju.core.pref
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:final-newline reported by reviewdog 🐶
File must end with a newline (\n)

*
* Created by juhongmin on 11/24/23
*/
class PreferenceManagerImpl @Inject constructor(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:annotation reported by reviewdog 🐶
Expected newline before annotation

- okhttp 구조 다이어그램 이미지 추가
- projectGraph 이미지 구조 변경
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

ktlint

features/network_v2/src/androidTest/java/com/features/network_v2/ExampleInstrumentedTest.kt|1 col 1| File must end with a newline (\n)
features/network_v2/src/androidTest/java/com/features/network_v2/ExampleInstrumentedTest.kt|1 col 9| Package name must not contain underscore
features/network_v2/src/androidTest/java/com/features/network_v2/ExampleInstrumentedTest.kt|3 col 1| Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end
features/network_v2/src/androidTest/java/com/features/network_v2/ExampleInstrumentedTest.kt|9 col 1| Wildcard import
features/network_v2/src/main/java/com/features/network_v2/ApiService.kt|1 col 1| File must end with a newline (\n)
features/network_v2/src/main/java/com/features/network_v2/ApiService.kt|1 col 9| Package name must not contain underscore
features/network_v2/src/main/java/com/features/network_v2/ApiService.kt|59 col 43| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/ApiService.kt|64 col 43| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/ApiService.kt|69 col 43| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/ApiService.kt|71 col 1| Unexpected blank line(s) before "}"
features/network_v2/src/main/java/com/features/network_v2/NetworkV2Fragment.kt|1 col 9| Package name must not contain underscore
features/network_v2/src/main/java/com/features/network_v2/NetworkV2Fragment.kt|17 col 1| Unexpected indentation (8) (should be 4)
features/network_v2/src/main/java/com/features/network_v2/NetworkV2Fragment.kt|18 col 1| Unexpected indentation (8) (should be 4)
features/network_v2/src/main/java/com/features/network_v2/NetworkV2Fragment.kt|18 col 35| A newline was expected before '>'
features/network_v2/src/main/java/com/features/network_v2/NetworkV2Fragment.kt|18 col 35| Missing trailing comma before ">"
features/network_v2/src/main/java/com/features/network_v2/NetworkV2Fragment.kt|19 col 26| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/NetworkV2Fragment.kt|21 col 1| Class body should not start with blank line
features/network_v2/src/main/java/com/features/network_v2/NetworkV2Fragment.kt|25 col 32| Newline expected after opening parenthesis
features/network_v2/src/main/java/com/features/network_v2/NetworkV2Fragment.kt|25 col 44| Parameter should start on a newline
features/network_v2/src/main/java/com/features/network_v2/NetworkV2Fragment.kt|25 col 71| Newline expected before closing parenthesis
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|1 col 9| Package name must not contain underscore
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|30 col 33| Expected newline before annotation
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|30 col 41| Expected newline after last annotation
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|32 col 47| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|34 col 1| Class body should not start with blank line
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|82 col 27| A multiline expression should start on a new line
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|82 col 27| Missing newline after "("
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|82 col 27| Argument should be on a separate line (unless all arguments can fit a single line)
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|84 col 53| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|93 col 43| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|94 col 46| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|95 col 22| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|136 col 26| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|149 col 23| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|174 col 46| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|187 col 38| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/di/FeatureModule.kt|1 col 9| Package name must not contain underscore
features/network_v2/src/main/java/com/features/network_v2/di/NetworkModule.kt|1 col 9| Package name must not contain underscore
features/network_v2/src/main/java/com/features/network_v2/di/NetworkModule.kt|22 col 9| No whitespace expected between opening parenthesis and first parameter name
features/network_v2/src/main/java/com/features/network_v2/di/NetworkModule.kt|22 col 35| No whitespace expected between last parameter and closing parenthesis
features/network_v2/src/main/java/com/features/network_v2/impl/NetworkBridgeImpl.kt|1 col 1| File 'NetworkBridgeImpl.kt' contains a single class and possibly also extension functions for that class and should be named same after that class 'NetworkV2BridgeImpl.kt'
features/network_v2/src/main/java/com/features/network_v2/impl/NetworkBridgeImpl.kt|1 col 9| Package name must not contain underscore
features/network_v2/src/main/java/com/features/network_v2/impl/NetworkBridgeImpl.kt|5 col 1| Unused import
features/network_v2/src/main/java/com/features/network_v2/impl/NetworkBridgeImpl.kt|14 col 35| Expected newline before annotation
features/network_v2/src/main/java/com/features/network_v2/impl/NetworkBridgeImpl.kt|14 col 43| Expected newline after last annotation
features/network_v2/src/main/java/com/features/network_v2/impl/NetworkBridgeImpl.kt|15 col 38| Newline expected after opening parenthesis
features/network_v2/src/main/java/com/features/network_v2/impl/NetworkBridgeImpl.kt|15 col 59| Parameter should start on a newline
features/network_v2/src/main/java/com/features/network_v2/impl/NetworkBridgeImpl.kt|15 col 79| Newline expected before closing parenthesis
features/network_v2/src/main/java/com/features/network_v2/model/JSendEntity.kt|1 col 9| Package name must not contain underscore
features/network_v2/src/main/java/com/features/network_v2/model/JSendEntity.kt|9 col 21| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/model/JwtTokenTestEntity.kt|1 col 9| Package name must not contain underscore
features/network_v2/src/main/java/com/features/network_v2/model/JwtTokenTestEntity.kt|9 col 29| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/model/TokenBody.kt|1 col 1| File must end with a newline (\n)
features/network_v2/src/main/java/com/features/network_v2/model/TokenBody.kt|1 col 9| Package name must not contain underscore
features/network_v2/src/main/java/com/features/network_v2/model/TokenBody.kt|12 col 22| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/model/TokenEntity.kt|1 col 9| Package name must not contain underscore
features/network_v2/src/main/java/com/features/network_v2/model/TokenEntity.kt|19 col 48| Missing spacing after ","
features/network_v2/src/main/java/com/features/network_v2/model/TokenEntity.kt|20 col 36| Missing spacing after ","
features/network_v2/src/main/java/com/features/network_v2/model/TokenEntity.kt|27 col 60| Missing spacing after ","
features/network_v2/src/main/java/com/features/network_v2/model/TokenEntity.kt|27 col 68| Missing spacing after ","
features/network_v2/src/main/java/com/features/network_v2/model/TokenEntity.kt|28 col 51| Missing spacing after ","
features/network_v2/src/main/java/com/features/network_v2/model/TokenEntity.kt|35 col 26| Missing trailing comma before ")"
features/network_v2/src/test/java/com/features/network_v2/ExampleUnitTest.kt|1 col 1| File must end with a newline (\n)
features/network_v2/src/test/java/com/features/network_v2/ExampleUnitTest.kt|1 col 9| Package name must not contain underscore
features/network_v2/src/test/java/com/features/network_v2/ExampleUnitTest.kt|3 col 1| Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end
features/network_v2/src/test/java/com/features/network_v2/ExampleUnitTest.kt|5 col 1| Wildcard import
features/recyclerview/src/main/java/com/features/recyclerview/ApiService.kt|11 col 1| Unused import
features/recyclerview/src/main/java/com/features/recyclerview/ApiService.kt|25 col 62| Missing trailing comma before ")"
features/recyclerview/src/main/java/com/features/recyclerview/ApiService.kt|43 col 62| Missing trailing comma before ")"
features/recyclerview/src/main/java/com/features/recyclerview/ApiService.kt|48 col 62| Missing trailing comma before ")"
features/recyclerview/src/main/java/com/features/recyclerview/di/NetworkModule.kt|23 col 9| No whitespace expected between opening parenthesis and first parameter name
features/recyclerview/src/main/java/com/features/recyclerview/di/NetworkModule.kt|23 col 35| No whitespace expected between last parameter and closing parenthesis
test/src/androidTest/java/com/hmju/test/NetworkUnitTest.kt|33 col 22| A multiline expression should start on a new line

*
* Created by juhongmin on 11/24/23
*/
class PreferenceManagerImpl @Inject constructor(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:annotation reported by reviewdog 🐶
Expected newline after last annotation

class PreferenceManagerImpl @Inject constructor(
@ApplicationContext private val context: Context,
) : PreferenceManager {

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:no-empty-first-line-in-class-body reported by reviewdog 🐶
Class body should not start with blank line

return preferences.getLong(key, 0)
}

override fun <T> setValue(key: String, value: T) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected after opening parenthesis

return preferences.getLong(key, 0)
}

override fun <T> setValue(key: String, value: T) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Parameter should start on a newline

return preferences.getLong(key, 0)
}

override fun <T> setValue(key: String, value: T) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected before closing parenthesis

import androidx.fragment.app.FragmentManager

interface NetworkV2Bridge {
fun moveToNetworkV2Page(fm: FragmentManager, @IdRes containerViewId: Int)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:parameter-list-wrapping reported by reviewdog 🐶
Parameter should start on a newline

import androidx.fragment.app.FragmentManager

interface NetworkV2Bridge {
fun moveToNetworkV2Page(fm: FragmentManager, @IdRes containerViewId: Int)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Parameter should start on a newline

import androidx.fragment.app.FragmentManager

interface NetworkV2Bridge {
fun moveToNetworkV2Page(fm: FragmentManager, @IdRes containerViewId: Int)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:parameter-list-wrapping reported by reviewdog 🐶
Missing newline before ")"

import androidx.fragment.app.FragmentManager

interface NetworkV2Bridge {
fun moveToNetworkV2Page(fm: FragmentManager, @IdRes containerViewId: Int)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected before closing parenthesis

@@ -0,0 +1,76 @@
plugins {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:final-newline reported by reviewdog 🐶
File must end with a newline (\n)

@sieunju sieunju merged commit abbea27 into develop Dec 3, 2023
1 check passed
@sieunju sieunju deleted the feature/refactor_network branch December 3, 2023 01:25
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

ktlint

features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|94 col 46| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|95 col 22| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|136 col 26| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|149 col 23| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|174 col 46| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/NetworkV2FragmentViewModel.kt|187 col 38| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/di/FeatureModule.kt|1 col 9| Package name must not contain underscore
features/network_v2/src/main/java/com/features/network_v2/di/NetworkModule.kt|1 col 9| Package name must not contain underscore
features/network_v2/src/main/java/com/features/network_v2/di/NetworkModule.kt|22 col 9| No whitespace expected between opening parenthesis and first parameter name
features/network_v2/src/main/java/com/features/network_v2/di/NetworkModule.kt|22 col 35| No whitespace expected between last parameter and closing parenthesis
features/network_v2/src/main/java/com/features/network_v2/impl/NetworkBridgeImpl.kt|1 col 1| File 'NetworkBridgeImpl.kt' contains a single class and possibly also extension functions for that class and should be named same after that class 'NetworkV2BridgeImpl.kt'
features/network_v2/src/main/java/com/features/network_v2/impl/NetworkBridgeImpl.kt|1 col 9| Package name must not contain underscore
features/network_v2/src/main/java/com/features/network_v2/impl/NetworkBridgeImpl.kt|5 col 1| Unused import
features/network_v2/src/main/java/com/features/network_v2/impl/NetworkBridgeImpl.kt|14 col 35| Expected newline before annotation
features/network_v2/src/main/java/com/features/network_v2/impl/NetworkBridgeImpl.kt|14 col 43| Expected newline after last annotation
features/network_v2/src/main/java/com/features/network_v2/impl/NetworkBridgeImpl.kt|15 col 38| Newline expected after opening parenthesis
features/network_v2/src/main/java/com/features/network_v2/impl/NetworkBridgeImpl.kt|15 col 59| Parameter should start on a newline
features/network_v2/src/main/java/com/features/network_v2/impl/NetworkBridgeImpl.kt|15 col 79| Newline expected before closing parenthesis
features/network_v2/src/main/java/com/features/network_v2/model/JSendEntity.kt|1 col 9| Package name must not contain underscore
features/network_v2/src/main/java/com/features/network_v2/model/JSendEntity.kt|9 col 21| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/model/JwtTokenTestEntity.kt|1 col 9| Package name must not contain underscore
features/network_v2/src/main/java/com/features/network_v2/model/JwtTokenTestEntity.kt|9 col 29| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/model/TokenBody.kt|1 col 1| File must end with a newline (\n)
features/network_v2/src/main/java/com/features/network_v2/model/TokenBody.kt|1 col 9| Package name must not contain underscore
features/network_v2/src/main/java/com/features/network_v2/model/TokenBody.kt|12 col 22| Missing trailing comma before ")"
features/network_v2/src/main/java/com/features/network_v2/model/TokenEntity.kt|1 col 9| Package name must not contain underscore
features/network_v2/src/main/java/com/features/network_v2/model/TokenEntity.kt|19 col 48| Missing spacing after ","
features/network_v2/src/main/java/com/features/network_v2/model/TokenEntity.kt|20 col 36| Missing spacing after ","
features/network_v2/src/main/java/com/features/network_v2/model/TokenEntity.kt|27 col 60| Missing spacing after ","
features/network_v2/src/main/java/com/features/network_v2/model/TokenEntity.kt|27 col 68| Missing spacing after ","
features/network_v2/src/main/java/com/features/network_v2/model/TokenEntity.kt|28 col 51| Missing spacing after ","
features/network_v2/src/main/java/com/features/network_v2/model/TokenEntity.kt|35 col 26| Missing trailing comma before ")"
features/network_v2/src/test/java/com/features/network_v2/ExampleUnitTest.kt|1 col 1| File must end with a newline (\n)
features/network_v2/src/test/java/com/features/network_v2/ExampleUnitTest.kt|1 col 9| Package name must not contain underscore
features/network_v2/src/test/java/com/features/network_v2/ExampleUnitTest.kt|3 col 1| Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end
features/network_v2/src/test/java/com/features/network_v2/ExampleUnitTest.kt|5 col 1| Wildcard import
features/recyclerview/src/main/java/com/features/recyclerview/ApiService.kt|11 col 1| Unused import
features/recyclerview/src/main/java/com/features/recyclerview/ApiService.kt|25 col 62| Missing trailing comma before ")"
features/recyclerview/src/main/java/com/features/recyclerview/ApiService.kt|43 col 62| Missing trailing comma before ")"
features/recyclerview/src/main/java/com/features/recyclerview/ApiService.kt|48 col 62| Missing trailing comma before ")"
features/recyclerview/src/main/java/com/features/recyclerview/di/NetworkModule.kt|23 col 9| No whitespace expected between opening parenthesis and first parameter name
features/recyclerview/src/main/java/com/features/recyclerview/di/NetworkModule.kt|23 col 35| No whitespace expected between last parameter and closing parenthesis
test/src/androidTest/java/com/hmju/test/NetworkUnitTest.kt|33 col 22| A multiline expression should start on a new line

@@ -0,0 +1,24 @@
package com.features.network_v2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:final-newline reported by reviewdog 🐶
File must end with a newline (\n)

@@ -0,0 +1,24 @@
package com.features.network_v2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:package-name reported by reviewdog 🐶
Package name must not contain underscore

@@ -0,0 +1,24 @@
package com.features.network_v2

import androidx.test.platform.app.InstrumentationRegistry
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:import-ordering reported by reviewdog 🐶
Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end

import org.junit.Test
import org.junit.runner.RunWith

import org.junit.Assert.*
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:no-wildcard-imports reported by reviewdog 🐶
Wildcard import

@@ -0,0 +1,72 @@
package com.features.network_v2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:final-newline reported by reviewdog 🐶
File must end with a newline (\n)

for (idx in 0 until 30) {
val ranInt = Random.nextInt(10)
if (ranInt < 3) {
works.add(apiService.fetchError404Rx()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line

for (idx in 0 until 30) {
val ranInt = Random.nextInt(10)
if (ranInt < 3) {
works.add(apiService.fetchError404Rx()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:wrapping reported by reviewdog 🐶
Missing newline after "("

for (idx in 0 until 30) {
val ranInt = Random.nextInt(10)
if (ranInt < 3) {
works.add(apiService.fetchError404Rx()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:argument-list-wrapping reported by reviewdog 🐶
Argument should be on a separate line (unless all arguments can fit a single line)

if (ranInt < 3) {
works.add(apiService.fetchError404Rx()
.map { it.payload }
.onErrorReturn { JSendEntity() }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:trailing-comma-on-call-site reported by reviewdog 🐶
Missing trailing comma before ")"

apiService.fetchGoodsRx(
GoodsParameter(
pageNo = Random.nextInt(5).plus(1),
pageSize = 100
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:trailing-comma-on-call-site reported by reviewdog 🐶
Missing trailing comma before ")"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 기능 추가 & 공부한내용 refactor 리펙토링
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant