Refactor/base arch #43
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
ktlint
core/src/main/java/com/hmju/core/ui/base/BaseViewModel.kt|57 col 71| Newline expected before closing parenthesis
core/src/main/java/com/hmju/core/ui/base/BottomSheetViewModel.kt|18 col 32| Expected newline before annotation
core/src/main/java/com/hmju/core/ui/base/BottomSheetViewModel.kt|18 col 40| Expected newline after last annotation
core/src/main/java/com/hmju/core/ui/base/FragmentViewModel.kt|31 col 29| Missing spacing before "{"
core/src/main/java/com/hmju/core/ui/base/FragmentViewModel.kt|31 col 29| Expected a single white space before start of function body
core/src/main/java/com/hmju/core/ui/base/FragmentViewModel.kt|31 col 29| Expected a single space before body block
features/base-mvvm/src/main/java/com/features/base_mvvm/ui/mvvm_lifecycle/LifecycleViewModel.kt|48 col 40| Missing spacing after ","
features/base-mvvm/src/main/java/com/features/base_mvvm/ui/mvvm_lifecycle/LifecycleViewModel.kt|55 col 43| Missing spacing after ","
features/base-mvvm/src/main/java/com/features/base_mvvm/ui/mvvm_lifecycle/MvvmLifecycleTest3ViewModel.kt|48 col 1| Needless blank line(s)
features/base-mvvm/src/main/java/com/features/base_mvvm/ui/mvvm_lifecycle/MvvmLifecycleTestViewModel.kt|128 col 1| Needless blank line(s)
| import androidx.test.ext.junit.runners.AndroidJUnit4 | ||
|
|
||
| import androidx.test.runner.AndroidJUnit4 | ||
| import org.junit.Assert.* |
There was a problem hiding this comment.
🚫 [ktlint] standard:no-wildcard-imports reported by reviewdog 🐶
Wildcard import
| import android.os.Parcelable | ||
| import androidx.annotation.AnimRes | ||
| import androidx.fragment.app.FragmentActivity | ||
| import io.reactivex.rxjava3.core.Observable |
There was a problem hiding this comment.
🚫 [ktlint] standard:no-unused-imports reported by reviewdog 🐶
Unused import
| import androidx.annotation.AnimRes | ||
| import androidx.fragment.app.FragmentActivity | ||
| import io.reactivex.rxjava3.core.Observable | ||
| import io.reactivex.rxjava3.subjects.PublishSubject |
There was a problem hiding this comment.
🚫 [ktlint] standard:no-unused-imports reported by reviewdog 🐶
Unused import
| val flags: Int = -1, | ||
| val data: Bundle = Bundle(), | ||
| @AnimRes val enterAni: Int = -1, | ||
| @AnimRes val exitAni: Int = -1 |
There was a problem hiding this comment.
🚫 [ktlint] standard:trailing-comma-on-declaration-site reported by reviewdog 🐶
Missing trailing comma before ")"
| ) { | ||
| @Suppress("unused") | ||
| class Builder( | ||
| val targetActivity: KClass<out FragmentActivity> |
There was a problem hiding this comment.
🚫 [ktlint] standard:trailing-comma-on-declaration-site reported by reviewdog 🐶
Missing trailing comma before ")"
| ActivityOptionsCompat.makeCustomAnimation( | ||
| requireContext(), | ||
| result.enterAni, | ||
| result.exitAni |
There was a problem hiding this comment.
🚫 [ktlint] standard:trailing-comma-on-call-site reported by reviewdog 🐶
Missing trailing comma before ")"
| @@ -5,6 +5,7 @@ import androidx.annotation.CallSuper | |||
| import androidx.lifecycle.Lifecycle | |||
| import androidx.lifecycle.ViewModel | |||
| import com.hmju.core.ui.lifecycle.OnActivityResult | |||
| import com.hmju.core.ui.lifecycle.OnFragmentResult | |||
There was a problem hiding this comment.
🚫 [ktlint] standard:no-unused-imports reported by reviewdog 🐶
Unused import
| * @param data 전달 받을 데이터 | ||
| */ | ||
| fun performActivityResult(reqCode: Int, resCode: Int, data: Bundle?): Disposable { | ||
| fun handleActivityResult(reqCode: Int, resCode: Int, data: Bundle?): Disposable { |
There was a problem hiding this comment.
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected after opening parenthesis
| * @param data 전달 받을 데이터 | ||
| */ | ||
| fun performActivityResult(reqCode: Int, resCode: Int, data: Bundle?): Disposable { | ||
| fun handleActivityResult(reqCode: Int, resCode: Int, data: Bundle?): Disposable { |
There was a problem hiding this comment.
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Parameter should start on a newline
| * @param data 전달 받을 데이터 | ||
| */ | ||
| fun performActivityResult(reqCode: Int, resCode: Int, data: Bundle?): Disposable { | ||
| fun handleActivityResult(reqCode: Int, resCode: Int, data: Bundle?): Disposable { |
There was a problem hiding this comment.
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Parameter should start on a newline
Name
추가 내용