Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

라이브러리 버전 업데이트 #49

Merged
merged 3 commits into from
Apr 3, 2024
Merged

Conversation

sieunju
Copy link
Owner

@sieunju sieunju commented Apr 3, 2024

추가 내용

  • 라이브러리 버전 업데이트
  • kotlin 1.8.10 -> 1.8.22
  • okhttp 4.9.1 -> 4.12.0
  • glide 4.11.0 -> 4.16.0

@sieunju sieunju self-assigned this Apr 3, 2024
@sieunju sieunju changed the base branch from develop to preview April 3, 2024 10:58
@sieunju sieunju merged commit e3575e7 into preview Apr 3, 2024
1 check failed
@@ -26,7 +26,7 @@ object AndroidX {
}

object Kotlin {
const val reflect = "org.jetbrains.kotlin:kotlin-reflect:1.8.10"
const val reflect = "org.jetbrains.kotlin:kotlin-reflect:1.8.22"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:property-naming reported by reviewdog 🐶
Property name should use the screaming snake case notation when the value can not be changed

@@ -53,14 +53,15 @@ object Retrofit {
const val base = "com.squareup.retrofit2:retrofit:2.9.0"
const val rxjava = "com.squareup.retrofit2:adapter-rxjava3:2.9.0"
const val kotlinx = "com.jakewharton.retrofit:retrofit2-kotlinx-serialization-converter:0.8.0"
const val okhttp = "com.squareup.okhttp3:okhttp:4.9.1"
const val okhttpLogger = "com.squareup.okhttp3:logging-interceptor:4.9.1"
const val okhttp = "com.squareup.okhttp3:okhttp:4.12.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:property-naming reported by reviewdog 🐶
Property name should use the screaming snake case notation when the value can not be changed

const val okhttp = "com.squareup.okhttp3:okhttp:4.9.1"
const val okhttpLogger = "com.squareup.okhttp3:logging-interceptor:4.9.1"
const val okhttp = "com.squareup.okhttp3:okhttp:4.12.0"
const val okhttpLogger = "com.squareup.okhttp3:logging-interceptor:4.12.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:property-naming reported by reviewdog 🐶
Property name should use the screaming snake case notation when the value can not be changed

const val base = "com.github.bumptech.glide:glide:4.11.0"
const val okhttp = "com.github.bumptech.glide:okhttp3-integration:4.11.0"
const val compiler = "com.github.bumptech.glide:compiler:4.11.0"
const val base = "com.github.bumptech.glide:glide:4.16.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:property-naming reported by reviewdog 🐶
Property name should use the screaming snake case notation when the value can not be changed

const val okhttp = "com.github.bumptech.glide:okhttp3-integration:4.11.0"
const val compiler = "com.github.bumptech.glide:compiler:4.11.0"
const val base = "com.github.bumptech.glide:glide:4.16.0"
const val okhttp = "com.github.bumptech.glide:okhttp3-integration:4.16.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:property-naming reported by reviewdog 🐶
Property name should use the screaming snake case notation when the value can not be changed

"time": "2024-04-02T12:14:52.395Z"
}
""".trimIndent()
val gson = GsonBuilder()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line


@OptIn(ExperimentalSerializationApi::class)
private fun getKotlinxTime(): Long {
val str = """
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line


@OptIn(ExperimentalSerializationApi::class)
private fun getKotlinxTime(): Long {
val str = """
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:string-template-indent reported by reviewdog 🐶
Expected newline before multiline string template

{
"time": "2024-04-02T12:14:52.395Z"
}
""".trimIndent()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:string-template-indent reported by reviewdog 🐶
Unexpected indent of raw string literal

"time": "2024-04-02T12:14:52.395Z"
}
""".trimIndent()
val json = Json {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line

@sieunju sieunju deleted the refactor/lib_update branch April 3, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant