Features/compose permissions #51
Conversation
- 좀 정리된 상태로 처리할 예정
- PermissionProvider 추가
- PermissionProvider 추가
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
ktlint
features/compose_permissions_result/src/main/java/com/hmju/compose_permissions_result/ComposePermissionsResultActivity.kt|3 col 1| Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end
features/compose_permissions_result/src/main/java/com/hmju/compose_permissions_result/di/FeatureModule.kt|1 col 9| Package name must not contain underscore
features/compose_permissions_result/src/main/java/com/hmju/compose_permissions_result/di/FeatureModule.kt|22 col 45| Missing trailing comma before ")"
features/compose_permissions_result/src/main/java/com/hmju/compose_permissions_result/impl/ComposePermissionsResultBridgeImpl.kt|1 col 9| Package name must not contain underscore
features/compose_permissions_result/src/main/java/com/hmju/compose_permissions_result/impl/ComposePermissionsResultBridgeImpl.kt|14 col 33| Missing trailing comma before ")"
features/compose_permissions_result/src/main/java/com/hmju/compose_permissions_result/screen/PermissionScreen.kt|1 col 9| Package name must not contain underscore
features/compose_permissions_result/src/main/java/com/hmju/compose_permissions_result/screen/PermissionScreen.kt|37 col 1| an EOL comment may not be preceded by a KDoc. Reversed order is allowed though when separated by a newline.
features/compose_permissions_result/src/main/java/com/hmju/compose_permissions_result/screen/PermissionScreen.kt|39 col 5| Function name should start with a lowercase letter (except factory methods) and use camel case
features/compose_permissions_result/src/main/java/com/hmju/compose_permissions_result/screen/PermissionScreen.kt|40 col 5| No whitespace expected between opening parenthesis and first parameter name
features/compose_permissions_result/src/main/java/com/hmju/compose_permissions_result/screen/PermissionScreen.kt|40 col 74| No whitespace expected between last parameter and closing parenthesis
features/compose_permissions_result/src/main/java/com/hmju/compose_permissions_result/screen/PermissionScreen.kt|40 col 74| Missing trailing comma before ")"
features/compose_permissions_result/src/main/java/com/hmju/compose_permissions_result/screen/PermissionScreen.kt|44 col 20| A multiline expression should start on a new line
features/compose_permissions_result/src/main/java/com/hmju/compose_permissions_result/screen/PermissionScreen.kt|45 col 61| Missing trailing comma before ")"
features/compose_permissions_result/src/main/java/com/hmju/compose_permissions_result/screen/PermissionScreen.kt|57 col 57| Missing trailing comma before ")"
features/compose_permissions_result/src/main/java/com/hmju/compose_permissions_result/screen/PermissionScreen.kt|60 col 51| Missing trailing comma before ")"
features/compose_permissions_result/src/main/java/com/hmju/compose_permissions_result/screen/PermissionScreen.kt|63 col 32| A multiline expression should start on a new line
features/compose_permissions_result/src/main/java/com/hmju/compose_permissions_result/screen/PermissionScreen.kt|67 col 56| Missing trailing comma before ")"
features/compose_permissions_result/src/main/java/com/hmju/compose_permissions_result/screen/PermissionScreen.kt|73 col 53| Missing trailing comma before ")"
features/compose_permissions_result/src/main/java/com/hmju/compose_permissions_result/screen/PermissionScreen.kt|78 col 32| A multiline expression should start on a new line
features/compose_permissions_result/src/main/java/com/hmju/compose_permissions_result/screen/PermissionScreen.kt|81 col 61| Missing trailing comma before ")"
features/compose_permissions_result/src/main/java/com/hmju/compose_permissions_result/screen/PermissionScreen.kt|84 col 36| A multiline expression should start on a new line
features/compose_permissions_result/src/main/java/com/hmju/compose_permissions_result/screen/PermissionScreen.kt|88 col 60| Missing trailing comma before ")"
features/compose_permissions_result/src/main/java/com/hmju/compose_permissions_result/screen/PermissionScreen.kt|91 col 35| A multiline expression should start on a new line
features/compose_permissions_result/src/main/java/com/hmju/compose_permissions_result/screen/PermissionScreen.kt|105 col 40| A multiline expression should start on a new line
features/compose_permissions_result/src/main/java/com/hmju/compose_permissions_result/screen/PermissionScreen.kt|107 col 70| Missing trailing comma before ")"
features/compose_permissions_result/src/main/java/com/hmju/compose_permissions_result/screen/PermissionScreen.kt|117 col 1| File must end with a newline (\n)
features/compose_permissions_result/src/main/java/com/hmju/compose_permissions_result/screen/PermissionViewModel.kt|1 col 9| Package name must not contain underscore
features/compose_permissions_result/src/main/java/com/hmju/compose_permissions_result/screen/PermissionViewModel.kt|15 col 26| Expected newline before annotation
features/compose_permissions_result/src/main/java/com/hmju/compose_permissions_result/screen/PermissionViewModel.kt|15 col 34| Expected newline after last annotation
features/compose_permissions_result/src/main/java/com/hmju/compose_permissions_result/screen/PermissionViewModel.kt|16 col 45| Missing trailing comma before ")"
features/compose_permissions_result/src/main/java/com/hmju/compose_permissions_result/screen/PermissionViewModel.kt|30 col 28| Unexpected whitespace
features/compose_permissions_result/src/main/java/com/hmju/compose_permissions_result/screen/PermissionViewModel.kt|30 col 29| Unexpected spacing before ":"
features/compose_permissions_result/src/main/java/com/hmju/compose_permissions_result/screen/PermissionViewModel.kt|34 col 39| Missing trailing comma before ")"
features/compose_permissions_result/src/test/java/com/hmju/compose_permissions_result/ExampleUnitTest.kt|1 col 9| Package name must not contain underscore
features/compose_permissions_result/src/test/java/com/hmju/compose_permissions_result/ExampleUnitTest.kt|3 col 1| Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end
features/compose_permissions_result/src/test/java/com/hmju/compose_permissions_result/ExampleUnitTest.kt|5 col 1| Wildcard import
features/compose_permissions_result/src/test/java/com/hmju/compose_permissions_result/ExampleUnitTest.kt|17 col 1| File must end with a newline (\n)
features/compose_permissions_result_bridge/build.gradle.kts|15 col 1| File must end with a newline (\n)
features/compose_permissions_result_bridge/src/main/java/com/hmju/compose_permissions_result_bridge/ComposePermissionsResultBridge.kt|1 col 9| Package name must not contain underscore
features/main/src/main/java/com/features/main/MainViewModel.kt|25 col 79| Missing trailing comma before ")"
| @@ -36,6 +36,7 @@ object Javax { | |||
| object Hilt { | |||
| const val android = "com.google.dagger:hilt-android:${Versions.hilt}" | |||
| const val compiler = "com.google.dagger:hilt-compiler:${Versions.hilt}" | |||
| const val compose = "androidx.hilt:hilt-navigation-compose:1.0.0" | |||
There was a problem hiding this comment.
🚫 [ktlint] standard:property-naming reported by reviewdog 🐶
Property name should use the screaming snake case notation when the value can not be changed
| @@ -89,6 +89,7 @@ object Compose { | |||
| const val tracing = "androidx.compose.runtime:runtime-tracing:1.0.0-beta01" | |||
| const val viewModel = "androidx.lifecycle:lifecycle-viewmodel-compose:2.5.1" | |||
| const val constraint = "androidx.constraintlayout:constraintlayout-compose:1.0.1" | |||
| const val runtime = "androidx.compose.runtime:runtime" | |||
There was a problem hiding this comment.
🚫 [ktlint] standard:property-naming reported by reviewdog 🐶
Property name should use the screaming snake case notation when the value can not be changed
| UN_KNOWN, | ||
| ON_CREATE, | ||
| ON_RESUME, | ||
| ON_STOP; |
There was a problem hiding this comment.
🚫 [ktlint] standard:trailing-comma-on-declaration-site reported by reviewdog 🐶
Missing trailing comma before ";"
| import androidx.lifecycle.LifecycleOwner | ||
| import com.hmju.core.compose.ComposeLifecycleState.Companion.from | ||
|
|
||
|
|
There was a problem hiding this comment.
🚫 [ktlint] standard:no-consecutive-blank-lines reported by reviewdog 🐶
Needless blank line(s)
| */ | ||
| @Composable | ||
| fun rememberLifecycleUpdatedState( | ||
| lifecycleOwner: LifecycleOwner |
There was a problem hiding this comment.
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
No whitespace expected between opening parenthesis and first parameter name
| @@ -0,0 +1,24 @@ | |||
| package com.hmju.compose_permissions_result | |||
There was a problem hiding this comment.
🚫 [ktlint] standard:package-name reported by reviewdog 🐶
Package name must not contain underscore
| @@ -0,0 +1,24 @@ | |||
| package com.hmju.compose_permissions_result | |||
|
|
|||
| import androidx.test.platform.app.InstrumentationRegistry | |||
There was a problem hiding this comment.
🚫 [ktlint] standard:import-ordering reported by reviewdog 🐶
Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end
| import org.junit.Test | ||
| import org.junit.runner.RunWith | ||
|
|
||
| import org.junit.Assert.* |
There was a problem hiding this comment.
🚫 [ktlint] standard:no-wildcard-imports reported by reviewdog 🐶
Wildcard import
| val appContext = InstrumentationRegistry.getInstrumentation().targetContext | ||
| assertEquals("com.hmju.compose_permissions_result.test", appContext.packageName) | ||
| } | ||
| } |
There was a problem hiding this comment.
🚫 [ktlint] standard:final-newline reported by reviewdog 🐶
File must end with a newline (\n)
| @@ -0,0 +1,15 @@ | |||
| package com.hmju.compose_permissions_result | |||
There was a problem hiding this comment.
🚫 [ktlint] standard:package-name reported by reviewdog 🐶
Package name must not contain underscore
추가 내용