Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[컴포즈] NavController 활용한 컴포즈 화면 구성 #52

Merged
merged 30 commits into from
May 30, 2024

Conversation

sieunju
Copy link
Owner

@sieunju sieunju commented May 30, 2024

추가 내용

  • 컴포즈를 활용하여 화면을 구성
  • Hilt 버전 업데이트
  • 컴포즈 전용 이미지 로더 함수 추가 (Core 모듈에 추가)

sieunju and others added 30 commits April 6, 2024 18:04
- DI 등 필요한 것들 추가
- 로그인 페이지 1차 추가
- 네비게이션 초기화 로직 추가
- Two-way binding compose 함수 추가
- 공통 EditText 함수 추가 1차 반영
- 공통 EditText 함수 추가 1차 반영
- 헤더 컴포넌트 추가
- Glide Compose core 모듈에 집중하도록 처리
- Glide Compose 전용 함수 추가
@sieunju sieunju merged commit 8bbef85 into preview May 30, 2024
@sieunju sieunju deleted the refactor/compose_bridge branch May 30, 2024 01:12
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

ktlint

core/src/main/java/com/hmju/core/compose/TilComponent.kt|67 col 9| Function name should start with a lowercase letter (except factory methods) and use camel case
core/src/main/java/com/hmju/core/compose/TilComponent.kt|74 col 35| A multiline expression should start on a new line
core/src/main/java/com/hmju/core/compose/TilComponent.kt|77 col 37| A multiline expression should start on a new line
core/src/main/java/com/hmju/core/compose/TilComponent.kt|79 col 83| Missing trailing comma before ")"
core/src/main/java/com/hmju/core/compose/TilComponent.kt|85 col 24| A multiline expression should start on a new line
core/src/main/java/com/hmju/core/compose/TilComponent.kt|87 col 32| Missing trailing comma before ")"
core/src/main/java/com/hmju/core/compose/TilComponent.kt|105 col 26| A multiline expression should start on a new line
core/src/main/java/com/hmju/core/compose/TilComponent.kt|108 col 64| Missing trailing comma before ")"
core/src/main/java/com/hmju/core/compose/TilComponent.kt|109 col 18| Missing trailing comma before ")"
core/src/main/java/com/hmju/core/compose/TilComponent.kt|121 col 9| Function name should start with a lowercase letter (except factory methods) and use camel case
core/src/main/java/com/hmju/core/compose/TilComponent.kt|126 col 24| A multiline expression should start on a new line
core/src/main/java/com/hmju/core/compose/TilComponent.kt|129 col 50| Missing trailing comma before ")"
core/src/main/java/com/hmju/core/compose/TilComponent.kt|132 col 28| A multiline expression should start on a new line
core/src/main/java/com/hmju/core/compose/TilComponent.kt|135 col 63| Missing trailing comma before ")"
core/src/main/java/com/hmju/core/compose/TilComponent.kt|138 col 32| A multiline expression should start on a new line
core/src/main/java/com/hmju/core/compose/TilComponent.kt|142 col 56| Missing trailing comma before ")"
core/src/main/java/com/hmju/core/compose/TilComponent.kt|146 col 50| Missing trailing comma before ")"
core/src/main/java/com/hmju/core/compose/TilComponent.kt|153 col 49| Missing trailing comma before ")"
core/src/main/java/com/hmju/core/compose/TilComponent.kt|162 col 54| Missing trailing comma before ")"
core/src/main/java/com/hmju/core/compose/TilComponent.kt|170 col 9| Function name should start with a lowercase letter (except factory methods) and use camel case
core/src/main/java/com/hmju/core/compose/TilComponent.kt|173 col 30| A multiline expression should start on a new line
core/src/main/java/com/hmju/core/compose/TilComponent.kt|175 col 49| Missing trailing comma before ")"
core/src/main/java/com/hmju/core/compose/TilComponent.kt|178 col 24| A multiline expression should start on a new line
core/src/main/java/com/hmju/core/compose/TilComponent.kt|180 col 60| Missing trailing comma before ")"
core/src/main/java/com/hmju/core/compose/TilComponent.kt|183 col 28| A multiline expression should start on a new line
core/src/main/java/com/hmju/core/compose/TilComponent.kt|184 col 39| Missing trailing comma before ")"
core/src/main/java/com/hmju/core/compose/TilComponent.kt|192 col 9| Function name should start with a lowercase letter (except factory methods) and use camel case
core/src/main/java/com/hmju/core/compose/TilComponent.kt|195 col 30| A multiline expression should start on a new line
core/src/main/java/com/hmju/core/compose/TilComponent.kt|199 col 52| Missing trailing comma before ")"
core/src/main/java/com/hmju/core/compose/TilComponent.kt|201 col 1| First line in a method block should not be empty
core/src/main/java/com/hmju/core/compose/TilComponent.kt|205 col 24| A multiline expression should start on a new line
core/src/main/java/com/hmju/core/compose/TilComponent.kt|207 col 60| Missing trailing comma before ")"
core/src/main/java/com/hmju/core/compose/TilComponent.kt|210 col 28| A multiline expression should start on a new line
core/src/main/java/com/hmju/core/compose/TilComponent.kt|213 col 55| Missing trailing comma before ")"
core/src/main/java/com/hmju/core/compose/TilComponent.kt|221 col 9| Function name should start with a lowercase letter (except factory methods) and use camel case
core/src/main/java/com/hmju/core/compose/TilComponent.kt|232 col 40| Missing trailing comma before ")"
core/src/main/java/com/hmju/core/glide/GlideModule.kt|25 col 31| Newline expected after opening parenthesis
core/src/main/java/com/hmju/core/glide/GlideModule.kt|25 col 49| Parameter should start on a newline
core/src/main/java/com/hmju/core/glide/GlideModule.kt|25 col 70| Newline expected before closing parenthesis
core/src/main/java/com/hmju/core/glide/GlideModule.kt|37 col 44| Missing trailing comma before ")"
core/src/main/java/com/hmju/core/network/NetworkExtensions.kt|15 col 1| Class body should not start with blank line
core/src/main/java/com/hmju/core/network/NetworkExtensions.kt|23 col 28| Missing trailing comma before ")"
core/src/main/java/com/hmju/core/network/NetworkExtensions.kt|44 col 43| Missing trailing comma before ")"
core/src/main/java/com/hmju/core/network/NetworkExtensions.kt|74 col 46| Missing trailing comma before ")"
core/src/main/java/com/hmju/core/network/NetworkExtensions.kt|103 col 1| File must end with a newline (\n)
core/src/main/java/com/hmju/core/ui/Extensions.kt|61 col 26| Missing trailing comma before ")"
core/src/main/java/com/hmju/core/ui/Extensions.kt|69 col 42| Missing trailing comma before ")"
core/src/main/java/com/hmju/core/ui/Extensions.kt|71 col 18| Missing trailing comma before ")"
core/src/main/java/com/hmju/core/ui/Extensions.kt|80 col 26| Missing trailing comma before ")"
core/src/main/java/com/hmju/core/ui/Extensions.kt|86 col 42| Missing trailing comma before ")"
core/src/main/java/com/hmju/core/ui/Extensions.kt|88 col 18| Missing trailing comma before ")"
core/src/main/java/com/hmju/core/ui/Extensions.kt|90 col 1| File must end with a newline (\n)
core/src/main/java/com/hmju/core/ui/base/BaseViewModel.kt|107 col 21| Missing trailing comma before ")"
core/src/main/java/com/hmju/core/ui/base/BaseViewModel.kt|115 col 46| Missing trailing comma before ")"
core/src/main/java/com/hmju/core/ui/base/BaseViewModel.kt|117 col 22| Missing trailing comma before ")"
core/src/main/java/com/hmju/core/ui/base/BaseViewModel.kt|121 col 1| Needless blank line(s)
features/compose-ui/src/main/java/com/features/compose_ui/ComposeUiActivity.kt|58 col 61| Missing trailing comma before ")"
features/compose-ui/src/main/java/com/features/compose_ui/ComposeUiActivity.kt|61 col 32| A multiline expression should start on a new line
features/compose-ui/src/main/java/com/features/compose_ui/ComposeUiActivity.kt|63 col 40| Missing trailing comma before ")"
features/compose-ui/src/main/java/com/features/compose_ui/ComposeUiActivity.kt|68 col 36| A multiline expression should start on a new line
features/compose-ui/src/main/java/com/features/compose_ui/ComposeUiActivity.kt|71 col 26| Missing trailing comma before ")"
features/compose-ui/src/main/java/com/features/compose_ui/ComposeUiActivity.kt|75 col 49| Missing trailing comma before ")"
features/compose-ui/src/main/java/com/features/compose_ui/ComposeUiActivity.kt|79 col 49| Missing trailing comma before ")"
features/compose-ui/src/main/java/com/features/compose_ui/ComposeUiActivity.kt|83 col 49| Missing trailing comma before ")"
features/compose-ui/src/main/java/com/features/compose_ui/ComposeUiActivity.kt|87 col 49| Missing trailing comma before ")"
features/compose-ui/src/main/java/com/features/compose_ui/ComposeUiActivity.kt|91 col 49| Missing trailing comma before ")"
features/compose-ui/src/main/java/com/features/compose_ui/models/MemoUiModel.kt|222 col 56| Missing trailing comma before ")"
features/compose-ui/src/main/java/com/features/compose_ui/models/MemoUiModel.kt|272 col 56| Missing trailing comma before ")"
features/compose_navigation/build.gradle.kts|58 col 1| File must end with a newline (\n)
features/compose_navigation/src/main/java/com/features/compose_navigation/ApiService.kt|1 col 9| Package name must not contain underscore
features/compose_navigation/src/main/java/com/features/compose_navigation/ApiService.kt|18 col 62| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/ApiService.kt|23 col 62| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/ComposeNavigationActivity.kt|1 col 9| Package name must not contain underscore
features/compose_navigation/src/main/java/com/features/compose_navigation/ComposeNavigationActivity.kt|29 col 1| Class body should not start with blank line
features/compose_navigation/src/main/java/com/features/compose_navigation/ComposeNavigationActivity.kt|35 col 32| A multiline expression should start on a new line
features/compose_navigation/src/main/java/com/features/compose_navigation/ComposeNavigationActivity.kt|38 col 49| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/ComposeNavigationActivity.kt|47 col 17| Function name should start with a lowercase letter (except factory methods) and use camel case
features/compose_navigation/src/main/java/com/features/compose_navigation/ComposeNavigationActivity.kt|48 col 9| No whitespace expected between opening parenthesis and first parameter name
features/compose_navigation/src/main/java/com/features/compose_navigation/ComposeNavigationActivity.kt|48 col 67| No whitespace expected between last parameter and closing parenthesis
features/compose_navigation/src/main/java/com/features/compose_navigation/ComposeNavigationActivity.kt|48 col 67| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/Screens.kt|1 col 9| Package name must not contain underscore
features/compose_navigation/src/main/java/com/features/compose_navigation/Screens.kt|23 col 53| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/Screens.kt|23 col 54| A comment inside or on same line after a 'value_parameter' is not allowed. It may be placed on a separate line above.
features/compose_navigation/src/main/java/com/features/compose_navigation/Screens.kt|28 col 21| A multiline expression should start on a new line
features/compose_navigation/src/main/java/com/features/compose_navigation/Screens.kt|36 col 14| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/Screens.kt|37 col 10| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/Screens.kt|41 col 21| A multiline expression should start on a new line
features/compose_navigation/src/main/java/com/features/compose_navigation/Screens.kt|44 col 14| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/Screens.kt|45 col 10| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/Screens.kt|46 col 6| Missing trailing comma before ";"
features/compose_navigation/src/main/java/com/features/compose_navigation/Screens.kt|50 col 78| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/Screens.kt|64 col 31| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/Screens.kt|76 col 31| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/Screens.kt|78 col 14| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/Screens.kt|87 col 9| No whitespace expected between opening parenthesis and first parameter name
features/compose_navigation/src/main/java/com/features/compose_navigation/Screens.kt|87 col 50| No whitespace expected between last parameter and closing parenthesis
features/compose_navigation/src/main/java/com/features/compose_navigation/Screens.kt|87 col 50| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/Screens.kt|92 col 26| A multiline expression should start on a new line
features/compose_navigation/src/main/java/com/features/compose_navigation/Screens.kt|92 col 26| Missing newline after "("
features/compose_navigation/src/main/java/com/features/compose_navigation/Screens.kt|99 col 31| Missing newline before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/di/FeatureModule.kt|1 col 9| Package name must not contain underscore
features/compose_navigation/src/main/java/com/features/compose_navigation/di/FeatureModule.kt|24 col 45| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/di/FeatureModule.kt|31 col 9| No whitespace expected between opening parenthesis and first parameter name
features/compose_navigation/src/main/java/com/features/compose_navigation/di/FeatureModule.kt|31 col 34| No whitespace expected between last parameter and closing parenthesis
features/compose_navigation/src/main/java/com/features/compose_navigation/di/FeatureModule.kt|31 col 34| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/impl/ComposeNavigationBridgeImpl.kt|1 col 9| Package name must not contain underscore
features/compose_navigation/src/main/java/com/features/compose_navigation/impl/ComposeNavigationBridgeImpl.kt|14 col 33| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/models/MemoClickEvent.kt|1 col 9| Package name must not contain underscore
features/compose_navigation/src/main/java/com/features/compose_navigation/models/MemoClickEvent.kt|9 col 1| Class body should not start with blank line
features/compose_navigation/src/main/java/com/features/compose_navigation/models/MemoClickEvent.kt|13 col 24| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/models/MemoUiModel.kt|1 col 9| Package name must not contain underscore
features/compose_navigation/src/main/java/com/features/compose_navigation/models/MemoUiModel.kt|31 col 1| Class body should not start with blank line
features/compose_navigation/src/main/java/com/features/compose_navigation/models/MemoUiModel.kt|35 col 9| Function name should start with a lowercase letter (except factory methods) and use camel case
features/compose_navigation/src/main/java/com/features/compose_navigation/models/MemoUiModel.kt|41 col 38| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/models/MemoUiModel.kt|43 col 1| Class body should not start with blank line
features/compose_navigation/src/main/java/com/features/compose_navigation/models/MemoUiModel.kt|46 col 36| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/models/MemoUiModel.kt|51 col 45| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/models/MemoUiModel.kt|61 col 28| A multiline expression should start on a new line
features/compose_navigation/src/main/java/com/features/compose_navigation/models/MemoUiModel.kt|66 col 57| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/models/MemoUiModel.kt|67 col 22| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/models/MemoUiModel.kt|70 col 32| A multiline expression should start on a new line
features/compose_navigation/src/main/java/com/features/compose_navigation/models/MemoUiModel.kt|73 col 56| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/models/MemoUiModel.kt|77 col 36| A multiline expression should start on a new line
features/compose_navigation/src/main/java/com/features/compose_navigation/models/MemoUiModel.kt|79 col 44| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/models/MemoUiModel.kt|85 col 36| A multiline expression should start on a new line
features/compose_navigation/src/main/java/com/features/compose_navigation/models/MemoUiModel.kt|87 col 75| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/models/MemoUiModel.kt|94 col 36| A multiline expression should start on a new line
features/compose_navigation/src/main/java/com/features/compose_navigation/models/MemoUiModel.kt|96 col 75| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/models/MemoUiModel.kt|111 col 28| A multiline expression should start on a new line
features/compose_navigation/src/main/java/com/features/compose_navigation/models/MemoUiModel.kt|114 col 54| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/models/entity/FileEntity.kt|1 col 9| Package name must not contain underscore
features/compose_navigation/src/main/java/com/features/compose_navigation/models/entity/FileEntity.kt|19 col 30| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/models/entity/FileEntity.kt|20 col 1| File must end with a newline (\n)
features/compose_navigation/src/main/java/com/features/compose_navigation/models/entity/MemoEntity.kt|1 col 9| Package name must not contain underscore
features/compose_navigation/src/main/java/com/features/compose_navigation/models/entity/MemoEntity.kt|22 col 34| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/login/LoginScreen.kt|1 col 9| Package name must not contain underscore
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/login/LoginScreen.kt|43 col 5| Function name should start with a lowercase letter (except factory methods) and use camel case
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/login/LoginScreen.kt|45 col 48| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/login/LoginScreen.kt|49 col 20| A multiline expression should start on a new line
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/login/LoginScreen.kt|52 col 48| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/login/LoginScreen.kt|56 col 24| A multiline expression should start on a new line
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/login/LoginScreen.kt|59 col 50| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/login/LoginScreen.kt|69 col 45| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/login/LoginScreen.kt|75 col 39| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/login/LoginScreen.kt|79 col 24| A multiline expression should start on a new line
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/login/LoginScreen.kt|88 col 22| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/login/LoginScreen.kt|91 col 33| A multiline expression should start on a new line
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/login/LoginScreen.kt|92 col 53| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/login/LoginScreen.kt|96 col 48| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/login/LoginScreen.kt|101 col 45| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/login/LoginScreen.kt|108 col 1| Unexpected blank line(s) before "}"
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/login/LoginScreen.kt|114 col 13| Function name should start with a lowercase letter (except factory methods) and use camel case
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/login/LoginScreen.kt|117 col 24| A multiline expression should start on a new line
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/login/LoginScreen.kt|120 col 41| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/login/LoginViewModel.kt|1 col 9| Package name must not contain underscore
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/login/LoginViewModel.kt|20 col 21| Expected newline before annotation
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/login/LoginViewModel.kt|20 col 29| Expected newline after last annotation
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/login/LoginViewModel.kt|21 col 51| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/login/LoginViewModel.kt|23 col 1| Class body should not start with blank line
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/login/LoginViewModel.kt|27 col 17| A multiline expression should start on a new line
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/login/SignUpScreen.kt|1 col 9| Package name must not contain underscore
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/login/SignUpScreen.kt|39 col 5| Function name should start with a lowercase letter (except factory methods) and use camel case
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/login/SignUpScreen.kt|41 col 49| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/login/SignUpScreen.kt|51 col 20| A multiline expression should start on a new line
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/login/SignUpScreen.kt|55 col 34| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/login/SignUpScreen.kt|59 col 24| A multiline expression should start on a new line
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/login/SignUpScreen.kt|62 col 50| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/login/SignUpScreen.kt|69 col 45| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/login/SignUpScreen.kt|77 col 45| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/login/SignUpScreen.kt|84 col 74| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/login/SignUpScreen.kt|88 col 24| A multiline expression should start on a new line
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/login/SignUpScreen.kt|97 col 22| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/login/SignUpScreen.kt|100 col 33| A multiline expression should start on a new line
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/login/SignUpScreen.kt|103 col 50| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/login/SignUpScreen.kt|104 col 26| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/login/SignUpScreen.kt|112 col 48| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/login/SignUpScreen.kt|117 col 97| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/login/SignUpScreen.kt|122 col 1| File must end with a newline (\n)
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/login/SignUpViewModel.kt|1 col 9| Package name must not contain underscore
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/login/SignUpViewModel.kt|19 col 22| Expected newline before annotation
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/login/SignUpViewModel.kt|19 col 30| Expected newline after last annotation
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/login/SignUpViewModel.kt|19 col 43| Unexpected whitespace
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/login/SignUpViewModel.kt|19 col 43| Unexpected spacing after "("
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/login/SignUpViewModel.kt|20 col 1| Unexpected blank line(s) in value parameter list
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/login/SignUpViewModel.kt|22 col 1| Class body should not start with blank line
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/login/SignUpViewModel.kt|27 col 17| A multiline expression should start on a new line
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/memo/MemoScreen.kt|1 col 9| Package name must not contain underscore
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/memo/MemoScreen.kt|44 col 1| Unused import
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/memo/MemoScreen.kt|54 col 5| Function name should start with a lowercase letter (except factory methods) and use camel case
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/memo/MemoScreen.kt|56 col 47| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/memo/MemoScreen.kt|69 col 34| A multiline expression should start on a new line
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/memo/MemoScreen.kt|71 col 1| Class body should not start with blank line
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/memo/MemoScreen.kt|72 col 38| Newline expected after opening parenthesis
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/memo/MemoScreen.kt|72 col 57| Parameter should start on a newline
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/memo/MemoScreen.kt|72 col 83| Newline expected before closing parenthesis
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/memo/MemoScreen.kt|81 col 43| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/memo/MemoScreen.kt|92 col 20| A multiline expression should start on a new line
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/memo/MemoScreen.kt|94 col 50| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/memo/MemoScreen.kt|97 col 24| A multiline expression should start on a new line
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/memo/MemoScreen.kt|100 col 75| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/memo/MemoScreen.kt|106 col 88| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/memo/MemoScreen.kt|111 col 24| A multiline expression should start on a new line
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/memo/MemoScreen.kt|116 col 42| A multiline expression should start on a new line
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/memo/MemoScreen.kt|127 col 29| A multiline expression should start on a new line
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/memo/MemoScreen.kt|129 col 42| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/memo/MemoScreen.kt|132 col 55| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/memo/MemoScreen.kt|136 col 28| A multiline expression should start on a new line
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/memo/MemoScreen.kt|139 col 54| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/memo/MemoScreen.kt|142 col 28| A multiline expression should start on a new line
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/memo/MemoScreen.kt|146 col 52| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/memo/MemoScreen.kt|150 col 32| A multiline expression should start on a new line
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/memo/MemoScreen.kt|153 col 49| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/memo/MemoScreen.kt|162 col 1| File must end with a newline (\n)
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/memo/MemoViewModel.kt|1 col 9| Package name must not contain underscore
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/memo/MemoViewModel.kt|34 col 20| Expected newline before annotation
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/memo/MemoViewModel.kt|34 col 28| Expected newline after last annotation
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/memo/MemoViewModel.kt|36 col 51| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/memo/MemoViewModel.kt|38 col 1| Class body should not start with blank line
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/memo/MemoViewModel.kt|43 col 17| A multiline expression should start on a new line
features/compose_navigation/src/main/java/com/features/compose_navigation/screens/memo/MemoViewModel.kt|55 col 17| A multiline expression should start on a new line
features/compose_navigation/src/main/java/com/features/compose_navigation/usecase/GetMemoUseCase.kt|1 col 9| Package name must not contain underscore
features/compose_navigation/src/main/java/com/features/compose_navigation/usecase/GetMemoUseCase.kt|5 col 1| Unused import
features/compose_navigation/src/main/java/com/features/compose_navigation/usecase/GetMemoUseCase.kt|6 col 1| Unused import
features/compose_navigation/src/main/java/com/features/compose_navigation/usecase/GetMemoUseCase.kt|18 col 21| Expected newline before annotation
features/compose_navigation/src/main/java/com/features/compose_navigation/usecase/GetMemoUseCase.kt|18 col 29| Expected newline after last annotation
features/compose_navigation/src/main/java/com/features/compose_navigation/usecase/GetMemoUseCase.kt|19 col 39| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/usecase/GetMemoUseCase.kt|26 col 67| Missing trailing comma before ")"
features/compose_navigation/src/main/java/com/features/compose_navigation/usecase/GetMemoUseCase.kt|35 col 1| File must end with a newline (\n)
features/compose_navigation_bridge/build.gradle.kts|8 col 1| File must end with a newline (\n)
features/compose_navigation_bridge/src/main/java/com/features/compose_navigation_bridge/ComposeNavigationBridge.kt|1 col 9| Package name must not contain underscore
features/main/src/main/java/com/features/main/MainViewModel.kt|27 col 65| Missing trailing comma before ")"
test/src/test/java/com/hmju/test/ExampleUnitTest.kt|83 col 24| Missing spacing before "{"
test/src/test/java/com/hmju/test/ExampleUnitTest.kt|83 col 24| Expected a single white space before start of function body
test/src/test/java/com/hmju/test/ExampleUnitTest.kt|83 col 24| Expected a single space before body block

@@ -6,7 +6,7 @@ object Apps {
object Versions {
const val retrofit = "2.9.0"
const val lifecycle = "2.6.1"
const val hilt = "2.45"
const val hilt = "2.48"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:property-naming reported by reviewdog 🐶
Property name should use the screaming snake case notation when the value can not be changed

const val base = "com.github.bumptech.glide:glide:4.16.0"
const val okhttp = "com.github.bumptech.glide:okhttp3-integration:4.16.0"
const val compiler = "com.github.bumptech.glide:ksp:4.16.0"
const val base = "com.github.bumptech.glide:glide:4.13.2"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:property-naming reported by reviewdog 🐶
Property name should use the screaming snake case notation when the value can not be changed

const val okhttp = "com.github.bumptech.glide:okhttp3-integration:4.16.0"
const val compiler = "com.github.bumptech.glide:ksp:4.16.0"
const val base = "com.github.bumptech.glide:glide:4.13.2"
const val okhttp = "com.github.bumptech.glide:okhttp3-integration:4.13.2"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:property-naming reported by reviewdog 🐶
Property name should use the screaming snake case notation when the value can not be changed

const val compiler = "com.github.bumptech.glide:ksp:4.16.0"
const val base = "com.github.bumptech.glide:glide:4.13.2"
const val okhttp = "com.github.bumptech.glide:okhttp3-integration:4.13.2"
const val compiler = "com.github.bumptech.glide:compiler:4.13.2"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:property-naming reported by reviewdog 🐶
Property name should use the screaming snake case notation when the value can not be changed

const val base = "com.github.bumptech.glide:glide:4.13.2"
const val okhttp = "com.github.bumptech.glide:okhttp3-integration:4.13.2"
const val compiler = "com.github.bumptech.glide:compiler:4.13.2"
const val annotations = "com.github.bumptech.glide:annotations:4.13.2"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:property-naming reported by reviewdog 🐶
Property name should use the screaming snake case notation when the value can not be changed

@@ -22,7 +22,8 @@ class TilColor internal constructor(
val gray3: Color,
val gray3Light: Color,
val gray4: Color,
val gray5: Color
val gray5: Color,
val defBgColor: Color

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:trailing-comma-on-declaration-site reported by reviewdog 🐶
Missing trailing comma before ")"

@@ -36,6 +37,7 @@ class TilColor internal constructor(
gray3 = Color(204, 204, 204),
gray3Light = Color(229, 229, 229),
gray4 = Color(240, 240, 240),
gray5 = Color(247, 247, 247)
gray5 = Color(247, 247, 247),
defBgColor = Color(245,243,244)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:comma-spacing reported by reviewdog 🐶
Missing spacing after ","

@@ -36,6 +37,7 @@ class TilColor internal constructor(
gray3 = Color(204, 204, 204),
gray3Light = Color(229, 229, 229),
gray4 = Color(240, 240, 240),
gray5 = Color(247, 247, 247)
gray5 = Color(247, 247, 247),
defBgColor = Color(245,243,244)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:comma-spacing reported by reviewdog 🐶
Missing spacing after ","

@@ -36,6 +37,7 @@ class TilColor internal constructor(
gray3 = Color(204, 204, 204),
gray3Light = Color(229, 229, 229),
gray4 = Color(240, 240, 240),
gray5 = Color(247, 247, 247)
gray5 = Color(247, 247, 247),
defBgColor = Color(245,243,244)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:trailing-comma-on-call-site reported by reviewdog 🐶
Missing trailing comma before ")"

* Created by juhongmin on 4/10/24
*/
object TilComponent {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:no-empty-first-line-in-class-body reported by reviewdog 🐶
Class body should not start with blank line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant