Fixes #13850 - Fixes EnterPhoneNumber Screen Loading State Issue #13898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbandonedCart
pushed a commit
to SamSprung/Signal-Android
that referenced
this pull request
Jan 31, 2025
Add proper toast message when call link in use. Reapply "Update our base themes to avoid crashing MaterialAlertDialog." This reverts commit d1f4797. Revert "Add missing required material3 dialog theme attribute." This reverts commit 36d8e75. Fix various Material3 theming issues. Update aapt2 gradle hash for windows. Fix bug with re-opting into PINs. Update translations and other static files. Update baseline profile. Bump version to 7.29.1 Revert to androidx-camera 1.3.4 Improve message validation. Fix call camera enable on rotation bug. Fix auth prompt during linked device flow. Update translations and other static files. Update baseline profile. Bump version to 7.29.2 Fix announcement group text link color. Ended up reorganizing some theme colors too, but didn't change any. Fix text highlight color. Fix calendar background color. Fix bad checkbox color in help fragment. Fix unread filter visibility. Update translations and other static files. Update baseline profile. Bump version to 7.29.3 Fix review banner background. Use recommended style for group title search. Update translations and other static files. Bump version to 7.29.4 Update to RingRTC v2.49.2 Fix dangling open cursors in AnalyzeDatabaseJob. Do not include identity message from self in backup. Update KeepMessageDuration for 1 year to 366 days. This allows you to see messages that are exactly one year old (like birthday wishes) as well as accounts for leap year. Resolves signalapp#13889 Convert tests to Kotlin, remove Hamcrest. Resolves signalapp#13884 Convert tests from Hamcrest -> AssertK. Convert StickerTable to kotlin. Dedupe packs when reading from sticker table. Fix 1:1 call unknown state validation failure. Mitigate PNI editor server bug for group member add updates. Add whoami check for receipt_credentials. Add wake lock when linking devices. Ensure that ANR traces are kept within a reasonable size range. Ensure that backup timestamps are within a certain range. Mitigate flaky network by retrying link+sync api calls. Update libsignal to 0.65.0 Enable the SSRE2 capability. Fix test compilation issues. Fix expirationTime for call links. Add ability to cancel a link+sync. Claim IAP subscription if we detect a payment token mismatch. Fix DatabaseConsistencyCheck SQL normalizer. Remove comment about checking for easy label. Resolves signalapp#13897 Prevent changing to the same phone number. Fixes signalapp#13864 Resolvse signalapp#13883 Prevent overlapping contact refreshes. Fixes signalapp#13852 Resolves signalapp#13874 Improve error handling for serialized job data. Attempt to rebuild the FTS index in DB error handler. Fix gv2 left group locally bugs in backup and compose. Prevent calls crashing due to background restrictions. Notify a user when they link a device. Validate serviceIds in pinned chats. Remove unused ToggleRow.enabled flag. Story Privacy Setting UI issues Fixes signalapp#13863 Resolves signalapp#13892 Fix cropping on large images. Add app migration for SSRE2 capability. Introduce additional logging for group call updates. Handle nonretryable errors during link + sync. Fix country picker reproducible builds bug. Add polling for devices. Exclude invalid long messages from backups. Fix incorrect registration challenge handling when requesting verification codes. Add small system for consolidating archive export errors. Fix incorrect left group in local state bug. Fix progress display hiding way before registration navigation. Fixes signalapp#13850 Closes signalapp#13898 Remove fix group left incorrectly migration job. Update libsignal to 0.65.1 Add backup support for contact nicknames and notes. Update to libsignal 0.65.2 Remove bad instrumentation test. Add backup support for DirectStoryReplyMessages. Fix do not disturb settings for calls. Fix header mode when call is reconnecting. Add date to unlinked dialog. Improve call tab performance. Update translations and other static files. Update baseline profile. Co-Authored-By: Greyson Parrelli <greyson@signal.org> Co-Authored-By: Sagar <sagar.0dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13850
First time contributor checklist
Contributor checklist
Fixes #1234syntaxDescription
The issue reports that the EnterPhoneNumberFragment Loading state is set to false before the user is navigated to another screen which can give the user a sense of unresponsiveness and the user might click on the Next button multiple times(Unnecessary calls).
The PR fixes this by setting the progress bar to false only when the user is already navigated to another screen.
The same last PR was closed because I raised it the from main branch and force-pushed after removing the commit. Please consider only this PR as valid.
Screenshots:
document_6319097752387064234.mp4