Change in app message sound label #5856
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
404Wolf
force-pushed
the
in-app-message-sound-label
branch
from
293426d
to
cd37082
Compare
404Wolf
force-pushed
the
in-app-message-sound-label
branch
from
cd37082
to
81f6cb2
Compare
|
I think this is a good change since it wasn't immediately obvious to me that the old setting would turn off both the incoming and outgoing message sound while in the app. The outgoing sound was particularly frustrating for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time contributor checklist
Contributor checklist
Description
Change the app setting text for disabling in app message sounds to be "In-Chat Message Sounds." This change addresses a bit of inconsistency with the desktop signal app, and more transparently describes the functionality of the setting.