Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add restoration stopTime #224

Merged
merged 5 commits into from
Aug 29, 2024
Merged

Add restoration stopTime #224

merged 5 commits into from
Aug 29, 2024

Conversation

pdoshisplunk
Copy link
Collaborator

@pdoshisplunk pdoshisplunk commented Aug 27, 2024

Add restoration stopTime to metric_ruleset exceptionRule

  • metric ruleset API now supports specifying restoration stopTime. This is the time to which a restoration will restore archived data, specified in epoch time in milliseconds.

@echoi-splk echoi-splk marked this pull request as draft August 27, 2024 22:00
@echoi-splk
Copy link
Collaborator

Changing to draft. It should not be merged until SB-rest tag is v4.3.424. Currently, canary is v4.3.452 [deployed], see https://mon.signalfx.com/#/dashboard/E52GV0fAsAA?groupId=E52Gc8fAsAA&configId=E52GglyAoAA&startTime=-1h&endTime=Now&density=4

metric_ruleset_test.go Outdated Show resolved Hide resolved
metric_ruleset_test.go Show resolved Hide resolved
@echoi-splk echoi-splk marked this pull request as ready for review August 29, 2024 01:16
@echoi-splk
Copy link
Collaborator

Changing to "Ready for review". SB-rest tag is v4.3.452 in prod realms, see https://mon.signalfx.com/#/dashboard/E52GV0fAsAA?groupId=E52Gc8fAsAA&configId=E52GglyAoAA&startTime=-1h&endTime=Now&density=4

@echoi-splk echoi-splk changed the title [FFM-1082] Add restoration stopTime Add restoration stopTime Aug 29, 2024
Copy link
Collaborator

@echoi-splk echoi-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pdoshisplunk pdoshisplunk merged commit 5391c37 into master Aug 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants