Skip to content

Commit

Permalink
[receiver/jmx] Add metric gatherer to artifacts (#3262)
Browse files Browse the repository at this point in the history
* [receiver/jmx] Add Docker support for JMX receiver

To properly support the jmx receiver in Docker, the dockerfile has
to download the JMX metrics gatherer, and have it available to
the collector. This change adds this functionality to the linux/macos
dockerfile, as well as the windows dockerfile.

Also, adds an integration test getting metrics from a docker container.

* Add back accidental deletion

* Updated based on Jeff's comments

- Update download URLs for consistency
- Remove unecessary data copies
- Fix file permissions

* Fix import order

* Update cmd/otelcol/Dockerfile.windows

Co-authored-by: Jeff Cheng <83052155+jeffreyc-splunk@users.noreply.github.com>

* Update cmd/otelcol/Dockerfile.windows

Co-authored-by: Jeff Cheng <83052155+jeffreyc-splunk@users.noreply.github.com>

* Download from github instead of maven

* Add missing space

* Fix version numbering

* Update version style for new remote repo

* Add v back for versioning download

* Update cmd/otelcol/Dockerfile.windows

Co-authored-by: Jeff Cheng <83052155+jeffreyc-splunk@users.noreply.github.com>

* Update cmd/otelcol/Dockerfile.windows

Co-authored-by: Jeff Cheng <83052155+jeffreyc-splunk@users.noreply.github.com>

* Update file names to match downloaded files

* Fix sprintf formatting

* Ensure required directories exist

* Remove unecessary steps

* Make container delay longer, curl into specific filename

* Rename JAR files to match default JMX path

* Fix variable syntax in config file

* Fix jmx integration test

* Increase timeout to see if integration test will pass

* Update cmd/otelcol/Dockerfile.windows

Co-authored-by: Jeff Cheng <83052155+jeffreyc-splunk@users.noreply.github.com>

* Update cmd/otelcol/Dockerfile.windows

Co-authored-by: Jeff Cheng <83052155+jeffreyc-splunk@users.noreply.github.com>

* Fix integration test

* Remove integration test

* Add check for jmx jar path in windows MSI

* Update path setting in windows dockerfile

* Fix path setting variable in windows dockerfile

* Try another variation of dockerfile windows path

* Another try at the path syntax

* Remove extra path arguments

* Use servercore syntax for setting path

* Add missing terminator

* Match servercore

* Move around values

* Try another format for path

* Add integration tests back in

* Ran make fmt

* Get path a different way

* Try debugging failure

* Change tmp dir's name

* Change temp dir's permission

* Try base case without any temp dir

* Manually create tmp dir and mount it

* Remove extra will fail call

* Regular mount, made tmpdir with all permissions

* Create tmp dir in scratch docker image

* Update Java version and re-use with different format

* Use powershell for string replacement

* Fix powershell command formatting

* Fix formatting again

* Try another powershell formatting

* Update variable reference to env reference

* Fix syntax

* Remove command option

* Try moving variable outside parenthesis

* Use explicit setenv method of powershell

* Name directory generic name

* Try to see if tmp dir is reason tests are failing

* Mount local tmpdir for test only

* Manually set local tmp if not set

* Skip integration test when running on arm

* Fix whitespace

* Change method to find arch running test

* Try env variable for go arch

* Add test data for ARM architecture

* Add comment about arm test check

* Update .github/workflows/win-package-test.yml

Co-authored-by: Jeff Cheng <83052155+jeffreyc-splunk@users.noreply.github.com>

* Update cmd/otelcol/Dockerfile

Co-authored-by: Jeff Cheng <83052155+jeffreyc-splunk@users.noreply.github.com>

* Changes suggested by Jeff

- Need to install JMX gatherer at proper path, updated msi builder
and wix file

* Add component ref for JMX gatherer

* Add changelog entry

* Add PR link

* add tmpdir to images

* Bump boto3 in /internal/buildscripts/packaging/release (#3425)

Bumps [boto3](https://github.com/boto/boto3) from 1.28.9 to 1.28.15.
- [Release notes](https://github.com/boto/boto3/releases)
- [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst)
- [Commits](boto/boto3@1.28.9...1.28.15)

---
updated-dependencies:
- dependency-name: boto3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump github.com/aws/aws-sdk-go from 1.44.280 to 1.44.312 in /internal/signalfx-agent (#3427)

* Bump github.com/aws/aws-sdk-go in /internal/signalfx-agent

Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.280 to 1.44.312.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](aws/aws-sdk-go@v1.44.280...v1.44.312)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* make tidy

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: release-bot <ssg-srv-gh-o11y-gdi@splunk.com>

* Bump github.com/snowflakedb/gosnowflake from 1.6.22 to 1.6.23 in /internal/signalfx-agent (#3428)

* Bump github.com/snowflakedb/gosnowflake in /internal/signalfx-agent

Bumps [github.com/snowflakedb/gosnowflake](https://github.com/snowflakedb/gosnowflake) from 1.6.22 to 1.6.23.
- [Release notes](https://github.com/snowflakedb/gosnowflake/releases)
- [Changelog](https://github.com/snowflakedb/gosnowflake/blob/master/release.go)
- [Commits](snowflakedb/gosnowflake@v1.6.22...v1.6.23)

---
updated-dependencies:
- dependency-name: github.com/snowflakedb/gosnowflake
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* make tidy

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: release-bot <ssg-srv-gh-o11y-gdi@splunk.com>

* Bump github.com/docker/docker from 24.0.4+incompatible to 24.0.5+incompatible in /internal/signalfx-agent (#3429)

* Bump github.com/docker/docker in /internal/signalfx-agent

Bumps [github.com/docker/docker](https://github.com/docker/docker) from 24.0.4+incompatible to 24.0.5+incompatible.
- [Release notes](https://github.com/docker/docker/releases)
- [Commits](moby/moby@v24.0.4...v24.0.5)

---
updated-dependencies:
- dependency-name: github.com/docker/docker
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* make tidy

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: release-bot <ssg-srv-gh-o11y-gdi@splunk.com>

* Bump github.com/docker/docker in /tests (#3432)

Bumps [github.com/docker/docker](https://github.com/docker/docker) from 24.0.4+incompatible to 24.0.5+incompatible.
- [Release notes](https://github.com/docker/docker/releases)
- [Commits](moby/moby@v24.0.4...v24.0.5)

---
updated-dependencies:
- dependency-name: github.com/docker/docker
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump org.apache.commons:commons-lang3 (#3434)

Bumps org.apache.commons:commons-lang3 from 3.12.0 to 3.13.0.

---
updated-dependencies:
- dependency-name: org.apache.commons:commons-lang3
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump github.com/prometheus/prometheus from 0.45.0 to 0.46.0 (#3433)

Bumps [github.com/prometheus/prometheus](https://github.com/prometheus/prometheus) from 0.45.0 to 0.46.0.
- [Release notes](https://github.com/prometheus/prometheus/releases)
- [Changelog](https://github.com/prometheus/prometheus/blob/main/CHANGELOG.md)
- [Commits](prometheus/prometheus@v0.45.0...v0.46.0)

---
updated-dependencies:
- dependency-name: github.com/prometheus/prometheus
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Upgrade go to 1.20.6 (#3437)

* Bump github.com/google/cadvisor from 0.47.1 to 0.47.3 in /internal/signalfx-agent (#3431)

* Bump github.com/google/cadvisor in /internal/signalfx-agent

Bumps [github.com/google/cadvisor](https://github.com/google/cadvisor) from 0.47.1 to 0.47.3.
- [Release notes](https://github.com/google/cadvisor/releases)
- [Changelog](https://github.com/google/cadvisor/blob/master/CHANGELOG.md)
- [Commits](google/cadvisor@v0.47.1...v0.47.3)

---
updated-dependencies:
- dependency-name: github.com/google/cadvisor
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* make tidy

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: release-bot <ssg-srv-gh-o11y-gdi@splunk.com>

* Bump github.com/prometheus/prometheus (#3435)

Bumps [github.com/prometheus/prometheus](https://github.com/prometheus/prometheus) from 0.45.0 to 0.46.0.
- [Release notes](https://github.com/prometheus/prometheus/releases)
- [Changelog](https://github.com/prometheus/prometheus/blob/main/CHANGELOG.md)
- [Commits](prometheus/prometheus@v0.45.0...v0.46.0)

---
updated-dependencies:
- dependency-name: github.com/prometheus/prometheus
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update OpenTelemetry Dependencies to latest (#3436)


Co-authored-by: jeffreyc-splunk <jeffreyc@splunk.com>
Co-authored-by: Dmitry Anoshin <anoshindx@gmail.com>

* Cherry-pick a fix for resource detection processor (#3438)

Pull open-telemetry/opentelemetry-collector-contrib#24670 from contrib which was merged right after 0.82.0

* Revert "Revert "OTL-2195: Disable fluentd by default in installer scripts (#3369)" (#3420)" (#3423)

This reverts commit f6dc932.

* OTL-2195: Disable fluentd by default for choco package (#3377)

* set TMPDIR in docker image

* remove unnecesary fixtures and mount

* update gatherer version

* use standard tmp dir in docker image

* fix telegraf-exec test tmp race

* fix windows jdk path

* use jre instead of jdk and disable java otlp log exporter

* Bump pygithub in /internal/buildscripts/packaging/release (#3490)

Bumps [pygithub](https://github.com/pygithub/pygithub) from 1.59.0 to 1.59.1.
- [Release notes](https://github.com/pygithub/pygithub/releases)
- [Changelog](https://github.com/PyGithub/PyGithub/blob/v1.59.1/doc/changes.rst)
- [Commits](PyGithub/PyGithub@v1.59.0...v1.59.1)

---
updated-dependencies:
- dependency-name: pygithub
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump github.com/openzipkin/zipkin-go from 0.4.1 to 0.4.2 in /pkg/receiver/smartagentreceiver (#3492)

* Bump github.com/openzipkin/zipkin-go in /pkg/receiver/smartagentreceiver

Bumps [github.com/openzipkin/zipkin-go](https://github.com/openzipkin/zipkin-go) from 0.4.1 to 0.4.2.
- [Release notes](https://github.com/openzipkin/zipkin-go/releases)
- [Commits](openzipkin/zipkin-go@v0.4.1...v0.4.2)

---
updated-dependencies:
- dependency-name: github.com/openzipkin/zipkin-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* make tidy

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: release-bot <ssg-srv-gh-o11y-gdi@splunk.com>

* Bump boto3 in /internal/buildscripts/packaging/release (#3491)

Bumps [boto3](https://github.com/boto/boto3) from 1.28.15 to 1.28.25.
- [Release notes](https://github.com/boto/boto3/releases)
- [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst)
- [Commits](boto/boto3@1.28.15...1.28.25)

---
updated-dependencies:
- dependency-name: boto3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump golang.org/x/tools from 0.11.1 to 0.12.0 in /internal/tools (#3494)

Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.11.1 to 0.12.0.
- [Release notes](https://github.com/golang/tools/releases)
- [Commits](golang/tools@v0.11.1...v0.12.0)

---
updated-dependencies:
- dependency-name: golang.org/x/tools
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump golang in /examples/prometheus-federation/prom-counter (#3493)

Bumps golang from 1.20.7-bullseye to 1.21.0-bullseye.

---
updated-dependencies:
- dependency-name: golang
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump github.com/golangci/golangci-lint in /internal/tools (#3496)

Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.53.3 to 1.54.1.
- [Release notes](https://github.com/golangci/golangci-lint/releases)
- [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md)
- [Commits](golangci/golangci-lint@v1.53.3...v1.54.1)

---
updated-dependencies:
- dependency-name: github.com/golangci/golangci-lint
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Workaround for windows installer script signing (#3505)

* Bump github.com/antonmedv/expr from 1.12.6 to 1.13.0 in /internal/signalfx-agent (#3503)

* Bump github.com/antonmedv/expr in /internal/signalfx-agent

Bumps [github.com/antonmedv/expr](https://github.com/antonmedv/expr) from 1.12.6 to 1.13.0.
- [Release notes](https://github.com/antonmedv/expr/releases)
- [Commits](expr-lang/expr@v1.12.6...v1.13.0)

---
updated-dependencies:
- dependency-name: github.com/antonmedv/expr
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* make tidy

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: release-bot <ssg-srv-gh-o11y-gdi@splunk.com>

* Bump golang.org/x/net from 0.12.0 to 0.14.0 in /internal/signalfx-agent (#3502)

* Bump golang.org/x/net from 0.12.0 to 0.14.0 in /internal/signalfx-agent

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.12.0 to 0.14.0.
- [Commits](golang/net@v0.12.0...v0.14.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* make tidy

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: release-bot <ssg-srv-gh-o11y-gdi@splunk.com>

* Add a github issue template to send folks to support and splunk ideas (#3487)

* Add a github issue template to send folks to support and splunk ideas

* Update .github/ISSUE_TEMPLATE/config.yml

* enable blank issues

* Bump golang in /examples/splunk-hec-traces/tracing (#3495)

Bumps golang from 1.20.7-bullseye to 1.21.0-bullseye.

---
updated-dependencies:
- dependency-name: golang
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump golang in /examples/splunk-hec/logging (#3497)

Bumps golang from 1.20.7-bullseye to 1.21.0-bullseye.

---
updated-dependencies:
- dependency-name: golang
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump github.com/hashicorp/consul/api in /internal/signalfx-agent (#3500)

Bumps [github.com/hashicorp/consul/api](https://github.com/hashicorp/consul) from 1.22.0 to 1.24.0.
- [Release notes](https://github.com/hashicorp/consul/releases)
- [Changelog](https://github.com/hashicorp/consul/blob/main/CHANGELOG.md)
- [Commits](hashicorp/consul@api/v1.22.0...api/v1.24.0)

---
updated-dependencies:
- dependency-name: github.com/hashicorp/consul/api
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump github.com/hashicorp/golang-lru from 0.6.0 to 1.0.2 in /internal/signalfx-agent (#3501)

* Bump github.com/hashicorp/golang-lru in /internal/signalfx-agent

Bumps [github.com/hashicorp/golang-lru](https://github.com/hashicorp/golang-lru) from 0.6.0 to 1.0.2.
- [Release notes](https://github.com/hashicorp/golang-lru/releases)
- [Commits](hashicorp/golang-lru@v0.6.0...v1.0.2)

---
updated-dependencies:
- dependency-name: github.com/hashicorp/golang-lru
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* make tidy

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: release-bot <ssg-srv-gh-o11y-gdi@splunk.com>

* Bump github.com/beevik/ntp from 1.2.0 to 1.3.0 in /internal/signalfx-agent (#3499)

* Bump github.com/beevik/ntp in /internal/signalfx-agent

Bumps [github.com/beevik/ntp](https://github.com/beevik/ntp) from 1.2.0 to 1.3.0.
- [Release notes](https://github.com/beevik/ntp/releases)
- [Changelog](https://github.com/beevik/ntp/blob/main/RELEASE_NOTES.md)
- [Commits](beevik/ntp@v1.2.0...v1.3.0)

---
updated-dependencies:
- dependency-name: github.com/beevik/ntp
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* make tidy

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: release-bot <ssg-srv-gh-o11y-gdi@splunk.com>

* corect changelog

* update default msi gatherer version

* remove arm-specific telegraf-proctstat test metrics

* corect cl entry location

* update jmx gatherer to 1.29.0

* Update .gitlab/update-openjdk.sh

Co-authored-by: Jeff Cheng <83052155+jeffreyc-splunk@users.noreply.github.com>

* Update cmd/otelcol/Dockerfile

Co-authored-by: Jeff Cheng <83052155+jeffreyc-splunk@users.noreply.github.com>

* move autoconfigure env vars to int test

* Changes requested in PR

- Add java check in windows docker
- Add jmx gatherer to tar

* Add missing parenthesis

* Fix string comparison

* Fix missing paren

* Add test to make sure jar is installed properly

* Test paths for jmx jar

* Update install path for jmx jar

* Pass in version for jmx download method

* Move install path of jmx jar

* Update tests/receivers/jmxreceiver/jmxreceiver_test.go

Co-authored-by: Ryan Fitzpatrick <10867373+rmfitzpatrick@users.noreply.github.com>

* Update internal/buildscripts/packaging/msi/msi-builder/Dockerfile

Co-authored-by: Ryan Fitzpatrick <10867373+rmfitzpatrick@users.noreply.github.com>

* Update internal/buildscripts/packaging/msi/msi-builder/build.sh

Co-authored-by: Ryan Fitzpatrick <10867373+rmfitzpatrick@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Jeff Cheng <83052155+jeffreyc-splunk@users.noreply.github.com>
Co-authored-by: Ryan Fitzpatrick <rfitzpatrick@splunk.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: release-bot <ssg-srv-gh-o11y-gdi@splunk.com>
Co-authored-by: srv-gh-o11y-gdi <98980563+srv-gh-o11y-gdi@users.noreply.github.com>
Co-authored-by: jeffreyc-splunk <jeffreyc@splunk.com>
Co-authored-by: Dmitry Anoshin <anoshindx@gmail.com>
Co-authored-by: Antoine Toulme <antoine@lunar-ocean.com>
Co-authored-by: Ryan Fitzpatrick <10867373+rmfitzpatrick@users.noreply.github.com>
  • Loading branch information
10 people authored Sep 7, 2023
1 parent 83d7a4b commit 328fad4
Show file tree
Hide file tree
Showing 25 changed files with 389 additions and 356 deletions.
15 changes: 11 additions & 4 deletions .github/workflows/win-package-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -195,8 +195,9 @@ jobs:
Start-Sleep -s 30
& ${{ github.workspace }}\.github\workflows\scripts\win-test-services.ps1 -mode "${{ matrix.MODE }}" -access_token "${{ env.token }}" -realm "${{ env.realm }}" -memory "${{ env.memory }}" -with_fluentd "${{ matrix.WITH_FLUENTD }}"
& ${{ github.workspace }}\.github\workflows\scripts\win-test-support-bundle.ps1 -mode "${{ matrix.MODE }}" -with_fluentd "${{ matrix.WITH_FLUENTD }}"
Test-Path -Path "$env:ProgramFiles\Splunk\OpenTelemetry Collector\agent-bundle\python\python.exe"
Test-Path -Path "$env:ProgramFiles\Splunk\OpenTelemetry Collector\agent-bundle\collectd-python"
Resolve-Path -Path "$env:ProgramFiles\Splunk\OpenTelemetry Collector\agent-bundle\python\python.exe"
Resolve-Path -Path "$env:ProgramFiles\Splunk\OpenTelemetry Collector\agent-bundle\collectd-python"
Resolve-Path -Path "$env:SYSTEMDRIVE\opt\opentelemetry-java-contrib-jmx-metrics.jar"
- name: splunk-otel-collector logs
if: ${{ always() }}
Expand Down Expand Up @@ -351,9 +352,9 @@ jobs:
Copy-Item .\bin\translatesfx_windows_amd64.exe .\cmd\otelcol\translatesfx.exe
Copy-Item .\dist\agent-bundle_windows_amd64.zip .\cmd\otelcol\agent-bundle_windows_amd64.zip
if ("${{ matrix.OS }}" -eq "windows-2019") {
docker build -t otelcol-windows --build-arg BASE_IMAGE=mcr.microsoft.com/windows/servercore:1809 -f .\cmd\otelcol\Dockerfile.windows .\cmd\otelcol\
docker build -t otelcol-windows --build-arg BASE_IMAGE=mcr.microsoft.com/windows/servercore:1809 --build-arg JMX_METRIC_GATHERER_RELEASE=$(Get-Content internal\buildscripts\packaging\jmx-metric-gatherer-release.txt) -f .\cmd\otelcol\Dockerfile.windows .\cmd\otelcol\
} else {
docker build -t otelcol-windows --build-arg BASE_IMAGE=mcr.microsoft.com/windows/servercore:ltsc2022 -f .\cmd\otelcol\Dockerfile.windows .\cmd\otelcol\
docker build -t otelcol-windows --build-arg BASE_IMAGE=mcr.microsoft.com/windows/servercore:ltsc2022 --build-arg JMX_METRIC_GATHERER_RELEASE=$(Get-Content internal\buildscripts\packaging\jmx-metric-gatherer-release.txt) -f .\cmd\otelcol\Dockerfile.windows .\cmd\otelcol\
}
Remove-Item .\cmd\otelcol\otelcol.exe
Remove-Item .\cmd\otelcol\translatesfx.exe
Expand All @@ -370,3 +371,9 @@ jobs:
echo "Failing job execution: fail to start otelcol docker container in 10 seconds."
exit 1
}
$JavaCmdOutput=$(docker exec -it otelcol java -version)
if ( ${JavaCmdOutput:0::15} -ne 'openjdk version' ) {
docker logs otelcol
echo "Failing job execution: Failed to run java, command output: ${JavaCmdOutput}"
}
6 changes: 4 additions & 2 deletions .gitlab-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -655,8 +655,9 @@ build-push-windows-image:
$IMAGE_NAME = "quay.io/signalfx/splunk-otel-collector-windows-dev"
$IMAGE_TAG = $env:CI_COMMIT_SHA
}
$JMX_METRIC_GATHERER_RELEASE = $(Get-Content internal\buildscripts\packaging\jmx-metric-gatherer-release.txt)
echo "Building ${IMAGE_NAME}:${IMAGE_TAG}"
docker build -t ${IMAGE_NAME}:${IMAGE_TAG} --build-arg BASE_IMAGE=mcr.microsoft.com/windows/servercore:1809 -f .\cmd\otelcol\Dockerfile.windows .\cmd\otelcol\
docker build -t ${IMAGE_NAME}:${IMAGE_TAG} --build-arg BASE_IMAGE=mcr.microsoft.com/windows/servercore:1809 --build-arg JMX_METRIC_GATHERER_RELEASE=${JMX_METRIC_GATHERER_RELEASE} -f .\cmd\otelcol\Dockerfile.windows .\cmd\otelcol\
echo "Pushing ${IMAGE_NAME}:${IMAGE_TAG}"
docker push ${IMAGE_NAME}:${IMAGE_TAG}
if ($env:CI_COMMIT_BRANCH -eq "main" -or $env:CI_COMMIT_TAG -match '^v\d+\.\d+\.\d+$') {
Expand Down Expand Up @@ -697,8 +698,9 @@ build-push-windows2022-image:
$IMAGE_NAME = "quay.io/signalfx/splunk-otel-collector-windows-dev"
$IMAGE_TAG = "${env:CI_COMMIT_SHA}-2022"
}
$JMX_METRIC_GATHERER_RELEASE = $(Get-Content internal\buildscripts\packaging\jmx-metric-gatherer-release.txt)
echo "Building ${IMAGE_NAME}:${IMAGE_TAG}"
docker build -t ${IMAGE_NAME}:${IMAGE_TAG} --build-arg BASE_IMAGE=mcr.microsoft.com/windows/servercore:ltsc2022 -f .\cmd\otelcol\Dockerfile.windows .\cmd\otelcol\
docker build -t ${IMAGE_NAME}:${IMAGE_TAG} --build-arg BASE_IMAGE=mcr.microsoft.com/windows/servercore:ltsc2022 --build-arg JMX_METRIC_GATHERER_RELEASE=${JMX_METRIC_GATHERER_RELEASE} -f .\cmd\otelcol\Dockerfile.windows .\cmd\otelcol\
echo "Pushing ${IMAGE_NAME}:${IMAGE_TAG}"
docker push ${IMAGE_NAME}:${IMAGE_TAG}
if ($env:CI_COMMIT_BRANCH -eq "main" -or $env:CI_COMMIT_TAG -match '^v\d+\.\d+\.\d+$') {
Expand Down
1 change: 1 addition & 0 deletions .gitlab/update-openjdk.sh
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ create_collector_pr() {
if [[ -n "$version" ]]; then
echo ">>> Updating openjdk version to $version ..."
sed -i "s|^ARG JDK_VERSION=.*|ARG JDK_VERSION=${version}|" internal/signalfx-agent/bundle/Dockerfile
sed -i "s|^ARG JDK_VERSION=.*|ARG JDK_VERSION=\"${version}\"|" cmd/otelcol/Dockerfile.windows
else
echo "ERROR: Failed to get version from tag name '${tag}'!" >&2
exit 1
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

### 💡 Enhancements 💡

- (Splunk) `jmxreceiver`: Bundle latest [JMX Metric Gatherer](https://github.com/open-telemetry/opentelemetry-java-contrib/tree/main/jmx-metrics) in installer packages and images for Windows and Linux ([#3262](https://github.com/signalfx/splunk-otel-collector/pull/3262))
- (Splunk) `solacereceiver`: Added solace receiver to the splunk otel collector ([#3590](https://github.com/signalfx/splunk-otel-collector/pull/3590))
- (Splunk) `receiver/smartagent`: Move to gopsutil 3.23.7 and remove the need to set environment variables ([#3509](https://github.com/signalfx/splunk-otel-collector/pull/3509))
- (Splunk) Update splunk-otel-javaagent to 1.27.0 ([#3537](https://github.com/signalfx/splunk-otel-collector/pull/3537))
Expand Down
7 changes: 4 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ BUILD_X2=-X $(BUILD_INFO_IMPORT_PATH_CORE).Version=$(VERSION)
BUILD_INFO=-ldflags "${BUILD_X1} ${BUILD_X2}"
BUILD_INFO_TESTS=-ldflags "-X $(BUILD_INFO_IMPORT_PATH_TESTS).Version=$(VERSION)"

JMX_METRIC_GATHERER_RELEASE=$(shell cat internal/buildscripts/packaging/jmx-metric-gatherer-release.txt)
SKIP_COMPILE=false
ARCH=amd64
BUNDLE_SUPPORTED_ARCHS := amd64 arm64
Expand Down Expand Up @@ -167,7 +168,7 @@ endif
ifneq ($(filter $(ARCH), $(BUNDLE_SUPPORTED_ARCHS)),)
cp ./dist/agent-bundle_linux_$(ARCH).tar.gz ./cmd/otelcol/dist/agent-bundle.tar.gz
endif
docker buildx build --platform linux/$(ARCH) -o type=image,name=otelcol:$(ARCH),push=false --build-arg ARCH=$(ARCH) --build-arg DOCKER_REPO=$(DOCKER_REPO) ./cmd/otelcol/
docker buildx build --platform linux/$(ARCH) -o type=image,name=otelcol:$(ARCH),push=false --build-arg ARCH=$(ARCH) --build-arg DOCKER_REPO=$(DOCKER_REPO) --build-arg JMX_METRIC_GATHERER_RELEASE=$(JMX_METRIC_GATHERER_RELEASE) ./cmd/otelcol/
docker tag otelcol:$(ARCH) otelcol:latest
rm -rf ./cmd/otelcol/dist

Expand Down Expand Up @@ -221,15 +222,15 @@ ifneq ($(SKIP_BUNDLE), true)
endif
endif
docker build -t otelcol-fpm internal/buildscripts/packaging/fpm
docker run --rm -v $(CURDIR):/repo -e PACKAGE=$* -e VERSION=$(VERSION) -e ARCH=$(ARCH) otelcol-fpm
docker run --rm -v $(CURDIR):/repo -e PACKAGE=$* -e VERSION=$(VERSION) -e ARCH=$(ARCH) -e JMX_METRIC_GATHERER_RELEASE=$(JMX_METRIC_GATHERER_RELEASE) otelcol-fpm

.PHONY: msi
msi:
ifneq ($(SKIP_COMPILE), true)
$(MAKE) binaries-windows_amd64
endif
test -f ./dist/agent-bundle_windows_amd64.zip || (echo "./dist/agent-bundle_windows_amd64.zip not found! Either download a pre-built bundle to ./dist/, or run './internal/signalfx-agent/bundle/scripts/windows/make.ps1 bundle' on a windows host and copy it to ./dist/." && exit 1)
./internal/buildscripts/packaging/msi/build.sh "$(VERSION)" "$(DOCKER_REPO)"
./internal/buildscripts/packaging/msi/build.sh "$(VERSION)" "$(DOCKER_REPO)" "$(JMX_METRIC_GATHERER_RELEASE)"

.PHONY: update-examples
update-examples:
Expand Down
15 changes: 14 additions & 1 deletion cmd/otelcol/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@ RUN chmod 755 /translatesfx
RUN chmod 755 /migratecheckpoint
RUN echo "splunk-otel-collector:x:999:999::/:" > /etc_passwd
# create base dirs since we cannot chown in scratch image except via COPY
RUN mkdir -p /otel/collector /splunk-otel-collector
RUN mkdir -p /otel/collector /splunk-otel-collector /tmp/tmp
# used by jmx receiver to pass tmp properties. Nested to avoid inheriting existing tmp files.
RUN chmod 755 /tmp/tmp

FROM ${DOCKER_REPO}/alpine:3.17.0 AS agent-bundle
ARG ARCH="amd64"
Expand All @@ -35,6 +37,12 @@ RUN if [[ "$ARCH" = "amd64" || "$ARCH" = "arm64" ]]; then \
mkdir -p /usr/lib/splunk-otel-collector/agent-bundle; \
fi

FROM ${DOCKER_REPO}/alpine:3.17.0 AS jmx
ARG JMX_METRIC_GATHERER_RELEASE
RUN JMX_METRICS_JAR=opentelemetry-jmx-metrics.jar && \
URL=https://github.com/open-telemetry/opentelemetry-java-contrib/releases/download/v${JMX_METRIC_GATHERER_RELEASE}/${JMX_METRICS_JAR} && \
cd /tmp && wget "$URL";

FROM ${DOCKER_REPO}/debian:11.5 as journalctl
RUN apt update
RUN apt install -y systemd
Expand All @@ -45,14 +53,19 @@ FROM scratch
ENV SPLUNK_BUNDLE_DIR=/usr/lib/splunk-otel-collector/agent-bundle
ENV SPLUNK_COLLECTD_DIR=${SPLUNK_BUNDLE_DIR}/run/collectd
ENV PATH=${PATH}:${SPLUNK_BUNDLE_DIR}/bin
ENV PATH=${PATH}:${SPLUNK_BUNDLE_DIR}/jre/bin

COPY --from=certs /etc/ssl/certs/ca-certificates.crt /etc/ssl/certs/ca-certificates.crt
COPY --from=otelcol /etc_passwd /etc/passwd
COPY --from=otelcol --chown=999 /otelcol /
COPY --from=otelcol --chown=999 /translatesfx /
COPY --from=otelcol --chown=999 /migratecheckpoint /
COPY --from=otelcol --chown=999 /otel /etc/otel
COPY --from=otelcol --chown=999 /otel/collector /etc/otel/collector
COPY --from=otelcol --chown=999 /tmp/tmp /tmp
COPY --from=agent-bundle --chown=999 /usr/lib/splunk-otel-collector /usr/lib/splunk-otel-collector
COPY --from=jmx --chown=999 /tmp/opentelemetry-jmx-metrics.jar /opt/opentelemetry-java-contrib-jmx-metrics.jar


COPY --from=journalctl --chown=999 /bin/journalctl /bin/journalctl
COPY --from=journalctl --chown=999 /opt/journalctl /
Expand Down
17 changes: 17 additions & 0 deletions cmd/otelcol/Dockerfile.windows
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,23 @@ RUN Add-Type -AssemblyName System.IO.Compression.FileSystem ;\
[System.IO.Compression.ZipFile]::ExtractToDirectory('agent-bundle_windows_amd64.zip', '.')
RUN Remove-Item agent-bundle_windows_amd64.zip -force

# Download JMX Metric Gatherer
ARG JMX_METRIC_GATHERER_RELEASE
RUN New-Item -Path "C:\\" -Name "opt" -ItemType "directory"
RUN Invoke-WebRequest -Uri "https://github.com/open-telemetry/opentelemetry-java-contrib/releases/download/v${env:JMX_METRIC_GATHERER_RELEASE}/opentelemetry-jmx-metrics.jar" -Outfile "c:\opt\opentelemetry-java-contrib-jmx-metrics.jar"

ARG JDK_VERSION="11.0.20_8"
ARG OPENJDK_BASE_URL="https://github.com/adoptium/temurin11-binaries/releases/download"
ENV JAVA_HOME="C:\java\jre"
ENV JAVA_PATH="$JAVA_HOME\bin"
RUN Set-Variable -Name "ENCODED_VER" -Value "\"$env:JDK_VERSION\".replace(\"_\", \"%2B\")"; \
Invoke-WebRequest -Uri "${env:OPENJDK_BASE_URL}/jdk-${ENCODED_VER}/OpenJDK11U-jre_x64_windows_hotspot_${env:JDK_VERSION}.zip" -OutFile "openjdk_jre.zip" ; \
Expand-Archive "openjdk_jre.zip" -DestinationPath "C:\java" ;
RUN Move-Item -Path C:\java\jdk-* -Destination ${Env:JAVA_HOME}
RUN Remove-Item "openjdk_jre.zip" -force
RUN setx /M PATH $(${Env:PATH} + \";${Env:JAVA_PATH}\")
# update otel-java/autoconfigure defaults to prevent undesired telemetry

# Setting environment variables
ENV SPLUNK_BUNDLE_DIR="C:\Program Files\Splunk\OpenTelemetry Collector\agent-bundle"
ENV SPLUNK_CONFIG="C:\ProgramData\Splunk\OpenTelemetry Collector\gateway_config.yaml"
Expand Down
2 changes: 1 addition & 1 deletion internal/buildscripts/packaging/fpm/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ RUN /install-deps.sh

RUN git config --global --add safe.directory /repo

CMD ./internal/buildscripts/packaging/fpm/$PACKAGE/build.sh "$VERSION" "$ARCH" "$OUTPUT_DIR"
CMD ./internal/buildscripts/packaging/fpm/$PACKAGE/build.sh "$VERSION" "$ARCH" "$OUTPUT_DIR" "$JMX_METRIC_GATHERER_RELEASE"
18 changes: 18 additions & 0 deletions internal/buildscripts/packaging/fpm/common.sh
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ SERVICE_INSTALL_PATH="/lib/systemd/system/$SERVICE_NAME.service"

FLUENTD_CONFIG_INSTALL_DIR="/etc/otel/collector/fluentd"

JMX_METRIC_GATHERER_RELEASE_PATH="${FPM_DIR}/../jmx-metric-gatherer-release.txt"
BUNDLE_BASE_DIR="/usr/lib/splunk-otel-collector"
AGENT_BUNDLE_INSTALL_DIR="$BUNDLE_BASE_DIR/agent-bundle"

Expand All @@ -67,6 +68,17 @@ create_user_group() {
sudo useradd --system --user-group --no-create-home --shell /sbin/nologin $SERVICE_USER
}

download_jmx_metric_gatherer() {
local version="$1"
local buildroot="$2"

JMX_METRIC_GATHERER_RELEASE_DL_URL="https://github.com/open-telemetry/opentelemetry-java-contrib/releases/download/v$version/opentelemetry-jmx-metrics.jar"
mkdir -p "$buildroot/opt"

echo "Downloading ${JMX_METRIC_GATHERER_RELEASE_DL_URL}"
curl -sL "$JMX_METRIC_GATHERER_RELEASE_DL_URL" -o "$buildroot/opt/opentelemetry-java-contrib-jmx-metrics.jar"
}

setup_files_and_permissions() {
local otelcol="$1"
local translatesfx="$2"
Expand Down Expand Up @@ -104,4 +116,10 @@ setup_files_and_permissions() {
sudo chown -R $SERVICE_USER:$SERVICE_GROUP "$buildroot/$BUNDLE_BASE_DIR"
sudo chmod -R 755 "$buildroot/$BUNDLE_BASE_DIR"
fi

JMX_INSTALL_PATH="$buildroot/opt/opentelemetry-java-contrib-jmx-metrics.jar"
if [[ -e "$JMX_INSTALL_PATH" ]]; then
sudo chown root:root "$JMX_INSTALL_PATH"
sudo chmod 755 "$JMX_INSTALL_PATH"
fi
}
7 changes: 7 additions & 0 deletions internal/buildscripts/packaging/fpm/deb/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -22,18 +22,25 @@ SCRIPT_DIR="$( cd "$( dirname ${BASH_SOURCE[0]} )" && pwd )"
VERSION="${1:-}"
ARCH="${2:-amd64}"
OUTPUT_DIR="${3:-$REPO_DIR/dist}"
JMX_METRIC_GATHERER_RELEASE="${4:-}"

if [[ -z "$VERSION" ]]; then
VERSION="$( get_version )"
fi
VERSION="${VERSION#v}"

if [[ -z "$JMX_METRIC_GATHERER_RELEASE" ]]; then
JMX_METRIC_GATHERER_RELEASE="$(cat $JMX_METRIC_GATHERER_RELEASE_PATH)"
fi

otelcol_path="$REPO_DIR/bin/otelcol_linux_${ARCH}"
translatesfx_path="$REPO_DIR/bin/translatesfx_linux_${ARCH}"
agent_bundle_path="$REPO_DIR/dist/agent-bundle_linux_${ARCH}.tar.gz"

buildroot="$(mktemp -d)"

download_jmx_metric_gatherer "$JMX_METRIC_GATHERER_RELEASE" "$buildroot"

setup_files_and_permissions "$otelcol_path" "$translatesfx_path" "$buildroot" "$agent_bundle_path"

mkdir -p "$OUTPUT_DIR"
Expand Down
7 changes: 7 additions & 0 deletions internal/buildscripts/packaging/fpm/rpm/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ SCRIPT_DIR="$( cd "$( dirname ${BASH_SOURCE[0]} )" && pwd )"
VERSION="${1:-}"
ARCH="${2:-amd64}"
OUTPUT_DIR="${3:-$REPO_DIR/dist}"
JMX_METRIC_GATHERER_RELEASE="${4:-}"

if [[ -z "$VERSION" ]]; then
VERSION="$( get_version )"
Expand All @@ -31,6 +32,10 @@ fi
VERSION="${VERSION/'-'/'~'}"
VERSION="${VERSION#v}"

if [[ -z "$JMX_METRIC_GATHERER_RELEASE" ]]; then
JMX_METRIC_GATHERER_RELEASE="$(cat $JMX_METRIC_GATHERER_RELEASE_PATH)"
fi

otelcol_path="$REPO_DIR/bin/otelcol_linux_${ARCH}"
translatesfx_path="$REPO_DIR/bin/translatesfx_linux_${ARCH}"
agent_bundle_path="$REPO_DIR/dist/agent-bundle_linux_${ARCH}.tar.gz"
Expand All @@ -43,6 +48,8 @@ elif [[ "$ARCH" = "amd64" ]]; then
ARCH="x86_64"
fi

download_jmx_metric_gatherer "$JMX_METRIC_GATHERER_RELEASE" "$buildroot"

setup_files_and_permissions "$otelcol_path" "$translatesfx_path" "$buildroot" "$agent_bundle_path"

mkdir -p "$OUTPUT_DIR"
Expand Down
9 changes: 9 additions & 0 deletions internal/buildscripts/packaging/fpm/tar/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,21 @@ tar_setup_files_and_permissions() {
sudo chown root:root "$buildroot/$TRANSLATESFX_INSTALL_PATH"
sudo chmod 755 "$buildroot/$TRANSLATESFX_INSTALL_PATH"

JMX_METRIC_GATHERER_RELEASE="$(cat $JMX_METRIC_GATHERER_RELEASE_PATH)"
download_jmx_metric_gatherer "$JMX_METRIC_GATHERER_RELEASE" "$buildroot/$BUNDLE_BASE_DIR"
JMX_INSTALL_PATH="$buildroot/$BUNDLE_BASE_DIR/opt/opentelemetry-java-contrib-jmx-metrics.jar"
if [[ -e "$JMX_INSTALL_PATH" ]]; then
sudo chown root:root "$JMX_INSTALL_PATH"
sudo chmod 755 "$JMX_INSTALL_PATH"
fi

if [[ -n "$bundle_path" ]]; then
mkdir -p "$buildroot/$BUNDLE_BASE_DIR"
tar -xzf "$bundle_path" -C "$buildroot/$BUNDLE_BASE_DIR"
sudo chown -R root:root "$buildroot/$BUNDLE_BASE_DIR"
sudo chmod -R 755 "$buildroot/$BUNDLE_BASE_DIR"
fi

}

if [[ -z "$VERSION" ]]; then
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
1.29.0
7 changes: 7 additions & 0 deletions internal/buildscripts/packaging/msi/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,11 @@ set -euxo pipefail

SCRIPT_DIR="$( cd "$( dirname ${BASH_SOURCE[0]} )" && pwd )"
REPO_DIR="$( cd "$SCRIPT_DIR/../../../../" && pwd )"
JMX_METRIC_GATHERER_RELEASE_PATH="${SCRIPT_DIR}/../jmx-metric-gatherer-release.txt"

VERSION="${1:-}"
DOCKER_REPO="${2:-docker.io}"
JMX_METRIC_GATHERER_RELEASE="${3:-}"

get_version() {
commit_tag="$( git -C "$REPO_DIR" describe --abbrev=0 --tags --exact-match --match 'v[0-9]*' 2>/dev/null || true )"
Expand All @@ -36,6 +38,10 @@ get_version() {
fi
}

if [ -z "$JMX_METRIC_GATHERER_RELEASE" ]; then
JMX_METRIC_GATHERER_RELEASE=$(cat "$JMX_METRIC_GATHERER_RELEASE_PATH")
fi

if [ -z "$VERSION" ]; then
VERSION="$( get_version )"
fi
Expand All @@ -44,6 +50,7 @@ docker build -t msi-builder --build-arg DOCKER_REPO="$DOCKER_REPO" -f "${SCRIPT_
docker rm -fv msi-builder 2>/dev/null || true
docker run -d --name msi-builder msi-builder sleep inf
docker exec \
-e JMX_METRIC_GATHERER_RELEASE="${JMX_METRIC_GATHERER_RELEASE}" \
-e OUTPUT_DIR=/project/dist \
-e VERSION="${VERSION#v}" \
msi-builder /docker-entrypoint.sh
Expand Down
1 change: 1 addition & 0 deletions internal/buildscripts/packaging/msi/msi-builder/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ RUN cp /project/internal/buildscripts/packaging/msi/msi-builder/docker-entrypoin
chmod a+x /docker-entrypoint.sh

ENV OUTPUT_DIR=/project/dist
ENV JMX_METRIC_GATHERER_RELEASE=1.29.0
ENV VERSION=""

WORKDIR /work
Expand Down
Loading

0 comments on commit 328fad4

Please sign in to comment.