Support filters and pdata being emitted from monitors #5379
+330
−152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
force-pushed
the
support_pdata
branch
5 times, most recently
from
643ff99
to
15df734
Compare
dmitryax
reviewed
Sep 18, 2024
atoulme
force-pushed
the
support_pdata
branch
from
e0ac65c
to
9b88fba
Compare
atoulme
force-pushed
the
support_pdata
branch
from
23cbd97
to
c95136d
Compare
dmitryax
reviewed
Sep 27, 2024
| @@ -208,6 +209,41 @@ func (out *output) Copy() types.Output { | |||
| return &cp | |||
| } | |||
|
|
|||
| func (out *output) SendMetrics(metrics ...pmetric.Metric) { | |||
There was a problem hiding this comment.
Is this function wired to the code? I don't see it being used... It's unclear what the scope of the PR is. If this only adds filtering capability without using it, this function must be unrelated I guess.
There was a problem hiding this comment.
It's not used yet, this PR is a smaller take on #4243 which wires this function into the prometheus monitor.
atoulme
force-pushed
the
support_pdata
branch
from
c95136d
to
ac0536d
Compare
atoulme
force-pushed
the
support_pdata
branch
from
ac0536d
to
9b98fa9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This adds the ability for the monitors to emit pdata.
A simplified cut of #4243, it no longer is applying the changes to the prometheus monitor.