Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft: add converter to update batch processor #5387

Closed
wants to merge 1 commit into from
Closed

Draft: add converter to update batch processor #5387

wants to merge 1 commit into from

Conversation

asreehari-splunk
Copy link
Contributor

when sapm exporter enables token_access_passthrough use this converter to add include_metadata with the right header key

Description:

Link to Splunk idea: <Link to Splunk idea, see https://ideas.splunk.com>

Testing:

Documentation:

samiura
samiura reviewed Sep 19, 2024
View reviewed changes
Copy link
Contributor

@samiura samiura left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:LGTM, I would like someone to look at the sapm configuration.

dmitryax
dmitryax reviewed Sep 19, 2024
View reviewed changes
Copy link
Contributor

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the default config file agent_config.yaml as well

internal/settings/settings_test.go Outdated Show resolved Hide resolved
internal/configconverter/update_batchproc_on_token_passthrough.go Outdated Show resolved Hide resolved
pjanotti
pjanotti reviewed Sep 19, 2024
View reviewed changes
Copy link
Contributor

@pjanotti pjanotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit & personal preference: instead of _w_ and _wo_ on the test files I would rather use _with_ and _no_, up to you.

internal/configconverter/update_batchproc_on_token_passthrough.go Show resolved Hide resolved
internal/configconverter/update_batchproc_on_token_passthrough.go Outdated Show resolved Hide resolved
internal/configconverter/update_batchproc_on_token_passthrough_test.go Show resolved Hide resolved
@asreehari-splunk asreehari-splunk force-pushed the OTL-2920/IncludeMetaData branch 5 times, most recently from 0c95517 to 31e0bf6 Compare September 20, 2024 15:45
@asreehari-splunk
add converter to update batch processor
6f85316 
when sapm exporter enables token_access_passthrough
use this converter to add include_metadata with the
right header key
@asreehari-splunk
Copy link
Contributor Author

closing in favor of #5408 after benchmarking the batch processor

@asreehari-splunk
Copy link
Contributor Author

closing

@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pjanotti pjanotti pjanotti left review comments

@dmitryax dmitryax dmitryax left review comments

@samiura samiura samiura left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asreehari-splunk @pjanotti @dmitryax @samiura