Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate jaegergrpc #5428

Merged
merged 4 commits into from
Sep 30, 2024
Merged

deprecate jaegergrpc #5428

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
711b9fe
deprecate jaegergrpc
atoulme Aug 1, 2024
dd8a98f
Update CHANGELOG.md
atoulme Sep 30, 2024
7abd2d9
Update internal/signalfx-agent/pkg/monitors/jaegergrpc/metadata.yaml
atoulme Sep 30, 2024
8902bf1
Update internal/signalfx-agent/pkg/monitors/jaegergrpc/monitor.go
atoulme Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### 🚩Deprecations 🚩

- (Splunk) Deprecate the jaegergrpc monitor ([#](https://github.com/signalfx/splunk-otel-collector/pull/))
atoulme marked this conversation as resolved.
Show resolved Hide resolved

## v0.110.0

This Splunk OpenTelemetry Collector release includes changes from the [opentelemetry-collector v0.110.0](https://github.com/open-telemetry/opentelemetry-collector/releases/tag/v0.110.0) and the [opentelemetry-collector-contrib v0.110.0](https://github.com/open-telemetry/opentelemetry-collector-contrib/releases/tag/v0.110.0) releases where appropriate.
Expand Down
3 changes: 3 additions & 0 deletions internal/signalfx-agent/pkg/monitors/jaegergrpc/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
monitors:
- dimensions:
doc: |
The jaegergrpc monitor is deprecated and will be removed in a future release.
Use the jaegerreceiver instead.
atoulme marked this conversation as resolved.
Show resolved Hide resolved
Runs a GRPC server that listens for Jaeger trace batches
and forwards them to SignalFx (or the configured ingest host in the
`writer` section of the agent config). By default, the server listens on
Expand Down
1 change: 1 addition & 0 deletions internal/signalfx-agent/pkg/monitors/jaegergrpc/monitor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ func (m *Monitor) setupListener(ctx context.Context, conf *Config) (net.Listener
// Configure the monitor and kick off volume metric syncing
func (m *Monitor) Configure(conf *Config) error {
m.logger = utils.NewThrottledLogger(log.WithFields(log.Fields{"monitorType": monitorType, "monitorID": conf.MonitorID}), 30*time.Second)
m.logger.Warn("[NOTICE] The jaegergrpc monitor is deprecated and will be removed in a future release. Use the jaegerreceiver instead.")
atoulme marked this conversation as resolved.
Show resolved Hide resolved
ctx, cancel := context.WithCancel(context.Background())
m.cancel = cancel

Expand Down
Loading