-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add envoy metrics discovery bundle #5780
base: main
Are you sure you want to change the base?
Conversation
7e05283
to
ae8d40b
Compare
ae8d40b
to
097a7ca
Compare
I tested this locally. It worked well enough on my machine. |
# rule: | ||
# docker_observer: type == "container" and any([name, image, command], {# matches "(?i)envoy"}) and not (command matches "splunk.discovery") | ||
# host_observer: type == "hostport" and command matches "(?i)envoy" and not (command matches "splunk.discovery") | ||
# k8s_observer: type == "port" and pod.name matches "(?i)envoy" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the k8s rule intentionally matching just pod name instead of the broader rule used by docker_observer? Istio sidecars for e.g. have pod name like istio-proxy
, the image name might have envoy in it. But maybe we should only match standalone envoy to startwith
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, you had a note about that. I think we can update the rule to add istio-proxy but then I really need a test showing this works for an istio mesh.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am tempted to make a separate integration test with a kind cluster, we deploy everything and we make sure it works. I might get into that next and tweak the rule based on that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should merge this one as-is. And have a different item to officially support istio. It is not just the pod name; default prom port used by istio is also not same as the one here. Don't know if it is supported in deiscover mode, but it would be better getting the port/path from the prometheus.io annotations for istio (like we have in our helm chart).
Discover mode config test TestDockerObserver is failing
|
Description:
Adds a new discovery bundle targeting envoy proxy metrics.