[mod_amqp] implement dynamic mem alloc for longer messages to prevent buffer overflow#2982
Open
mahald wants to merge 1 commit intosignalwire:masterfrom
Open
[mod_amqp] implement dynamic mem alloc for longer messages to prevent buffer overflow#2982mahald wants to merge 1 commit intosignalwire:masterfrom
mahald wants to merge 1 commit intosignalwire:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
[mod_amqp]
Under some circumstances such as for example long inline dialplans with parallel ringings that need to set several variables per leg using mod_amqp it could happen that the fixed buffer is too small to retrieve the message. This could lead to errors and a buffer overflow.
To prevent this we implement a dynamic allocation of if the message is bigger then the current fixed buffer.