Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: issue #76 #157

Closed
wants to merge 2 commits into from
Closed

Conversation

Antoninich
Copy link

It is more correct to change the description line in signum-node.
image

@pir8radio
Copy link
Collaborator

I would rather not do one off things, i hope that the devs change this description to match SRC44 so we can just decode it like we do everything else in the explorer.

Example this:
image

Becomes this:
image

@ohager
Copy link
Member

ohager commented Nov 13, 2023

I would rather not do one off things, i hope that the devs change this description to match SRC44 so we can just decode it like we do everything else in the explorer.

Example this: image

Becomes this: image

I mentioned it here... The NFT was created before SRC44... the contracts descriptor is not SRC44 compatible, but if you resolve the IPFS hash in the descriptor you get a JSON with all media data. Changing the descriptor for NFT contracts now, is much more effort than treating it in the explorer tbh. We have an entire backend and some additional tools that uses the non-SRC44 format

Here is an example of the JSON in referenced in NFT descriptor field.
https://ipfs.io/ipfs/bafkreifgan3pg344vhz3tnjq26mzfmt4cmxy5lb6y74jkxobrz4xzq54lm

from this NFT https://chain.signum.network/at/2978638295822152791

@ohager
Copy link
Member

ohager commented Nov 15, 2023

We are changing the NFTs description to be SRC44 compatible... I think we can close this PR.

@pir8radio
Copy link
Collaborator

closing, thanks @ohager

@pir8radio pir8radio closed this Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants