Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix electra light client types #6002

Open
realbigsean opened this issue Jun 26, 2024 · 2 comments
Open

Fix electra light client types #6002

realbigsean opened this issue Jun 26, 2024 · 2 comments
Labels
bug Something isn't working electra Required for the Electra/Prague fork light-client

Comments

@realbigsean
Copy link
Member

Description

Noticed the EF SSZ tests were failing for some light client types. Looks like it's due to FINALIZED_ROOT_GINDEX, CURRENT_SYNC_COMMITTEE_GINDEX and NEXT_SYNC_COMMITTEE_GINDEX being updated, resulting in the lengths of fields in some types being updated

  • LightClientUpdate
  • LightClientFinalityUpdate
  • LightClientBootstrap

This spec PR obviates the problem and makes more electra related updates:

https://github.com/ethereum/consensus-specs/pull/3811/files#diff-3c5f5d62f6d1d14d3324c9c37b025560ee9ccb335770a28f553ed374bc56e385R31
@realbigsean realbigsean added bug Something isn't working electra Required for the Electra/Prague fork labels Jun 26, 2024
@michaelsproul michaelsproul mentioned this issue Aug 26, 2024
Merged
@michaelsproul
Copy link
Member

With v1.5.0-alpha.5 I think we are unblocked on this. The changes required will be quite pervasive though, as the changing proof length requires many fixes.

Related spec PR:

Related LH update:

@eserilev
Copy link
Collaborator

going to pick this one up

@eserilev eserilev mentioned this issue Sep 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working electra Required for the Electra/Prague fork light-client
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@michaelsproul @realbigsean @eserilev