Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Electra spec v1.5.0-alpha.5 #6305

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

michaelsproul
Copy link
Member

@michaelsproul michaelsproul commented Aug 26, 2024

Proposed Changes

Implement the Electra spec changes for v1.5.0-alpha.5. As far as I can tell the only substantive change was from v1.5.0-alpha.4:

I have made no attempt to update for the PeerDAS changes. That can happen in another PR once this one is merged:

I started on trying to update the Electra types, but it got quite involved quite quickly, so I've just commented out those tests for now. We can handle updating them as part of:

@michaelsproul michaelsproul added ready-for-review The code is ready for review consensus An issue/PR that touches consensus code, such as state_processing or block verification. electra Required for the Electra/Prague fork labels Aug 26, 2024
Copy link
Collaborator

@dapplion dapplion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM we can fix LC types latter

@michaelsproul
Copy link
Member Author

@mergify queue

Copy link

mergify bot commented Aug 26, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at e09fe5a

@mergify mergify bot merged commit e09fe5a into sigp:unstable Aug 26, 2024
28 checks passed
@michaelsproul michaelsproul deleted the spec-1.5.0-alpha.5 branch August 26, 2024 22:55
AgeManning pushed a commit to AgeManning/lighthouse that referenced this pull request Sep 3, 2024
* Implement spec v1.5.0-alpha.5

* Merge remote-tracking branch 'origin/unstable' into spec-1.5.0-alpha.5

* Ignore broken Electra light client tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consensus An issue/PR that touches consensus code, such as state_processing or block verification. electra Required for the Electra/Prague fork ready-for-review The code is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants