Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - CommitteeCache.initialized: fail early if possible #4556

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - CommitteeCache.initialized: fail early if possible #4556

wants to merge 1 commit into from

Conversation

zhiqiangxu
Copy link
Contributor

@zhiqiangxu zhiqiangxu commented Aug 1, 2023 •
edited by bors bot
Loading

No description provided.

paulhauner
paulhauner approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@paulhauner paulhauner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.

I don't think we will ever actually run this code, a state.validators with a length of 2**64 - 1 would be hundreds of thousands of petabytes. However, I'm happy to merge this since it is technically/theoretically better.

@paulhauner paulhauner changed the base branch from stable to unstable August 2, 2023 07:37
@paulhauner
Copy link
Member

Oh, could you please push an empty commit to make Github realise that I've changed the target branch 🙏

@paulhauner paulhauner added waiting-on-author The reviewer has suggested changes and awaits thier implementation. consensus An issue/PR that touches consensus code, such as state_processing or block verification. labels Aug 2, 2023
@paulhauner paulhauner self-assigned this Aug 2, 2023
@zhiqiangxu zhiqiangxu force-pushed the opt_CommitteeCache.initialized branch from 8157b83 to b22d1d7 Compare August 2, 2023 07:50
@zhiqiangxu
Copy link
Contributor Author

Oh, could you please push an empty commit to make Github realise that I've changed the target branch 🙏

Done:)

@paulhauner paulhauner added ready-for-merge This PR is ready to merge. and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Aug 2, 2023
@paulhauner
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Aug 2, 2023
@zhiqiangxu
CommitteeCache.initialized: fail early if possible (#4556)
1d2bbf2
@bors
Copy link

bors bot commented Aug 2, 2023

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Aug 2, 2023
@zhiqiangxu
CommitteeCache.initialized: fail early if possible (#4556)
b5e25ae
@bors
Copy link

bors bot commented Aug 3, 2023

Pull request successfully merged into unstable.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title CommitteeCache.initialized: fail early if possible [Merged by Bors] - CommitteeCache.initialized: fail early if possible Aug 3, 2023
@bors bors bot closed this Aug 3, 2023
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
@zhiqiangxu @Woodpile37
CommitteeCache.initialized: fail early if possible (sigp#4556)
6e098b4
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
@zhiqiangxu @Woodpile37
CommitteeCache.initialized: fail early if possible (sigp#4556)
d40c073
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulhauner paulhauner paulhauner approved these changes

Assignees

@paulhauner paulhauner

Labels
consensus An issue/PR that touches consensus code, such as state_processing or block verification. ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhiqiangxu @paulhauner