Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added required --force-bls-withdrawal-credentials description to --disable-deposits usage #6436

Merged
merged 9 commits into from
Oct 10, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions book/src/help_bn.md
Original file line number Diff line number Diff line change
Expand Up @@ -603,6 +603,4 @@ Flags:
-z, --zero-ports
Sets all listening TCP/UDP ports to 0, allowing the OS to choose some
arbitrary free ports.
```

<style> .content main {max-width:88%;} </style>
```n<style> .content main {max-width:88%;} </style>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks wrong, did the script do this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which OS did you run it on?

Copy link
Author

@hopinheimer hopinheimer Sep 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ran a make cli-local

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mac os

Copy link
Author

@hopinheimer hopinheimer Sep 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I thought something was off but the scripts/cli.sh had this

Screenshot 2024-09-26 at 12 10 11 AM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that regexp might need a tweak? it looks the same as the Linux one?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well today I learned I'm still a noob programmer, but yeah I was defeated by a linux command.
I think using a printf just like the command to add the code block quote right above this line just solves the problem in an easy way and sed is just a little ambiguous for different distros.

there's another issue I'd like to point out

Screenshot 2024-09-26 at 9 39 40 AM

when I run make cli which uses docker this happens, if that would have worked I would have not come across the current issue. do you want to create a separate tracking issue for that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I don't think that image is ever going to be public. Maybe that's just a doc issue

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it is public but it doesn't work on ARM.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have Rosetta you can run x86_64 images on macOS using emulation. It's slower but it works.

4 changes: 1 addition & 3 deletions book/src/help_general.md
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,4 @@ Flags:
permissions will be inherited from the parent folder.
--stdin-inputs
If present, read all user inputs from stdin instead of tty.
```

<style> .content main {max-width:88%;} </style>
```n<style> .content main {max-width:88%;} </style>
4 changes: 1 addition & 3 deletions book/src/help_vc.md
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,4 @@ Flags:
If present, the validator client will use longer timeouts for requests
made to the beacon node. This flag is generally not recommended,
longer timeouts can cause missed duties when fallbacks are used.
```

<style> .content main {max-width:88%;} </style>
```n<style> .content main {max-width:88%;} </style>
4 changes: 1 addition & 3 deletions book/src/help_vm.md
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,4 @@ Flags:
permissions will be inherited from the parent folder.
--stdin-inputs
If present, read all user inputs from stdin instead of tty.
```

<style> .content main {max-width:88%;} </style>
```n<style> .content main {max-width:88%;} </style>
8 changes: 4 additions & 4 deletions book/src/help_vm_create.md
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,9 @@ Flags:
When provided don't generate the deposits JSON file that is commonly
used for submitting validator deposits via a web UI. Using this flag
will save several seconds per validator if the user has an alternate
strategy for submitting deposits.
strategy for submitting deposits. If used, the
--force-bls-withdrawal-credentials is also required to ensure users
are aware that an --eth1-withdrawal-address is not set.
--disable-log-timestamp
If present, do not include timestamps in logging output.
--disable-malloc-tuning
Expand Down Expand Up @@ -164,6 +166,4 @@ Flags:
is safely backed up.
--stdin-inputs
If present, read all user inputs from stdin instead of tty.
```

<style> .content main {max-width:88%;} </style>
```n<style> .content main {max-width:88%;} </style>
4 changes: 1 addition & 3 deletions book/src/help_vm_import.md
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,4 @@ Flags:
permissions will be inherited from the parent folder.
--stdin-inputs
If present, read all user inputs from stdin instead of tty.
```

<style> .content main {max-width:88%;} </style>
```n<style> .content main {max-width:88%;} </style>
4 changes: 1 addition & 3 deletions book/src/help_vm_move.md
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,4 @@ Flags:
permissions will be inherited from the parent folder.
--stdin-inputs
If present, read all user inputs from stdin instead of tty.
```

<style> .content main {max-width:88%;} </style>
```n<style> .content main {max-width:88%;} </style>
4 changes: 3 additions & 1 deletion validator_manager/src/create_validators.rs
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,9 @@ pub fn cli_app() -> Command {
"When provided don't generate the deposits JSON file that is \
commonly used for submitting validator deposits via a web UI. \
Using this flag will save several seconds per validator if the \
user has an alternate strategy for submitting deposits.",
user has an alternate strategy for submitting deposits. \
If used, the --force-bls-withdrawal-credentials is also required \
to ensure users are aware that an --eth1-withdrawal-address is not set.",
)
.action(ArgAction::SetTrue)
.help_heading(FLAG_HEADER)
Expand Down
Loading