Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly configure the required checks for model-transparency #479

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

mihaimaruseac
Copy link
Contributor

Summary

I was wrong in #478: the checks need to be as they show up in the job name, not how they show up in the GHA summary at the bottom of the PR.

Since I used the wrong ones, sigstore/model-transparency#284 is now waiting on checks that cannot run. But I can fix that by closing and reopening once the required checks are in the correct format.

Sorry for double work in reviewing!

Release Note

NONE

Documentation

NONE

I was wrong in sigstore#478: the checks need to be as they show up in the job
name, not how they show up in the GHA summary at the bottom of the PR.

Since I used the wrong ones,
sigstore/model-transparency#284 is now waiting
on checks that cannot run. But I cna fix that by closing and reopening
once the required checks are in the correct format.

Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>
Copy link

🍹 preview on sigstore-github-sync/sigstore/github-prod

Pulumi report
  Previewing update (sigstore/github-prod)

View Live: https://app.pulumi.com/sigstore/sigstore-github-sync/github-prod/previews/1aec8fde-ecdd-4062-aa34-ed26dddd7b6b

@ Previewing update.....
pulumi:pulumi:Stack: (same)
  [urn=urn:pulumi:github-prod::sigstore-github-sync::pulumi:pulumi:Stack::sigstore-github-sync-github-prod]
  ~ github:index/branchProtection:BranchProtection: (update)
      [id=BPR_kwDOKKk2Ts4DA1PL]
      [urn=urn:pulumi:github-prod::sigstore-github-sync::github:index/branchProtection:BranchProtection::model-transparency-main]
      [provider=urn:pulumi:github-prod::sigstore-github-sync::pulumi:providers:github::default_6_2_3::dfb01c0f-bb2a-45c2-9d92-e6152b5cee06]
    ~ requiredStatusChecks: [
        ~ [0]: {
                ~ contexts: [
                    - [0]: "Lint / Type Check (pull_request)"
                    + [1]: "Lint whitespace"
                    ~ [2]: "Run unit tests / Signing with Python 3.11 on Linux (pull_request)" => "Python lint"
                    ~ [3]: "Lint / Lint whitespace (pull_request)" => "Type Check"
                    ~ [4]: "Run unit tests / Signing with Python 3.12 on Linux (pull_request)" => "Signing with Python 3.11 on Linux"
                    ~ [5]: "Lint / Python lint (pull_request)" => "Signing with Python 3.12 on Linux"
                  ]
              }
      ]
@ Previewing update....
Resources:
  ~ 1 to update
  591 unchanged
  

@haydentherapper haydentherapper merged commit 6253637 into sigstore:main Aug 14, 2024
2 checks passed
@mihaimaruseac
Copy link
Contributor Author

Works now! Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants