Switch e2e test docker-compose to docker compose
#3816
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`docker-compose` was removed from the ubuntu-latest and windows GitHub Actions runners late last week: actions/runner-images#9692 I don't follow the ecosystem closely enough to understand it, but apparently `docker compose` is what most people are using to work around this. Signed-off-by: Zach Steindler <steiza@github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3816 +/- ##
==========================================
- Coverage 40.10% 39.19% -0.91%
==========================================
Files 155 202 +47
Lines 10044 10049 +5
==========================================
- Hits 4028 3939 -89
+ Misses 5530 5524 -6
- Partials 486 586 +100 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Zach Steindler <steiza@github.com>
Signed-off-by: Zach Steindler <steiza@github.com>
|
Let's work on #3809 instead. |
cmurphy
reviewed
Aug 5, 2024
| @@ -19,7 +19,7 @@ set -ex | |||
| echo "setting up OIDC provider" | |||
| pushd ./test/fakeoidc | |||
| oidcimg=$(ko build main.go --local) | |||
| docker network ls | grep fulcio_default || docker network create fulcio_default | |||
| docker network ls | grep fulcio_default || docker network create --label com.docker.compose.network=fulcio_default fulcio_default | |||
There was a problem hiding this comment.
This works for me if I have
Suggested change
| docker network ls | grep fulcio_default || docker network create --label com.docker.compose.network=fulcio_default fulcio_default | |
| docker network ls | grep fulcio_default || docker network create --label com.docker.compose.network=default fulcio_default |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Many cosign pull requests have e2e test failing, such as https://github.com/sigstore/cosign/actions/runs/10238677353/job/28323361888?pr=3808.
Apparently this is because
docker-composewas removed from the ubuntu-latest and windows GitHub Actions runners late last week:actions/runner-images#9692
I don't follow the ecosystem closely enough to understand it, but apparently
docker composeis what most people are using to work around this.Release Note
NONE
Documentation
N/A