Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a log message if user doesn't provide --trusted-root #3933

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

steiza
Copy link
Member

@steiza steiza commented Nov 11, 2024

Summary

Fixes #3932.

So the user knows that we're assuming the public good instance and fetching the trusted root via TUF.

Release Note

NONE

Documentation

N/A

So the user knows that we're assuming the public good instance and
fetching the trusted root via TUF.

Signed-off-by: Zach Steindler <steiza@github.com>
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 36.35%. Comparing base (2ef6022) to head (4414cc8).
Report is 237 commits behind head on main.

Files with missing lines Patch % Lines
cmd/cosign/cli/verify/verify_bundle.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3933      +/-   ##
==========================================
- Coverage   40.10%   36.35%   -3.76%     
==========================================
  Files         155      209      +54     
  Lines       10044    13380    +3336     
==========================================
+ Hits         4028     4864     +836     
- Misses       5530     7890    +2360     
- Partials      486      626     +140     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haydentherapper haydentherapper merged commit 93b72d2 into sigstore:main Nov 13, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn users if fetching trusted root via TUF
2 participants