[DRAFT] Create new-idp-requirements.md #1447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1447 +/- ##
==========================================
- Coverage 57.67% 57.58% -0.10%
==========================================
Files 50 50
Lines 3112 3112
==========================================
- Hits 1795 1792 -3
- Misses 1158 1160 +2
- Partials 159 160 +1 ☔ View full report in Codecov by Sentry. |
haydentherapper
requested changes
Nov 3, 2023
|
@haydentherapper This one is ready for another round of reviews. I think I got everything but let me know if I missed something or if anything needs more details. |
Creating a new document to capture the requirements for adding a new IDP to Sigstore Public Deployment Signed-off-by: Paul Welch <pwelch@github.com>
Signed-off-by: Paul Welch <pwelch@github.com>
docs/new-idp-requirements.md
Outdated
|
|
||
| You should also reference the [Fulcio - ODIC.md](https://github.com/sigstore/fulcio/blob/main/docs/oidc.md) documentation for additional requirements for the type of IDP you're looking to integrate. The current two likely types of IDPs are: | ||
|
|
||
| - `Email` - Email-based OIDC providers use the user’s email as the subject of the certificate. |
There was a problem hiding this comment.
Can we change this to also mention service accounts? It can either be user-based authentication or machine identity for SAs
There was a problem hiding this comment.
I think I captured what you're looking for but let me know if not
Signed-off-by: Paul Welch <pwelch@github.com>
haydentherapper
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Starting a new document to capture the requirements for adding a new IDP to Sigstore Public Deployment as proposed in #397
Release Note
Documentation