-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds cert-utility. #1870
feat: adds cert-utility. #1870
Conversation
5f05997
to
1f2eb04
Compare
2471698
to
450b214
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1870 +/- ##
==========================================
- Coverage 57.93% 52.08% -5.85%
==========================================
Files 50 73 +23
Lines 3119 5646 +2527
==========================================
+ Hits 1807 2941 +1134
- Misses 1154 2431 +1277
- Partials 158 274 +116 ☔ View full report in Codecov by Sentry. |
2fbc59f
to
aa6d7aa
Compare
61d9f68
to
8193f47
Compare
i think this is ready for 👀 now. just a couple of notes.
i think that about covers it. |
Thanks @ianhundere, I’ll take a look at this later this week. |
563de59
to
78b06b6
Compare
… consistent w/ flags. Signed-off-by: ianhundere <138915+ianhundere@users.noreply.github.com>
…e flag to gcp-credentials-file. Signed-off-by: ianhundere <138915+ianhundere@users.noreply.github.com>
Signed-off-by: ianhundere <138915+ianhundere@users.noreply.github.com>
Signed-off-by: ianhundere <138915+ianhundere@users.noreply.github.com>
Signed-off-by: ianhundere <138915+ianhundere@users.noreply.github.com>
Signed-off-by: ianhundere <138915+ianhundere@users.noreply.github.com>
Signed-off-by: ianhundere <138915+ianhundere@users.noreply.github.com>
…son error. Signed-off-by: ianhundere <138915+ianhundere@users.noreply.github.com>
…per, and other PR fb. Signed-off-by: ianhundere <138915+ianhundere@users.noreply.github.com>
82bd95b
to
21ebe36
Compare
Signed-off-by: ianhundere <138915+ianhundere@users.noreply.github.com>
8769dc9
to
385226d
Compare
@haydentherapper okidoki, i implemented all your suggested feedback including templating. the behavior now is that templates will be included via the embed package which are used as defaults / a user can still use their own templates to take advantage of https://pkg.go.dev/go.step.sm/crypto/x509util for advanced use-cases. |
385226d
to
5356758
Compare
…vements. Signed-off-by: ianhundere <138915+ianhundere@users.noreply.github.com>
5356758
to
819a5de
Compare
…mplates. Signed-off-by: ianhundere <138915+ianhundere@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the great work on this!
absolutely, the tsa PR is also up for review. have a good wknd! |
@ianhundere Just realized one thing when reviewing the TSA PR. Should we remove the leaf certificate template processing from Fulcio? For the TSA, this is needed, as the leaf certificate signs timestamps. For Fulcio, Fulcio is the CA so it issues leaf certificates. |
@haydentherapper ah, good point / so just to confirm, essentially remove all elements associated w/ leaf cert creation (e.g. leaf template, flags etc), correct ? and should i do that in a separate PR ? |
Sorry for two separate threads! I just replied on the TSA PR as well. I'd suggest that we make the leaf cert creation optional, and then point TSA operators to this repo, which will reduce code duplication. The only thing we need in the TSA repo then is the TSA templates for root/intermediate/leaf and a README. |
closes #1869
Summary
currently, there is no standard method for creating cert chains for fulcio or tsa. the community has used an assortment of open source scripts/tools, but i thought it would be nice to have a small cloud agnostic go app to create/sign (via awskms, gcpkms, or azurekms) certificates. the smallstep crypto library is fairly comprehensive in its kms/cert capabilities.
@haydentherapper / @bobcallaway gave the go ahead in proceeding w/ this work.
Release Note
Documentation
added docs to
./docs
folder and updatedREADME.md
to point to docs.