Skip to content

Commit

Permalink
Remove "."
Browse files Browse the repository at this point in the history
Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>
  • Loading branch information
mihaimaruseac committed Jul 25, 2024
1 parent 95f0077 commit 9e24b0d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions model_signing/manifest/manifest.py
Original file line number Diff line number Diff line change
Expand Up @@ -112,11 +112,11 @@ def resource_descriptors(self) -> Iterator[ResourceDescriptor]:
"""Yields each resource from the manifest, one by one.
In this case, we have only one descriptor to return. Since model paths
are already encoded in the digest, use "." for the identifier.
are already encoded in the digest, use "" for the identifier.
Subclasses might record additional fields to have distinguishable human
readable identifiers.
"""
yield ResourceDescriptor(identifier=".", digest=self.digest)
yield ResourceDescriptor(identifier="", digest=self.digest)


class ItemizedManifest(Manifest):
Expand Down
2 changes: 1 addition & 1 deletion model_signing/manifest/manifest_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def test_manifest_has_the_correct_resource_descriptor(self):
manifest_file = manifest.DigestManifest(digest)

for descriptor in manifest_file.resource_descriptors():
assert descriptor.identifier == "."
assert descriptor.identifier == ""
assert descriptor.digest == digest


Expand Down

0 comments on commit 9e24b0d

Please sign in to comment.