fix --update_goldens for serialization module #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Writing the sharded serializer golden files involves sorting _Shard items, so they must be orderable. Previous attempts to update goldens would result in a TypeError. Signed-off-by: Spencer Schrock <sschrock@google.com>
mihaimaruseac
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Thank you!
Internally this doesn't fail, and I only included the fix in #245 instead of the good PR.
Thanks for catching!
It does actually. The
Didn't catch this whoops! |
|
Oh, I only ran the tests at the top of the chain :| That's on me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Writing the sharded serializer golden files involves sorting
_Sharditems, so they must be orderable. Previous attempts to update goldens would result in aTypeError:Release Note
NONE
Documentation
NONE