Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent serialization of symlinks by default #251

Merged
merged 6 commits into from
Jul 24, 2024
Merged

prevent serialization of symlinks by default #251

merged 6 commits into from
Jul 24, 2024

Conversation

spencerschrock
Copy link
Contributor

@spencerschrock spencerschrock commented Jul 23, 2024 •
edited
Loading

Summary

Adds a serializer initializer argument (allow_symlink) to control whether symlinks raise a ValueError during serialization.

For rationale, see #196 (comment)

Release Note

NONE

Documentation

NONE

@spencerschrock spencerschrock mentioned this pull request Jul 23, 2024
Closed
@spencerschrock
add serialization test for symlink model file
69a8a38 
Signed-off-by: Spencer Schrock <sschrock@google.com>
@spencerschrock
prevent serialization of symlinks by default
c998722 
This can be changed via the allow_symlink argument in the various
serialization initializers.

Signed-off-by: Spencer Schrock <sschrock@google.com>
@spencerschrock spencerschrock changed the title add serialization test for symlink model file prevent serialization of symlinks by default Jul 24, 2024
@spencerschrock spencerschrock marked this pull request as ready for review July 24, 2024 17:52
@spencerschrock spencerschrock requested review from a team as code owners July 24, 2024 17:52
@mihaimaruseac mihaimaruseac added this to the V1 release milestone Jul 24, 2024
mihaimaruseac
mihaimaruseac reviewed Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This LGTM.

Added a request to change the test fixture to be a directory and then some minor nits here and there.

model_signing/conftest.py Outdated Show resolved Hide resolved
model_signing/serialization/serialize_by_file.py Outdated Show resolved Hide resolved
model_signing/serialization/serialize_by_file.py Outdated Show resolved Hide resolved
model_signing/serialization/serialize_by_file.py Outdated Show resolved Hide resolved
model_signing/serialization/serialize_by_file.py Outdated Show resolved Hide resolved
model_signing/serialization/serialize_by_file.py Outdated Show resolved Hide resolved
model_signing/serialization/serialize_by_file_shard.py Outdated Show resolved Hide resolved
model_signing/serialization/serialize_by_file_shard.py Show resolved Hide resolved
model_signing/serialization/serialize_by_file_shard.py Outdated Show resolved Hide resolved
model_signing/serialization/serialize_by_file_shard_test.py Outdated Show resolved Hide resolved
@spencerschrock
convert symlink file fixture to symlink directory fixture
475edd5 
Signed-off-by: Spencer Schrock <sschrock@google.com>
@spencerschrock
Address style and documentation feedback
5c863b4 
Signed-off-by: Spencer Schrock <sschrock@google.com>
mihaimaruseac
mihaimaruseac previously approved these changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

mihaimaruseac
mihaimaruseac approved these changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you!

@mihaimaruseac mihaimaruseac merged commit 9798149 into sigstore:main Jul 24, 2024
20 checks passed
@spencerschrock spencerschrock deleted the symlink-test branch July 24, 2024 20:41
@spencerschrock spencerschrock mentioned this pull request Jul 30, 2024
Merged
@spencerschrock spencerschrock mentioned this pull request Aug 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
V1 release
Development

Successfully merging this pull request may close these issues.
2 participants
@spencerschrock @mihaimaruseac